[GitHub] thrift pull request #1311: Fix for constant assignments to optional fields i...

2017-07-24 Thread davinchia
Github user davinchia commented on a diff in the pull request: https://github.com/apache/thrift/pull/1311#discussion_r129124617 --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc --- @@ -424,6 +424,52 @@ bool t_go_generator::is_pointer_field(t_field* tfield, bool

[GitHub] thrift pull request #1311: Fix for constant assignments to optional fields i...

2017-07-22 Thread Jens-G
Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1311#discussion_r128901829 --- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc --- @@ -424,6 +424,52 @@ bool t_go_generator::is_pointer_field(t_field* tfield, bool

[GitHub] thrift pull request #1311: Fix for constant assignments to optional fields i...

2017-07-20 Thread davinchia
GitHub user davinchia opened a pull request: https://github.com/apache/thrift/pull/1311 Fix for constant assignments to optional fields in Go. As per ticket https://issues.apache.org/jira/browse/THRIFT-4253. As I dug through the code I realised the problem was not only