[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user gadLinux closed the pull request at: https://github.com/apache/thrift/pull/930 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98028242 --- Diff: lib/c_glib/test/Makefile.am --- @@ -37,16 +37,17 @@ BUILT_SOURCES = \ gen-c_glib/t_test_thrift_test_types.h AM_CPPFLAGS =

[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98027875 --- Diff: lib/c_glib/test/CMakeLists.txt --- @@ -108,13 +108,6 @@ add_test(NAME testoptionalrequired COMMAND testoptionalrequired)

[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98027723 --- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_platform_socket.h --- @@ -0,0 +1,120 @@ +/* --- End diff -- I tottally agree. It's

[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user gadLinux commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98027454 --- Diff: configure.ac --- @@ -199,6 +196,12 @@ if test "$with_c_glib" = "yes"; then fi AM_CONDITIONAL(WITH_C_GLIB, [test "$have_glib2" = "yes" -a

[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98002795 --- Diff: lib/c_glib/test/owncloud.level2crm.pem --- @@ -0,0 +1,59 @@ +-BEGIN CERTIFICATE-

[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98003039 --- Diff: configure.ac --- @@ -199,6 +196,12 @@ if test "$with_c_glib" = "yes"; then fi AM_CONDITIONAL(WITH_C_GLIB, [test "$have_glib2" = "yes" -a

[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98003689 --- Diff: lib/c_glib/test/Makefile.am --- @@ -37,16 +37,17 @@ BUILT_SOURCES = \ gen-c_glib/t_test_thrift_test_types.h AM_CPPFLAGS =

[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98003481 --- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_platform_socket.h --- @@ -0,0 +1,120 @@ +/* --- End diff -- This looks a lot like

[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98003205 --- Diff: lib/c_glib/Makefile.am --- @@ -45,6 +45,7 @@ libthrift_c_glib_la_SOURCES = src/thrift/c_glib/thrift.c \

[GitHub] thrift pull request #930: THRIFT-3369 : Implement SSL/TLS support on C with ...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/930#discussion_r98003634 --- Diff: lib/c_glib/test/CMakeLists.txt --- @@ -108,13 +108,6 @@ add_test(NAME testoptionalrequired COMMAND testoptionalrequired)