[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-06-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13673980#comment-13673980 ] Hudson commented on THRIFT-1977: Integrated in Thrift #659 (See [https://builds.apache.or

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-06-03 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13673757#comment-13673757 ] Jens Geyer commented on THRIFT-1977: Agree to the additional underscore prefix. Disag

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-06-03 Thread Carl Yeksigian (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13673654#comment-13673654 ] Carl Yeksigian commented on THRIFT-1977: Does it make more sense to put the FileN

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-05-27 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668033#comment-13668033 ] Hudson commented on THRIFT-1977: Integrated in Thrift #648 (See [https://builds.apache.or

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-05-27 Thread Carl Yeksigian (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668002#comment-13668002 ] Carl Yeksigian commented on THRIFT-1977: +1 I think this is the best compromise

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-05-27 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667959#comment-13667959 ] Jens Geyer commented on THRIFT-1977: {quote} 1. When you have const list or map, two

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-05-27 Thread Deniss Afonin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667681#comment-13667681 ] Deniss Afonin commented on THRIFT-1977: --- Yeah, see attached testcases_v2_fixed.zip

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-05-27 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667661#comment-13667661 ] Jens Geyer commented on THRIFT-1977: Could you provide a testcase?

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-05-27 Thread Deniss Afonin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667648#comment-13667648 ] Deniss Afonin commented on THRIFT-1977: --- There are 2 issues with v2 patch. 1. When

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-05-26 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667260#comment-13667260 ] Jens Geyer commented on THRIFT-1977: Hi [~afds], I'd like to know your opinion about

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-05-24 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1343#comment-1343 ] Jens Geyer commented on THRIFT-1977: BTW the workaround for the original problem woul

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-05-24 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666597#comment-13666597 ] Jens Geyer commented on THRIFT-1977: I do see the issue, but I'm not happy with the s

[jira] [Commented] (THRIFT-1977) C# compiler should generate constant files prefixed with thrift file name

2013-05-24 Thread Carl Yeksigian (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13666215#comment-13666215 ] Carl Yeksigian commented on THRIFT-1977: +1 > C# compiler should