[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137652#comment-15137652 ] John Sirois commented on THRIFT-2157: - Turns out THRIFT-3112 does not reveal similar

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132976#comment-15132976 ] John Sirois commented on THRIFT-2157: - Linking this to THRIFT-3112 which preliminary investigation of

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131098#comment-15131098 ] John Sirois commented on THRIFT-2157: - [~jensg] or [~mbreslow] Is there more coming in this fix? As

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122391#comment-15122391 ] ASF GitHub Bot commented on THRIFT-2157: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117746#comment-15117746 ] ASF GitHub Bot commented on THRIFT-2157: GitHub user mbreslow opened a pull request:

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117875#comment-15117875 ] Marc Breslow commented on THRIFT-2157: -- Hi [~iker.jimenez] and [~dvdreddy], I took a stab at

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117977#comment-15117977 ] ASF GitHub Bot commented on THRIFT-2157: Github user bgould commented on a diff in the pull

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117988#comment-15117988 ] ASF GitHub Bot commented on THRIFT-2157: Github user bgould commented on a diff in the pull

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118019#comment-15118019 ] ASF GitHub Bot commented on THRIFT-2157: Github user mbreslow commented on the pull request:

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118031#comment-15118031 ] ASF GitHub Bot commented on THRIFT-2157: Github user bgould commented on a diff in the pull

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118040#comment-15118040 ] ASF GitHub Bot commented on THRIFT-2157: Github user bgould commented on the pull request:

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487529#comment-14487529 ] Iker Jimenez commented on THRIFT-2157: -- Hey, got a chance to work on this yet?

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487530#comment-14487530 ] Iker Jimenez commented on THRIFT-2157: -- Hey, got a chance to work on this yet?

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14487592#comment-14487592 ] deepankar commented on THRIFT-2157: --- Sorry, I worked on it a little, let me see if I

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379593#comment-14379593 ] Jens Geyer commented on THRIFT-2157: The base class for Thrift exceptions is

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379916#comment-14379916 ] Patrick Dunne commented on THRIFT-2157: --- Yes, but the code generator mistakenly

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380383#comment-14380383 ] Iker Jimenez commented on THRIFT-2157: -- Hi [~jensg], so I've looked into this a bit

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380591#comment-14380591 ] deepankar commented on THRIFT-2157: --- Now on more deeper inspection, I observed that

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380542#comment-14380542 ] deepankar commented on THRIFT-2157: --- If we have to modify the generated code, we may

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380790#comment-14380790 ] deepankar commented on THRIFT-2157: --- Now I see, it make sense to

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380789#comment-14380789 ] Iker Jimenez commented on THRIFT-2157: -- Should we explore overloading sendResponse

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380774#comment-14380774 ] deepankar commented on THRIFT-2157: --- One more question is that TBase is usually

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380783#comment-14380783 ] Iker Jimenez commented on THRIFT-2157: -- you are right, the javadoc does say Generic

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380820#comment-14380820 ] deepankar commented on THRIFT-2157: --- Let me try to put a patch to see how big of a

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380763#comment-14380763 ] Jens Geyer commented on THRIFT-2157: Just to be sure I understand it right: *The

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380709#comment-14380709 ] Dave Brosius commented on THRIFT-2157: -- Having TApplicationException implement TBase

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380765#comment-14380765 ] Iker Jimenez commented on THRIFT-2157: -- [~dvdreddy]I guess it depends on how you are

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380777#comment-14380777 ] Iker Jimenez commented on THRIFT-2157: -- Regarding compatibility, in Java there is no

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380806#comment-14380806 ] deepankar commented on THRIFT-2157: --- I think the best is to add one more Interface

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380814#comment-14380814 ] Iker Jimenez commented on THRIFT-2157: -- Yes, leaning towards that approach too. A

[jira] [Commented] (THRIFT-2157) generated code would cause ClassCastException

[ https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14380813#comment-14380813 ] Iker Jimenez commented on THRIFT-2157: -- Yes, leaning towards that approach too. A