[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13869990#comment-13869990
]
Henrique Mendonça commented on THRIFT-2205:
---
Thanks for the awesome works guys,
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870065#comment-13870065
]
Pierre Lamot commented on THRIFT-2205:
--
@henrique the tests runs but fails (from the
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868767#comment-13868767
]
Pierre Lamot commented on THRIFT-2205:
--
I confirm 2308 and 1647 (similar solution in
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867914#comment-13867914
]
Pierre Lamot commented on THRIFT-2205:
--
One more tiny thing.
In
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868285#comment-13868285
]
Hudson commented on THRIFT-2205:
FAILURE: Integrated in Thrift #992 (See
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868295#comment-13868295
]
Randy Abernethy commented on THRIFT-2205:
-
[~jensg] Related patch notes:
2308 –
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866469#comment-13866469
]
Randy Abernethy commented on THRIFT-2205:
-
Hi Pierre,
There are a number of
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866616#comment-13866616
]
Pierre Lamot commented on THRIFT-2205:
--
Hi,
I prepared a patch fixing this
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866926#comment-13866926
]
Pierre Lamot commented on THRIFT-2205:
--
@randy:
I did a fresh clone of the repo and
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866961#comment-13866961
]
Randy Abernethy commented on THRIFT-2205:
-
Hi Pierre,
I just did a fresh clone
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867126#comment-13867126
]
Randy Abernethy commented on THRIFT-2205:
-
Hi Pierre,
Yeah, I made some notes
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867186#comment-13867186
]
Pierre Lamot commented on THRIFT-2205:
--
Hi randy,
As I understand it, the length
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867220#comment-13867220
]
Randy Abernethy commented on THRIFT-2205:
-
Hey Pierre,
Just looked at the code
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867406#comment-13867406
]
Pierre Lamot commented on THRIFT-2205:
--
Hi,
your welcome, thank you
One more
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865261#comment-13865261
]
Pierre Lamot commented on THRIFT-2205:
--
your algorithm to find the end of the json
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865303#comment-13865303
]
Randy Abernethy commented on THRIFT-2205:
-
Hello Pierre,
Good point. Any chance
Hello Pierre,
Good point. Any chance you can update your patch to apply over the 2205
patch and add a single bracket string test? If not I will try to update
2205 to apply over your patch later this week.
Best,
Randy
On Wed, Jan 8, 2014 at 1:54 AM, Pierre Lamot (JIRA) j...@apache.org wrote:
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865618#comment-13865618
]
Henrique Mendonça commented on THRIFT-2205:
---
Hi Randy,
Thanks so much for the
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865912#comment-13865912
]
Pierre Lamot commented on THRIFT-2205:
--
Hi,
You *must* use new on the exceptions
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865020#comment-13865020
]
Randy Abernethy commented on THRIFT-2205:
-
This is a large patch and includes:
[
https://issues.apache.org/jira/browse/THRIFT-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791895#comment-13791895
]
Randy Abernethy commented on THRIFT-2205:
-
Hey Henrique,
You give back a ton to
21 matches
Mail list logo