[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349640#comment-16349640
]
Craig Ringer commented on THRIFT-2471:
--
I think a mistake may have been made in this commit, because
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873176#comment-15873176
]
ASF GitHub Bot commented on THRIFT-2471:
Github user jeking3 commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026352#comment-14026352
]
Henrique Mendonça commented on THRIFT-2471:
---
Hi Jens,
It seems to require
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14026467#comment-14026467
]
Hudson commented on THRIFT-2471:
SUCCESS: Integrated in Thrift #1175 (See
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989108#comment-13989108
]
Jens Geyer commented on THRIFT-2471:
boost 1_53_0, everything fine over here.
Make
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989137#comment-13989137
]
Hudson commented on THRIFT-2471:
FAILURE: Integrated in Thrift #1146 (See
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988119#comment-13988119
]
Roger Meier commented on THRIFT-2471:
-
+1
do you commit Jens?
@all: doc updates are
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988185#comment-13988185
]
ASF GitHub Bot commented on THRIFT-2471:
Github user asfgit closed the pull
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13986115#comment-13986115
]
ASF GitHub Bot commented on THRIFT-2471:
GitHub user djwatson opened a pull
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978567#comment-13978567
]
Ben Craig commented on THRIFT-2471:
---
[~henrique] : There are some challenges with using
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13978613#comment-13978613
]
Henrique Mendonça commented on THRIFT-2471:
---
Hi guys,
Yes Ben, I see the
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13977611#comment-13977611
]
Randy Abernethy commented on THRIFT-2471:
-
I like the shared_ptr approach
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13975996#comment-13975996
]
Henrique Mendonça commented on THRIFT-2471:
---
+1 for changing the cpp.ref to
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976264#comment-13976264
]
Jens Geyer commented on THRIFT-2471:
Not bad. The {{}} proposal sounds good to me and
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973885#comment-13973885
]
Randy Abernethy commented on THRIFT-2471:
-
Hey Dave,
In the C++ implementation
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974267#comment-13974267
]
Dave Watson commented on THRIFT-2471:
-
Facebook's current use cases do not contain
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974274#comment-13974274
]
Ben Craig commented on THRIFT-2471:
---
I'd rather not try to fix cycles magically. MSRPC
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974313#comment-13974313
]
Randy Abernethy commented on THRIFT-2471:
-
unique_ptr is a great implementation.
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13974315#comment-13974315
]
Jens Geyer commented on THRIFT-2471:
{quote}
I'd rather not try to fix cycles
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972006#comment-13972006
]
Randy Abernethy commented on THRIFT-2471:
-
Hey All,
Just curious, is cpp.ref
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972071#comment-13972071
]
Dave Watson commented on THRIFT-2471:
-
It's necessary for languages that use value
[
https://issues.apache.org/jira/browse/THRIFT-2471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13972321#comment-13972321
]
Randy Abernethy commented on THRIFT-2471:
-
Hey Jens Dave, thanks for the brain
22 matches
Mail list logo
