[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077195#comment-16077195
]
ASF GitHub Bot commented on THRIFT-2642:
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076684#comment-16076684
]
julien greard commented on THRIFT-2642:
---
Just did it, looks fine to me
> Recursive structs
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076667#comment-16076667
]
Eric Conner commented on THRIFT-2642:
-
Ok [~juliengreard] I believe I have addressed all of your
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075576#comment-16075576
]
ASF GitHub Bot commented on THRIFT-2642:
Github user econner commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075577#comment-16075577
]
ASF GitHub Bot commented on THRIFT-2642:
Github user econner commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075575#comment-16075575
]
ASF GitHub Bot commented on THRIFT-2642:
Github user econner commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075536#comment-16075536
]
julien greard commented on THRIFT-2642:
---
Ok it should be better now !
> Recursive structs don't
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075532#comment-16075532
]
ASF GitHub Bot commented on THRIFT-2642:
Github user juliengreard commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075531#comment-16075531
]
ASF GitHub Bot commented on THRIFT-2642:
Github user juliengreard commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075528#comment-16075528
]
ASF GitHub Bot commented on THRIFT-2642:
Github user juliengreard commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075529#comment-16075529
]
ASF GitHub Bot commented on THRIFT-2642:
Github user juliengreard commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075527#comment-16075527
]
ASF GitHub Bot commented on THRIFT-2642:
Github user juliengreard commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075530#comment-16075530
]
ASF GitHub Bot commented on THRIFT-2642:
Github user juliengreard commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075519#comment-16075519
]
Eric Conner commented on THRIFT-2642:
-
Hi Julien,
I cannot see your comments. Did you submit them
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075452#comment-16075452
]
julien greard commented on THRIFT-2642:
---
Ok it's done, do you see my comments/reviews?
>
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075429#comment-16075429
]
julien greard commented on THRIFT-2642:
---
Hi,
I'll try a review, but it's my first one on github and
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075394#comment-16075394
]
ASF GitHub Bot commented on THRIFT-2642:
Github user econner commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075370#comment-16075370
]
ASF GitHub Bot commented on THRIFT-2642:
Github user Jens-G commented on a diff in the pull
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075360#comment-16075360
]
Jens Geyer commented on THRIFT-2642:
> Thanks for the follow up. This pull request
>
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075348#comment-16075348
]
Eric Conner commented on THRIFT-2642:
-
Hi [~jensg],
Thanks for the follow up. This pull request
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075330#comment-16075330
]
Jens Geyer commented on THRIFT-2642:
> I think that's thrift should be working the same no matter
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074792#comment-16074792
]
julien greard commented on THRIFT-2642:
---
Hi,
My company uses thrift & python. We use a workaround
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16074774#comment-16074774
]
Eric Conner commented on THRIFT-2642:
-
Hi everyone,
Just curious if there's still any desire to get
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057856#comment-16057856
]
ASF GitHub Bot commented on THRIFT-2642:
Github user econner commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057851#comment-16057851
]
ASF GitHub Bot commented on THRIFT-2642:
GitHub user econner reopened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057819#comment-16057819
]
ASF GitHub Bot commented on THRIFT-2642:
Github user econner commented on the issue:
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057820#comment-16057820
]
ASF GitHub Bot commented on THRIFT-2642:
Github user econner closed the pull request at:
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057106#comment-16057106
]
julien greard commented on THRIFT-2642:
---
Hi
Thanks for the work, I'll have a look this week. I
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056824#comment-16056824
]
Eric Conner commented on THRIFT-2642:
-
Hi everyone,
I finally had some time to take a stab at fixing
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16056825#comment-16056825
]
ASF GitHub Bot commented on THRIFT-2642:
GitHub user econner opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008348#comment-16008348
]
Igor Rogozhin commented on THRIFT-2642:
---
Actualy my team switched to java, but if you need help you
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008223#comment-16008223
]
Jens Geyer commented on THRIFT-2642:
[~allengeorge],
I am fine with it as long as
a) the proposed
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005819#comment-16005819
]
Allen George commented on THRIFT-2642:
--
[~jensg] Can I implement the approach discussed above?
>
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856364#comment-15856364
]
Lars Schöning commented on THRIFT-2642:
---
I also just came across this issue. Fbthrift has a
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387504#comment-15387504
]
Igor Rogozhin commented on THRIFT-2642:
---
Hello from 2016.
We still have this problem.
I am using
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970521#comment-14970521
]
Eric Conner commented on THRIFT-2642:
-
The problem is in thrift_spec which is used only by
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635689#comment-14635689
]
Jens Geyer commented on THRIFT-2642:
[~juliengreard] What do you have so far?
Any
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635740#comment-14635740
]
julien greard commented on THRIFT-2642:
---
Right now, I have a workaround, I have to
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14635029#comment-14635029
]
julien greard commented on THRIFT-2642:
---
Hello,
Do you know if this bug is planned
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14541728#comment-14541728
]
julien greard commented on THRIFT-2642:
---
Hi,
Thanks for the indication about the
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14542749#comment-14542749
]
Jens Geyer commented on THRIFT-2642:
You will be, just fire away :-)
Just remember,
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540703#comment-14540703
]
Jens Geyer commented on THRIFT-2642:
Hi,
there is a help icon which lists all the
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539620#comment-14539620
]
julien greard commented on THRIFT-2642:
---
I did my own work around:
in the example
[
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539571#comment-14539571
]
julien greard commented on THRIFT-2642:
---
Hello,
Is there a work around for this
44 matches
Mail list logo