[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

2014-11-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197509#comment-14197509 ] Hudson commented on THRIFT-2784: SUCCESS: Integrated in Thrift #1331 (See

[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

2014-10-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14178938#comment-14178938 ] Hudson commented on THRIFT-2784: SUCCESS: Integrated in Thrift #1317 (See

[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

2014-10-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14179173#comment-14179173 ] Hudson commented on THRIFT-2784: SUCCESS: Integrated in Thrift #1319 (See

[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

2014-10-15 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172334#comment-14172334 ] Jens Geyer commented on THRIFT-2784: That enum is an edge case. The IDL allows it

[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

2014-10-14 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171586#comment-14171586 ] Roger Meier commented on THRIFT-2784: - MyEnum5 was introduced with THRIFT-2513 and it

[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

2014-10-13 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14169461#comment-14169461 ] Roger Meier commented on THRIFT-2784: - Thanks John, just committed your patch.

[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

2014-10-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14169520#comment-14169520 ] Hudson commented on THRIFT-2784: SUCCESS: Integrated in Thrift #1313 (See

[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

2014-10-13 Thread John Campbell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170142#comment-14170142 ] John Campbell commented on THRIFT-2784: --- Well, that's generating bad C++ -- I had

[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

2014-10-13 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170150#comment-14170150 ] Konrad Grochowski commented on THRIFT-2784: --- as a workaround - use -Wpedantic,

[jira] [Commented] (THRIFT-2784) Eliminate compiler warnings in generated C++ code

2014-10-13 Thread John Campbell (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170161#comment-14170161 ] John Campbell commented on THRIFT-2784: --- Ok, after thinking about this for a bit, I