[jira] [Commented] (THRIFT-3791) Delphi pipe client may fail even in a non-error condition

2016-04-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253199#comment-15253199 ] Hudson commented on THRIFT-3791: SUCCESS: Integrated in Thrift-precommit #438 (See [http

[jira] [Commented] (THRIFT-3791) Delphi pipe client may fail even in a non-error condition

2016-04-19 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248740#comment-15248740 ] Jens Geyer commented on THRIFT-3791: Good catch, by the way. > Delphi pipe client ma

[jira] [Commented] (THRIFT-3791) Delphi pipe client may fail even in a non-error condition

2016-04-19 Thread Kyle Johnson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248728#comment-15248728 ] Kyle Johnson commented on THRIFT-3791: -- True, only a handle. Just if we wanted to e

[jira] [Commented] (THRIFT-3791) Delphi pipe client may fail even in a non-error condition

2016-04-19 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248723#comment-15248723 ] Jens Geyer commented on THRIFT-3791: No critsects, not necessary. Use interlocked if

[jira] [Commented] (THRIFT-3791) Delphi pipe client may fail even in a non-error condition

2016-04-19 Thread Kyle Johnson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248720#comment-15248720 ] Kyle Johnson commented on THRIFT-3791: -- The problem is that it isn't, at least with

[jira] [Commented] (THRIFT-3791) Delphi pipe client may fail even in a non-error condition

2016-04-19 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15248636#comment-15248636 ] Jens Geyer commented on THRIFT-3791: It is thread safe w/regard to the close() method

[jira] [Commented] (THRIFT-3791) Delphi pipe client may fail even in a non-error condition

2016-04-19 Thread Kyle Johnson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247804#comment-15247804 ] Kyle Johnson commented on THRIFT-3791: -- It's not necessary to test IsOpen because it

[jira] [Commented] (THRIFT-3791) Delphi pipe client may fail even in a non-error condition

2016-04-19 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247729#comment-15247729 ] Jens Geyer commented on THRIFT-3791: Why don't we test IsOpen anymore? > Delphi pipe