[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864496#comment-15864496 ] ASF GitHub Bot commented on THRIFT-4060: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-13 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863569#comment-15863569 ] Konrad Grochowski commented on THRIFT-4060: --- IMHO: ifdef is still better because it allows

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863020#comment-15863020 ] ASF GitHub Bot commented on THRIFT-4060: Github user jeking3 commented on a diff in the pull

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862886#comment-15862886 ] James E. King, III commented on THRIFT-4060: In my PR I have already added a compiler

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-11 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862503#comment-15862503 ] Konrad Grochowski commented on THRIFT-4060: --- ok, I did not get that {{MyHigher}} etc. was a try

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-10 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861701#comment-15861701 ] James E. King, III commented on THRIFT-4060: One use case of this is if you stream these

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-10 Thread Konrad Grochowski (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861577#comment-15861577 ] Konrad Grochowski commented on THRIFT-4060: --- I do not completely follow your example: `set`

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861564#comment-15861564 ] ASF GitHub Bot commented on THRIFT-4060: Github user hcorg commented on a diff in the pull

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-09 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859670#comment-15859670 ] James E. King, III commented on THRIFT-4060: [~hcorg], I would appreciate your input on this

[jira] [Commented] (THRIFT-4060) Thrift printTo ostream overload mechanism breaks down when types are nested

2017-02-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848469#comment-15848469 ] ASF GitHub Bot commented on THRIFT-4060: Github user jeking3 commented on the issue: