[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756793#comment-16756793 ] Jim Apple commented on THRIFT-4138: --- It seems like I should also check {{str.fail()}},

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756765#comment-16756765 ] Jim Apple commented on THRIFT-4138: --- OK, if I'm re-reading this correctly, the very pr

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756759#comment-16756759 ] Jim Apple commented on THRIFT-4138: --- What is the type of {{t}} in that gdb snippet? I

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756749#comment-16756749 ] James E. King III commented on THRIFT-4138: --- This broke TJSONProtocol's abilit

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955643#comment-15955643 ] James E. King, III commented on THRIFT-4138: This broke Visual Studio 2010 an

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952257#comment-15952257 ] ASF GitHub Bot commented on THRIFT-4138: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952243#comment-15952243 ] ASF GitHub Bot commented on THRIFT-4138: Github user jbapple-cloudera commented o

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952236#comment-15952236 ] ASF GitHub Bot commented on THRIFT-4138: Github user jeking3 commented on the iss

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952207#comment-15952207 ] ASF GitHub Bot commented on THRIFT-4138: GitHub user jbapple-cloudera opened a pu