[jira] [Commented] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2021-10-28 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17435559#comment-17435559 ] Eric Bléher commented on THRIFT-5173: - 15 months later, I see this is still open. I could be however

[jira] [Commented] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2020-04-15 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083983#comment-17083983 ] Jens Geyer commented on THRIFT-5173: I think that would be overkill. > Thrift C# (netstd) code

[jira] [Commented] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2020-04-14 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083531#comment-17083531 ] Eric Bléher commented on THRIFT-5173: - It is a bit difficult to test the performance difference in

[jira] [Commented] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079981#comment-17079981 ] Jens Geyer commented on THRIFT-5173: When you ask "why" then that is the exact reason I want you to

[jira] [Commented] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2020-04-09 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079105#comment-17079105 ] Eric Bléher commented on THRIFT-5173: - why having a method virtual would impact performance? >

[jira] [Commented] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking

2020-04-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079007#comment-17079007 ] Jens Geyer commented on THRIFT-5173: Make sure you check the impact on performance when implemening