Re: Thrift compiler "plug-in" mode

2019-01-02 Thread Jens Geyer
e.org Subject: Re: Thrift compiler "plug-in" mode Ditto, simple is faster, more reliable, more maintainable, more ... Let's remove the plugin feature. I would put rewriting the compiler very low on the priority list. Maybe incrementally updating the existing compiler code to C++11/17

Re: Thrift compiler "plug-in" mode

2019-01-02 Thread Randy Abernethy
Ditto, simple is faster, more reliable, more maintainable, more ... Let's remove the plugin feature. I would put rewriting the compiler very low on the priority list. Maybe incrementally updating the existing compiler code to C++11/17 as we go makes sense but I don't see rewriting it as a good use

Re: Thrift compiler "plug-in" mode

2019-01-02 Thread Allen George
The company I work at uses Thrift (as well as scrooge), and we don’t use the plug ins. That said, the previous company I worked at used plugins for the _protobuf_ compiler, but that’s a completely different model, and the use of plugins there is the norm IIRC. I’d vote for simplifying the code ba

Thrift compiler "plug-in" mode

2019-01-02 Thread James E. King III
The addition of a "plug-in" compiler mode has made the build of the compiler fairly complex. There are now two kinds of compilers - one with all the code generators statically linked, and one where all the code generators are dynamically linked. I believe the original goal was to allow third part