[jira] [Commented] (THRIFT-3799) Make constants to use iota

2017-04-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953732#comment-15953732 ] ASF GitHub Bot commented on THRIFT-3799: Github user astromahi closed the pull request at:

[jira] [Commented] (THRIFT-3799) Make constants to use iota

2017-04-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952506#comment-15952506 ] ASF GitHub Bot commented on THRIFT-3799: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-3799) Make constants to use iota

2016-06-22 Thread Chris Bannister (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344427#comment-15344427 ] Chris Bannister commented on THRIFT-3799: - I would say this is not a good idea, and is not

[jira] [Commented] (THRIFT-3799) Make constants to use iota

2016-04-29 Thread Mahendran Kathirvel (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264073#comment-15264073 ] Mahendran Kathirvel commented on THRIFT-3799: - Alright, thanks Jens for your time, Yes, I

[jira] [Commented] (THRIFT-3799) Make constants to use iota

2016-04-29 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15264023#comment-15264023 ] Jens Geyer commented on THRIFT-3799: > understand what you mean but I don't see any risk in here. I

[jira] [Commented] (THRIFT-3799) Make constants to use iota

2016-04-29 Thread Mahendran Kathirvel (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263853#comment-15263853 ] Mahendran Kathirvel commented on THRIFT-3799: - Thanks Jens, I understand what you mean but I

[jira] [Commented] (THRIFT-3799) Make constants to use iota

2016-04-28 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263248#comment-15263248 ] Jens Geyer commented on THRIFT-3799: Sorry, but I'm against this patch. While it clearly does make

[jira] [Commented] (THRIFT-3799) Make constants to use iota

2016-04-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15260015#comment-15260015 ] ASF GitHub Bot commented on THRIFT-3799: GitHub user astromahi opened a pull request: