Re: path query optimization

2016-08-07 Thread Pieter Martin
Here is what I have come up with so far. The idea is that `Traverser.split(r, step)` already copies the labels to the traverser so there is no need to call `Traverser.addLabels(labels)` again. I removed the `Traverser.addLabels(labels)` call from `AbstractStep`. For the traversers that do not ca

Re: path query optimization

2016-08-07 Thread Marko Rodriguez
Why not just check to see if the labels to be added already exist, if they do, don’t addLabels() and thus, don’t create a new collection. Marko. http://markorodriguez.com > On Aug 7, 2016, at 6:07 AM, Pieter Martin wrote: > > Here is what I have come up with so far. > > The idea is that `T

Re: path query optimization

2016-08-07 Thread Pieter Martin
To avoid the collection logic alltogether. For most steps there is no need to check the labels as it is known that they are added, immutable and correct. Also with the current strategy the `ImmutablePath.currentLabels` is exactly the same collection as that of the step. It is not a copy. `Traver

[GitHub] tinkerpop issue #374: TINKERPOP-1400: SubgraphStrategy introduces infinite r...

2016-08-07 Thread twilmes
Github user twilmes commented on the issue: https://github.com/apache/tinkerpop/pull/374 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (TINKERPOP-1400) SubgraphStrategy introduces infinite recursion if filter has Vertex/Edge steps.

2016-08-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411035#comment-15411035 ] ASF GitHub Bot commented on TINKERPOP-1400: --- Github user twilmes commented o