[GitHub] tinkerpop pull request #412: TINKERPOP-1442 Improved session cleanup on clie...

2016-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/412 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] tinkerpop pull request #413: TINKERPOP-1442 Improved session cleanup on clie...

2016-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/413 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Commented] (TINKERPOP-1442) Killing session should make better attempt to cleanup

2016-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496120#comment-15496120 ] ASF GitHub Bot commented on TINKERPOP-1442: --- Github user asfgit closed the p

[jira] [Commented] (TINKERPOP-1442) Killing session should make better attempt to cleanup

2016-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15496118#comment-15496118 ] ASF GitHub Bot commented on TINKERPOP-1442: --- Github user asfgit closed the p

Re: [DISCUSS] 3.3.0 Branching strategy

2016-09-16 Thread Stephen Mallette
Going back to the dual PRs i referenced: https://github.com/apache/tinkerpop/pull/412 https://github.com/apache/tinkerpop/pull/413 After a few days of review, I noticed this morning that now that they were ready for merge, they were conflicted. That means some extra steps because if I had: git c

[jira] [Closed] (TINKERPOP-1442) Killing session should make better attempt to cleanup

2016-09-16 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1442. --- Resolution: Fixed Fix Version/s: 3.2.3 > Killing session should make better

Re: tinkerpop git commit: Added documentation for the traversal representations of general steps (map, flatMap, filter, sideEffect, branch).

2016-09-16 Thread Marko Rodriguez
Hey Kuppitz, Thank you for this. These are very nice additions. In general people, one of the best things you can do to help is add little snippet PRs to our docs. “This example doesn’t show the full power of this step, I’ll add another example.” “I think there should be more v

[GitHub] tinkerpop pull request #418: Fixed issue in NumberSerializer that could caus...

2016-09-16 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/418#discussion_r79189025 --- Diff: gremlin-python/src/main/jython/gremlin_python/structure/io/graphson.py --- @@ -181,7 +181,7 @@ class NumberSerializer(GraphSONSerializer):

[jira] [Closed] (TINKERPOP-1330) by()-modulation for where()

2016-09-16 Thread Marko A. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marko A. Rodriguez closed TINKERPOP-1330. - > by()-modulation for where() > --- > > Ke

[GitHub] tinkerpop pull request #418: Fixed issue in NumberSerializer that could caus...

2016-09-16 Thread leifurhauks
Github user leifurhauks commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/418#discussion_r79199796 --- Diff: gremlin-python/src/main/jython/gremlin_python/structure/io/graphson.py --- @@ -181,7 +181,7 @@ class NumberSerializer(GraphSONSerializer):

[DISCUSS] running single tests

2016-09-16 Thread Stephen Mallette
This issue was created a while back: https://issues.apache.org/jira/browse/TINKERPOP-1076 It presents an option to allow running of a single test in the structure/process test suite. The solution is beyond anything anyone will ever do in TinkerPop 3.x (a massive body of work) as it means restruct

[GitHub] tinkerpop pull request #425: Fixed behavior of has() methods

2016-09-16 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/425 Fixed behavior of has() methods Made `has[Id|Label|Key|Value]` compatible with the old varargs method signature and added tests to ensure the compatibility. VOTE: +1 You can merge this

[INFO] Recent changes in has() method signatures

2016-09-16 Thread Daniel Kuppitz
Hello, I've recently changes the signatures of our has() methods. Unfortunately I didn't realize that this change was breaking for some users (those who arrays as arguments). The old method signatures were all vararg-based: - hasId(Object... ids) - hasLabel(Object... labels) - etc. ...a

[GitHub] tinkerpop issue #425: Fixed behavior of has() methods

2016-09-16 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/425 Please adapt your "INFO" email to dev into the Upgrade Docs. I think it's important to explain the history of what happened here for 3.2.3 as we missed the change for the Upgrade Docs in 3.2.2.

[DISCUSS] JIRA cleanup

2016-09-16 Thread Stephen Mallette
We're hanging around 250 open issues at the moment in JIRA. 28 of those are "deprecation" issues, so roughly 220 to pay attention to. It's been a while since we've done any global grooming of the list and I think that as we are on the way to 3.3.0, it would be good to do a little bit of that. In t

[GitHub] tinkerpop pull request #426: TINKERPOP-1437 Added tests for dedup(Scope,Stri...

2016-09-16 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/426 TINKERPOP-1437 Added tests for dedup(Scope,String...) overload in DedupTest https://issues.apache.org/jira/browse/TINKERPOP-1437 Pretty simple - just added a couple of tests - but didn

[jira] [Commented] (TINKERPOP-1437) Add tests for dedup(Scope) in DedupTest

2016-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497263#comment-15497263 ] ASF GitHub Bot commented on TINKERPOP-1437: --- GitHub user spmallette opened a

[jira] [Updated] (TINKERPOP-1095) Create a custom ScriptContext

2016-09-16 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1095: Summary: Create a custom ScriptContext (was: Determine if a custom ScriptContex

[jira] [Closed] (TINKERPOP-1031) Map URL routes to static method execution in REST API

2016-09-16 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1031. --- Resolution: Won't Fix I don't think this is a good idea anymore. We don't really h

[jira] [Commented] (TINKERPOP-932) Add ability to cancel script execution associated with a Gremlin Server Session

2016-09-16 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497302#comment-15497302 ] stephen mallette commented on TINKERPOP-932: I sense that barring some obsc

[GitHub] tinkerpop pull request #426: TINKERPOP-1437 Added tests for dedup(Scope,Stri...

2016-09-16 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/426#discussion_r79258319 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupTest.java --- @@ -73,6 +77,40 @@ public

[GitHub] tinkerpop pull request #426: TINKERPOP-1437 Added tests for dedup(Scope,Stri...

2016-09-16 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/426#discussion_r79258254 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupTest.java --- @@ -73,6 +77,40 @@ public

[GitHub] tinkerpop pull request #426: TINKERPOP-1437 Added tests for dedup(Scope,Stri...

2016-09-16 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/426#discussion_r79258124 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupTest.java --- @@ -241,6 +279,16 @@ public void g_V_both

[GitHub] tinkerpop pull request #426: TINKERPOP-1437 Added tests for dedup(Scope,Stri...

2016-09-16 Thread okram
Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/426#discussion_r79258468 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/filter/DedupTest.java --- @@ -73,6 +77,40 @@ public

[jira] [Commented] (TINKERPOP-1437) Add tests for dedup(Scope) in DedupTest

2016-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497514#comment-15497514 ] ASF GitHub Bot commented on TINKERPOP-1437: --- Github user okram commented on

[jira] [Commented] (TINKERPOP-1437) Add tests for dedup(Scope) in DedupTest

2016-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497516#comment-15497516 ] ASF GitHub Bot commented on TINKERPOP-1437: --- Github user okram commented on

[GitHub] tinkerpop issue #426: TINKERPOP-1437 Added tests for dedup(Scope,String...) ...

2016-09-16 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/426 Made a few comments to ensure your test code is consistent with the others. Besides minor cosmetics -- VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (TINKERPOP-1437) Add tests for dedup(Scope) in DedupTest

2016-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497517#comment-15497517 ] ASF GitHub Bot commented on TINKERPOP-1437: --- Github user okram commented on

[jira] [Commented] (TINKERPOP-1437) Add tests for dedup(Scope) in DedupTest

2016-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497515#comment-15497515 ] ASF GitHub Bot commented on TINKERPOP-1437: --- Github user okram commented on

[jira] [Commented] (TINKERPOP-1437) Add tests for dedup(Scope) in DedupTest

2016-09-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15497523#comment-15497523 ] ASF GitHub Bot commented on TINKERPOP-1437: --- Github user okram commented on