[jira] [Commented] (TINKERPOP-1589) Re-Introduce CloseableIterator

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839015#comment-15839015 ] ASF GitHub Bot commented on TINKERPOP-1589: --- GitHub user pauljackson opened

[GitHub] tinkerpop pull request #547: TINKERPOP-1589 Re-introduced CloseableIterator

2017-01-25 Thread pauljackson
GitHub user pauljackson opened a pull request: https://github.com/apache/tinkerpop/pull/547 TINKERPOP-1589 Re-introduced CloseableIterator https://issues.apache.org/jira/browse/TINKERPOP-1589 Add support for the closing of `Iterators` returned from `Vertex.vertices()` and `Ve

Re: [DISCUSS] Release 3.2.4 and 3.1.6

2017-01-25 Thread Stephen Mallette
sure - please put that in the prefix of the PR title so it links back to that original jira ticket On Wed, Jan 25, 2017 at 5:17 PM, Paul A. Jackson wrote: > OK, low-risk PR coming for OLTP part. Should I reuse TINKERPOP-1589? > > Thanks, > -Paul > > -Original Message- > From: Stephen Mal

RE: [DISCUSS] Release 3.2.4 and 3.1.6

2017-01-25 Thread Paul A. Jackson
OK, low-risk PR coming for OLTP part. Should I reuse TINKERPOP-1589? Thanks, -Paul -Original Message- From: Stephen Mallette [mailto:spmalle...@gmail.com] Sent: Wednesday, January 25, 2017 5:07 PM To: dev@tinkerpop.apache.org Subject: Re: [DISCUSS] Release 3.2.4 and 3.1.6 Being as close

Re: [DISCUSS] Release 3.2.4 and 3.1.6

2017-01-25 Thread Stephen Mallette
Being as close as we are to our code freeze/test week, I'd say that big, complex or otherwise risky changes probably won't collect too many +1 reviews at this point. If the OLTP improvement is small/concise (low risk), it could be considered for inclusion in 3.2.4. On Wed, Jan 25, 2017 at 5:00 PM,

RE: [DISCUSS] Release 3.2.4 and 3.1.6

2017-01-25 Thread Paul A. Jackson
I have something that fixes OLTP. I haven't worked with OLAP and it looks like the changes for this will be extensive, touching IteratorUtils and so on. Would you be interested in a PR for just the OLTP part? -Original Message- From: Stephen Mallette [mailto:spmalle...@gmail.com] Sent:

[jira] [Created] (TINKERPOP-1615) Doing a step many times can lead to unforeseen problems with the RepeatUnrollStrategy

2017-01-25 Thread Jeremy Hanna (JIRA)
Jeremy Hanna created TINKERPOP-1615: --- Summary: Doing a step many times can lead to unforeseen problems with the RepeatUnrollStrategy Key: TINKERPOP-1615 URL: https://issues.apache.org/jira/browse/TINKERPOP-1615

Re: [DISCUSS] Release 3.2.4 and 3.1.6

2017-01-25 Thread Stephen Mallette
in his case, it should go to tp32. On Wed, Jan 25, 2017 at 3:56 PM, Paul A. Jackson wrote: > For what branch should a pull request be submitted? > > > -Original Message- > From: Stephen Mallette [mailto:spmalle...@gmail.com] > Sent: Wednesday, January 25, 2017 3:41 PM > To: dev@tinkerpop

RE: [DISCUSS] Release 3.2.4 and 3.1.6

2017-01-25 Thread Paul A. Jackson
For what branch should a pull request be submitted? -Original Message- From: Stephen Mallette [mailto:spmalle...@gmail.com] Sent: Wednesday, January 25, 2017 3:41 PM To: dev@tinkerpop.apache.org Subject: Re: [DISCUSS] Release 3.2.4 and 3.1.6 I went with the most obvious implementation pl

Re: [DISCUSS] Release 3.2.4 and 3.1.6

2017-01-25 Thread Stephen Mallette
I went with the most obvious implementation place for CloseableIterator. If you see other spots where you could make an argument that it would make sense to add it then feel free to offer a pull request and we can get it reviewed. I didn't look into your VertexStep suggestion too deeply, but a quic

RE: [DISCUSS] Release 3.2.4 and 3.1.6

2017-01-25 Thread Paul A. Jackson
So, I modified my code to work with CloseableIterator. I was hoping this would be honored in more places than it is. Where it does work is if the user of a traversal calls traversal.close() all the steps will get closed, including the typically first GraphStep. GraphStep in turn checks whether

[GitHub] tinkerpop issue #546: TINKERPOP-1583: PathRetractionStrategy retracts keys t...

2017-01-25 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/546 So the problem I was having was related to the interplay between `PathRetractionStrategy` and `MatchPredicateStrategy`. You can't have `PathRetractionStrategy` without `MatchPredicateStrategy`.

[jira] [Commented] (TINKERPOP-1583) PathRetractionStrategy retracts keys that are actually needed

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15838174#comment-15838174 ] ASF GitHub Bot commented on TINKERPOP-1583: --- Github user okram commented on

[jira] [Created] (TINKERPOP-1614) Improve documentation for Graph.V() and Graph.E() on main docs page

2017-01-25 Thread Bob Briody (JIRA)
Bob Briody created TINKERPOP-1614: - Summary: Improve documentation for Graph.V() and Graph.E() on main docs page Key: TINKERPOP-1614 URL: https://issues.apache.org/jira/browse/TINKERPOP-1614 Project:

[jira] [Commented] (TINKERPOP-1583) PathRetractionStrategy retracts keys that are actually needed

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837838#comment-15837838 ] ASF GitHub Bot commented on TINKERPOP-1583: --- GitHub user twilmes opened a pu

[GitHub] tinkerpop pull request #546: TINKERPOP-1583: PathRetractionStrategy retracts...

2017-01-25 Thread twilmes
GitHub user twilmes opened a pull request: https://github.com/apache/tinkerpop/pull/546 TINKERPOP-1583: PathRetractionStrategy retracts keys that are actually needed `PathRetractionStrategy` was not pushing `keepLabels` down into sibling traversals of children with label requiremen

[jira] [Commented] (TINKERPOP-1271) SparkContext should be restarted if Killed and using Persistent Context

2017-01-25 Thread Artem Aliev (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837700#comment-15837700 ] Artem Aliev commented on TINKERPOP-1271: I have filed a spark bug for it SPARK

[jira] [Created] (TINKERPOP-1613) Create distributed side-effects/reducers

2017-01-25 Thread Marko A. Rodriguez (JIRA)
Marko A. Rodriguez created TINKERPOP-1613: - Summary: Create distributed side-effects/reducers Key: TINKERPOP-1613 URL: https://issues.apache.org/jira/browse/TINKERPOP-1613 Project: TinkerPop