[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

2017-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103413#comment-16103413 ] ASF GitHub Bot commented on TINKERPOP-1736: --- GitHub user dkuppitz opened a p

[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

2017-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103414#comment-16103414 ] ASF GitHub Bot commented on TINKERPOP-1736: --- GitHub user dkuppitz opened a p

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/682 I created 2 new PR's, one for `tp31/`, the other for `master/`. `tp31`: #683 `master`: #684 --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

2017-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103417#comment-16103417 ] ASF GitHub Bot commented on TINKERPOP-1736: --- Github user dkuppitz commented

[GitHub] tinkerpop pull request #683: TINKERPOP-1736 Sack step evaluated by groovy in...

2017-07-27 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/683 TINKERPOP-1736 Sack step evaluated by groovy interprets numbers in an unexpected way Follow-up on #682. This PR fixes the test case that failed in `master/`. You can merge this pull request int

[GitHub] tinkerpop pull request #684: TINKERPOP-1736 Sack step evaluated by groovy in...

2017-07-27 Thread dkuppitz
GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/684 TINKERPOP-1736 Sack step evaluated by groovy interprets numbers in an unexpected way Follow-up on #682. This PR fixes the test case that failed in `master/`. You can merge this pull request int

[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

2017-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103263#comment-16103263 ] ASF GitHub Bot commented on TINKERPOP-1736: --- Github user spmallette commente

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/682 I've dug into supporting `BigDecimal` directly and it's turning into a mess a bit. Python does have `Decimal` class which is like `BigDecimal` but it doesn't serialize through the standard JSON

[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

2017-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103246#comment-16103246 ] ASF GitHub Bot commented on TINKERPOP-1736: --- Github user okram commented on

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/682 This all goes back to typing numbers based on storage size is dumb. Most modern, high-level languages have arbitrary precision on integer and decimal values. Languages that have strongly typed

[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

2017-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103247#comment-16103247 ] ASF GitHub Bot commented on TINKERPOP-1736: --- Github user robertdale commente

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread okram
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/682 Ah. I didn't realize that either. BigDecimal is not something we want to support. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

2017-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103189#comment-16103189 ] ASF GitHub Bot commented on TINKERPOP-1736: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/682 IMO it makes sense to support `BigDecimal`. If not for big numbers, then at least for the better precision. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (TINKERPOP-1736) Sack step evaluated by groovy interprets numbers in an unexpected way

2017-07-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16103070#comment-16103070 ] ASF GitHub Bot commented on TINKERPOP-1736: --- Github user spmallette commente

[GitHub] tinkerpop issue #682: TINKERPOP-1736 Sack step evaluated by groovy interpret...

2017-07-27 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/682 I didn't get a chance to review/vote on this before it was merged, but I dont' think this is what I expected to happen when I wrote the JIRA. I didn't think we would produce direct support for