[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication

2018-07-12 Thread mattallenuk
Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/889 Still having issues with Maven build but think I'm getting closer to making it work. Once working I'll get the integration tests working. Also going to look at option B on the Sasl class. --

Re: [DISCUSS] Review Process

2018-07-12 Thread Stephen Mallette
I'm going to quickly summarize this thread so that hopefully by Monday we have a plan to follow. We seem to agree that in the future we will go with the following review -the-commit (RTC) process: 1. Each change to TinkerPop release branches requires 3 +1s from committers and no -1s OR 2. A singl

[jira] [Commented] (TINKERPOP-1999) [Java][gremlin-driver] Query to a remote server via the websocket client hangs indefinitely if the server becomes unavailable

2018-07-12 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542140#comment-16542140 ] stephen mallette commented on TINKERPOP-1999: - We don't have an official

[jira] [Commented] (TINKERPOP-1999) [Java][gremlin-driver] Query to a remote server via the websocket client hangs indefinitely if the server becomes unavailable

2018-07-12 Thread Ankesh Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542114#comment-16542114 ] Ankesh Khandelwal commented on TINKERPOP-1999: -- Thanks a lot for this fi

[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542064#comment-16542064 ] ASF GitHub Bot commented on TINKERPOP-967: -- Github user spmallette commented

[GitHub] tinkerpop issue #876: TINKERPOP-967 Support nested-repeat() structures

2018-07-12 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/876 nice catch @dkuppitz - `hashCode()` == crucial ---

[jira] [Commented] (TINKERPOP-1987) Bump to Netty 4.1.x

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542059#comment-16542059 ] ASF GitHub Bot commented on TINKERPOP-1987: --- Github user spmallette comment

[GitHub] tinkerpop issue #886: TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4.1.25.Fi...

2018-07-12 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/886 not sure. I saw that and ran the build again locally the other day and had no trouble ---

[jira] [Commented] (TINKERPOP-1987) Bump to Netty 4.1.x

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542037#comment-16542037 ] ASF GitHub Bot commented on TINKERPOP-1987: --- Github user robertdale comment

[GitHub] tinkerpop issue #886: TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4.1.25.Fi...

2018-07-12 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/886 @spmallette any idea why the spark test is hanging in travis? ---

[jira] [Commented] (TINKERPOP-1987) Bump to Netty 4.1.x

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542027#comment-16542027 ] ASF GitHub Bot commented on TINKERPOP-1987: --- Github user dkuppitz commented

[GitHub] tinkerpop issue #886: TINKERPOP-1987 Bump to Spark 2.3.1 and Netty 4.1.25.Fi...

2018-07-12 Thread dkuppitz
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/886 VOTE: +1 ---

[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541986#comment-16541986 ] ASF GitHub Bot commented on TINKERPOP-967: -- Github user dkuppitz commented on

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

2018-07-12 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202104064 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java --- @@ -2289,6 +2302,21 @@ else if (va

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

2018-07-12 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202104896 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java --- @@ -43,6 +43,7 @@ private T

[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541983#comment-16541983 ] ASF GitHub Bot commented on TINKERPOP-967: -- Github user dkuppitz commented on

[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541984#comment-16541984 ] ASF GitHub Bot commented on TINKERPOP-967: -- Github user dkuppitz commented on

[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541988#comment-16541988 ] ASF GitHub Bot commented on TINKERPOP-967: -- Github user dkuppitz commented on

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

2018-07-12 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202114064 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_LP_NL_O_P_S_SE_SL_Traverser.java --- @@ -0,0 +1,156 @@

[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541985#comment-16541985 ] ASF GitHub Bot commented on TINKERPOP-967: -- Github user dkuppitz commented on

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

2018-07-12 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202105366 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/LoopsStep.java --- @@ -26,12 +26,15 @@ */ public

[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541982#comment-16541982 ] ASF GitHub Bot commented on TINKERPOP-967: -- Github user dkuppitz commented on

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

2018-07-12 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202110691 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_O_S_SE_SL_Traverser.java --- @@ -32,6 +32,7 @@

[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541981#comment-16541981 ] ASF GitHub Bot commented on TINKERPOP-967: -- Github user dkuppitz commented on

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

2018-07-12 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202114725 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatTest.java --- @@ -386,5 +531,51 @@ public void g_

[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541987#comment-16541987 ] ASF GitHub Bot commented on TINKERPOP-967: -- Github user dkuppitz commented on

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

2018-07-12 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202111311 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/O_OB_S_SE_SL_Traverser.java --- @@ -30,6 +30,7 @@

[jira] [Commented] (TINKERPOP-967) Support nested-repeat() structures

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541989#comment-16541989 ] ASF GitHub Bot commented on TINKERPOP-967: -- Github user dkuppitz commented on

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

2018-07-12 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202113071 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/util/LabelledCounter.java --- @@ -0,0 +1,85 @@ +/*

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

2018-07-12 Thread dkuppitz
Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202102880 --- Diff: docs/src/reference/the-traversal.asciidoc --- @@ -2125,6 +2125,17 @@ traverser repeats. However, because the emit-predicate is declared true, t

windows test

2018-07-12 Thread Stephen Mallette
I came across this issue today - i dimly recall it when it first came through - and noticed that it fell by the wayside. Seems like the problem comes with a solution: https://issues.apache.org/jira/browse/TINKERPOP-1951 but it requires a windows system to testany takers?

Re: Executing GraphTraversal on Provider (via Java)

2018-07-12 Thread Stephen Mallette
Glad to hear things are moving along. Also good to see that there's an ArangoDB option for Gremlin coming along - is that something that will be open source and generally available for use? Also, if you don't mind my asking, will this implementation be officially maintained by ArangoDB or is it som

Executing GraphTraversal on Provider (via Java)

2018-07-12 Thread Horacio Hoyos Rodriguez
Hi, I am implementing a Provider for ArangoDB. I have implemented the structure package interfaces and after running most of the TestSuite Iam happy with the result. Now, if I want an ArangoDBGraph to be modified/queried via the GraphTraversal API, e.g. g.addVertex(... do I also have to imp

[jira] [Commented] (TINKERPOP-1986) Remove deprecation from PartitionStrategy, SubgraphStrategy and GremlinScriptEngine

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541771#comment-16541771 ] ASF GitHub Bot commented on TINKERPOP-1986: --- Github user asfgit closed the

[jira] [Closed] (TINKERPOP-1986) Remove deprecation from PartitionStrategy, SubgraphStrategy and GremlinScriptEngine

2018-07-12 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1986. --- Resolution: Done > Remove deprecation from PartitionStrategy, SubgraphStrategy an

[GitHub] tinkerpop pull request #879: TINKERPOP-1986 Removed deprecated methods

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/879 ---

[jira] [Updated] (TINKERPOP-2001) JavaScript GLV: Support Groovy and Python lambdas

2018-07-12 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-2001: Affects Version/s: 3.3.3 > JavaScript GLV: Support Groovy and Python lambdas >

[jira] [Closed] (TINKERPOP-1999) [Java][gremlin-driver] Query to a remote server via the websocket client hangs indefinitely if the server becomes unavailable

2018-07-12 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1999. --- Resolution: Fixed Assignee: stephen mallette Fix Version/s: 3.2.10

[jira] [Commented] (TINKERPOP-1995) DriverRemoteConnection close() method returns undefined

2018-07-12 Thread Jorge Bay (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541644#comment-16541644 ] Jorge Bay commented on TINKERPOP-1995: -- Thanks for closing it [~spmallette]! >

[jira] [Closed] (TINKERPOP-1995) DriverRemoteConnection close() method returns undefined

2018-07-12 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-1995. --- Resolution: Done Assignee: Jorge Bay > DriverRemoteConnection close() metho

[jira] [Created] (TINKERPOP-2005) Intermittent NullPointerException in response handling

2018-07-12 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-2005: --- Summary: Intermittent NullPointerException in response handling Key: TINKERPOP-2005 URL: https://issues.apache.org/jira/browse/TINKERPOP-2005 Project: Ti

[jira] [Commented] (TINKERPOP-1822) Repeat should depth first search

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541408#comment-16541408 ] ASF GitHub Bot commented on TINKERPOP-1822: --- Github user spmallette comment

[GitHub] tinkerpop pull request #838: TINKERPOP-1822: Change default RepeatStep to DF...

2018-07-12 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/838#discussion_r201976894 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java --- @@ -273,11 +300,40 @@ public Repea

[jira] [Commented] (TINKERPOP-1995) DriverRemoteConnection close() method returns undefined

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541406#comment-16541406 ] ASF GitHub Bot commented on TINKERPOP-1995: --- Github user asfgit closed the

[GitHub] tinkerpop pull request #888: TINKERPOP-1995 Return the Promise on Close

2018-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/888 ---

[jira] [Created] (TINKERPOP-2004) LazyBarrierStrategy should be the only strategy that adds barriers

2018-07-12 Thread stephen mallette (JIRA)
stephen mallette created TINKERPOP-2004: --- Summary: LazyBarrierStrategy should be the only strategy that adds barriers Key: TINKERPOP-2004 URL: https://issues.apache.org/jira/browse/TINKERPOP-2004

[jira] [Updated] (TINKERPOP-1999) [Java][gremlin-driver] Query to a remote server via the websocket client hangs indefinitely if the server becomes unavailable

2018-07-12 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-1999: Fix Version/s: (was: 3.3.3) (was: 3.3.2) > [Java][gr

[jira] [Commented] (TINKERPOP-1995) DriverRemoteConnection close() method returns undefined

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541386#comment-16541386 ] ASF GitHub Bot commented on TINKERPOP-1995: --- Github user spmallette comment

[GitHub] tinkerpop issue #888: TINKERPOP-1995 Return the Promise on Close

2018-07-12 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/888 Sure - looks that way to me. Please add a changelog entry when you merge. ---

[jira] [Commented] (TINKERPOP-1995) DriverRemoteConnection close() method returns undefined

2018-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541278#comment-16541278 ] ASF GitHub Bot commented on TINKERPOP-1995: --- Github user jorgebay commented

[GitHub] tinkerpop issue #888: TINKERPOP-1995 Return the Promise on Close

2018-07-12 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/888 As this is a straightforward bug fix, I think its ok to do a CTR and avoid waiting for an additional review/vote. ---

[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication

2018-07-12 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/889 `submit()` accepting `requestId` looks good! About running the test locally, you should try (on root tinkerpop directory): - `mvn clean install -DskipTests` (run this once to generate