[
https://issues.apache.org/jira/browse/TINKERPOP-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582964#comment-16582964
]
ASF GitHub Bot commented on TINKERPOP-1913:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/TINKERPOP-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-2024.
---
Resolution: Done
Fix Version/s: 3.2.10
3.3.4
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
oh right - i forgot @ashwinisingh01 - i'll take care of it
---
[
https://issues.apache.org/jira/browse/TINKERPOP-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582961#comment-16582961
]
ASF GitHub Bot commented on TINKERPOP-2024:
---
Github user asfgit closed the pull request at:
Github user ashwinisingh01 commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@spmallette , Since I lost the access to the original account ashwini-ms. I
do not have permission to close the PR #868 . Does admin of this repo have
permissions?
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/911
---
[
https://issues.apache.org/jira/browse/TINKERPOP-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582951#comment-16582951
]
ASF GitHub Bot commented on TINKERPOP-2024:
---
Github user dkuppitz commented on the issue:
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/911
VOTE +1
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@redoz A GLV is a Gremlin Language Variant (Gremlin.NET is an example of
one):
http://tinkerpop.apache.org/docs/current/tutorials/gremlin-language-variants/
A GLV is just a
Github user redoz commented on the issue:
https://github.com/apache/tinkerpop/pull/915
Yeah I was referring to the .Net client, I've already patched a local copy
and the change was minimal, but i didn't write any tests so that would add to
the effort of course. But if @ashwinisingh01
[
https://issues.apache.org/jira/browse/TINKERPOP-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-1342.
---
Resolution: Done
Fix Version/s: 3.4.0
> Allow setting
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/910
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582830#comment-16582830
]
ASF GitHub Bot commented on TINKERPOP-1342:
---
Github user asfgit closed the pull request at:
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
thanks for the clarification @Blackbaud-IanThomas - well, that much is
present for Java. again, i agree that we should look to get that added for .NET
as well (and other GLVs).
---
Github user Blackbaud-IanThomas commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@spmallette I believe what @redoz is talking about is adding
`ResponseStatus.Attributes` to the `ResponseException.` See below code and
screenshot of a response from CosmosDB.
If
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
sorry for the extra message here, but @ashwinisingh01 do you mind closing
the #868 PR - we don't need that anymore right?
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@ashwinisingh01 strange that you have so many conflicts on classes that you
didn't touch. it looks like your PR is a little messed up because it contains
my commits in addition to yours.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/915
@redoz if you're referring to the java `ResponseException` then that's done
now from the client perspective (though as I think about it, we could use more
tests in that regard, but i'll leave
[
https://issues.apache.org/jira/browse/TINKERPOP-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582716#comment-16582716
]
ASF GitHub Bot commented on TINKERPOP-1913:
---
Github user spmallette commented on a diff in
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r210646017
--- Diff:
gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs ---
@@ -51,7 +52,18 @@ public async Task
Github user papa-pep commented on the issue:
https://github.com/apache/tinkerpop/pull/915
Having the attribute information in the exception would be helpful for my
team as well.
---
Github user Blackbaud-IanThomas commented on the issue:
https://github.com/apache/tinkerpop/pull/915
My teamâs primary use case is having this information on the exception so
we can respond to request rate limitations in Cosmos. I would really hope that
is in scope.
---
Github user redoz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r210521813
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/IResultSet.cs ---
@@ -0,0 +1,43 @@
+#region License
+/*
+ * Licensed to the Apache Software
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/915#discussion_r210506485
--- Diff: gremlin-dotnet/src/Gremlin.Net/Driver/IResultSet.cs ---
@@ -0,0 +1,43 @@
+#region License
+/*
+ * Licensed to the Apache Software
24 matches
Mail list logo
