Github user mattallenuk commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/922#discussion_r213212310
--- Diff:
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/remote-connection.js
---
@@ -66,7 +67,27 @@ class RemoteStrategy exten
[
https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594660#comment-16594660
]
ASF GitHub Bot commented on TINKERPOP-1959:
---
Github user mattallenuk commen
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/922
Excellent - thanks for doing this. @jorgebay is the better person to handle
this review in full, but I'd like to offer a few points:
> Is it safe to assume that a returned value not con
[
https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16594831#comment-16594831
]
ASF GitHub Bot commented on TINKERPOP-1959:
---
Github user spmallette comment
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/905
@svanteschubert i'm just checking in - do you think you will have time to
come back to this pull request to address the comments presented? I'm not
trying to rush you, but if you're really busy
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/907
hi @RainMark do you plan to come back to address the comments here?
---
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213361478
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed that
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213364785
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed th
Github user svanteschubert commented on the issue:
https://github.com/apache/tinkerpop/pull/905
I am indeed a little under pressure, currently on a business trip to
Warschau. I might be able to spend time end of next week. But would appreciate
it, if you could take over.. Simply bad t
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213372950
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed that
[
https://issues.apache.org/jira/browse/TINKERPOP-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Gallardo updated TINKERPOP-2028:
--
Summary: AbstractGraphSONMessageSerializerV2d0 should register
GremlinServerModule
[
https://issues.apache.org/jira/browse/TINKERPOP-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Gallardo updated TINKERPOP-2028:
--
Summary: AbstractGraphSONMessageSerializerV2d0 should register
GremlinServerModule
[
https://issues.apache.org/jira/browse/TINKERPOP-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595213#comment-16595213
]
stephen mallette commented on TINKERPOP-2028:
-
yes - i think that makes s
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/922
@spmallette thanks for the feedback. I'll wait on further input from
@jorgebay and implement it to be more closely aligned with the other GLVs based
on this and further feedback.
---
[
https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595226#comment-16595226
]
ASF GitHub Bot commented on TINKERPOP-1959:
---
Github user mattallenuk commen
[
https://issues.apache.org/jira/browse/TINKERPOP-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595266#comment-16595266
]
Kevin Gallardo commented on TINKERPOP-2028:
---
Re-registering doesn't sound p
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213398454
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed th
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/905
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/905
Ok - I handled the merge and polished up a couple of things. Thanks for
your help on this. Take care!
---
[
https://issues.apache.org/jira/browse/TINKERPOP-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette closed TINKERPOP-2006.
---
Resolution: Fixed
Assignee: stephen mallette
Fix Version/s: 3.4.0
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213426961
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed that
The Project Management Committee (PMC) for Apache TinkerPop has asked Harsh
Thakkar to become a committer and we are pleased to announce his acceptance.
Harsh has been working on sparql-gremlin which compiles SPARQL based
queries into Gremlin traversals thus bridging the gap a bit between RDF and
GitHub user newkek opened a pull request:
https://github.com/apache/tinkerpop/pull/923
TINKERPOP-2028: Register GremlinServerModule to GraphSON message seriâ¦
â¦alizer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/newkek/incub
[
https://issues.apache.org/jira/browse/TINKERPOP-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595505#comment-16595505
]
ASF GitHub Bot commented on TINKERPOP-2028:
---
GitHub user newkek opened a pu
Github user newkek commented on the issue:
https://github.com/apache/tinkerpop/pull/923
Left the current behavior unchanged but deprecated the current method, in
favor of another `GraphSONMessageSerializer` constructor that gives the
opportunity to child classes of `AbstractGraphSON2M
[
https://issues.apache.org/jira/browse/TINKERPOP-2028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595509#comment-16595509
]
ASF GitHub Bot commented on TINKERPOP-2028:
---
Github user newkek commented o
Github user newkek commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/921#discussion_r213448492
--- Diff: docs/src/recipes/cycle-detection.asciidoc ---
@@ -48,6 +48,31 @@ the length of the cycle is known to be three and there
is no need to exceed that
[
https://issues.apache.org/jira/browse/TINKERPOP-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette updated TINKERPOP-2027:
Issue Type: Improvement (was: New Feature)
> Add a Typescript definitions file
28 matches
Mail list logo