[GitHub] tinkerpop issue #915: Tinkerpop 1913-Followup

2018-09-13 Thread redoz
Github user redoz commented on the issue: https://github.com/apache/tinkerpop/pull/915 Not sure why the travis build is failing, it looks java related to me. Any thoughts @spmallette? ---

[DISCUSS] groovy-sql

2018-09-13 Thread Robert Dale
gremlin-driver has a direct dependency on groovy-sql. I removed it in master and all tests pass (docker/build.sh -i -t -n) so there does not appear to be any direct or indirect usage. Why is it there? Looks like it was pulled in because of https://issues.apache.org/jira/browse/TINKERPOP-713 Howev

[GitHub] tinkerpop issue #915: Tinkerpop 1913-Followup

2018-09-13 Thread redoz
Github user redoz commented on the issue: https://github.com/apache/tinkerpop/pull/915 @ashwinisingh01 I was accidentally trying to push it to your original account (@ashwini-ms), I just noticed and fixed it. I've rebased your changes on top of apache/Tinkerpop-1913 and added mine as

[GitHub] tinkerpop issue #915: Tinkerpop 1913-Followup

2018-09-13 Thread ashwinisingh01
Github user ashwinisingh01 commented on the issue: https://github.com/apache/tinkerpop/pull/915 @redoz , I see your push in the PR. I hope you are unblocked to make changes directly to the PR. Let me know if you still need help ---

Re: [DISCUSS] Uniqueness of property ids

2018-09-13 Thread Robert Dale
When you say 'local', do you mean local to VertexProperty IDs only as opposed to 'global' including Vertex IDs and Edge IDs? Robert Dale On Thu, Sep 13, 2018 at 11:29 AM Stephen Mallette wrote: > I probably should have added this yesterday when I replied but +1 to local > uniqueness for vertex

[jira] [Commented] (TINKERPOP-2035) Gremlin-JavaScript: Pass custom headers to the websocket connection

2018-09-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614001#comment-16614001 ] ASF GitHub Bot commented on TINKERPOP-2035: --- Github user deejvince commente

[GitHub] tinkerpop pull request #929: TINKERPOP-2035 Pass custom headers to the webso...

2018-09-13 Thread deejvince
Github user deejvince commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/929#discussion_r217515752 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js --- @@ -49,12 +49,14 @@ class DriverRemoteCo

[jira] [Commented] (TINKERPOP-2035) Gremlin-JavaScript: Pass custom headers to the websocket connection

2018-09-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613972#comment-16613972 ] ASF GitHub Bot commented on TINKERPOP-2035: --- Github user deejvince commente

[GitHub] tinkerpop pull request #929: TINKERPOP-2035 Pass custom headers to the webso...

2018-09-13 Thread deejvince
Github user deejvince commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/929#discussion_r217509807 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js --- @@ -49,12 +49,14 @@ class DriverRemoteCo

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

2018-09-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613942#comment-16613942 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user spmallette comment

[GitHub] tinkerpop pull request #922: TINKERPOP-1959: Gremlin Javascript ability to s...

2018-09-13 Thread spmallette
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/922#discussion_r217501779 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js --- @@ -0,0 +1,93 @@ +/* + * Licensed to the Ap

[jira] [Commented] (TINKERPOP-1959) Provide a way to submit scripts to the server in gremlin-javascript

2018-09-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613934#comment-16613934 ] ASF GitHub Bot commented on TINKERPOP-1959: --- Github user mattallenuk commen

[GitHub] tinkerpop pull request #922: TINKERPOP-1959: Gremlin Javascript ability to s...

2018-09-13 Thread mattallenuk
Github user mattallenuk commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/922#discussion_r217498294 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/translator.js --- @@ -0,0 +1,93 @@ +/* + * Licensed to the A

Re: [DISCUSS] Uniqueness of property ids

2018-09-13 Thread Stephen Mallette
I probably should have added this yesterday when I replied but +1 to local uniqueness for vertex property identifiers. kinda surprised that we didn't have this enforced already in the test suite. On Wed, Sep 12, 2018 at 3:14 PM Stephen Mallette wrote: > that much actually makes sense - the probl

[jira] [Commented] (TINKERPOP-2033) Maintain order of profile() annotations

2018-09-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613651#comment-16613651 ] ASF GitHub Bot commented on TINKERPOP-2033: --- GitHub user spmallette opened

[GitHub] tinkerpop pull request #932: TINKERPOP-2033 Maintain order in profile() anno...

2018-09-13 Thread spmallette
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/932 TINKERPOP-2033 Maintain order in profile() annotations https://issues.apache.org/jira/browse/TINKERPOP-2033 Used a synchronized map around a `LinkedHashMap` rather than `ConcurrentHas

[jira] [Updated] (TINKERPOP-2033) Maintain order of profile() annotations

2018-09-13 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette updated TINKERPOP-2033: Labels: (was: breaking) Description: The {{annotations}} of {{Immuta

[jira] [Commented] (TINKERPOP-2035) Gremlin-JavaScript: Pass custom headers to the websocket connection

2018-09-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613445#comment-16613445 ] ASF GitHub Bot commented on TINKERPOP-2035: --- Github user jorgebay commented

[GitHub] tinkerpop pull request #929: TINKERPOP-2035 Pass custom headers to the webso...

2018-09-13 Thread jorgebay
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/929#discussion_r217371869 --- Diff: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/driver/driver-remote-connection.js --- @@ -49,12 +49,14 @@ class DriverRemoteCon

[jira] [Updated] (TINKERPOP-2035) Gremlin-JavaScript: Pass custom headers to the websocket connection

2018-09-13 Thread Jorge Bay (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Bay updated TINKERPOP-2035: - Summary: Gremlin-JavaScript: Pass custom headers to the websocket connection (was: Pass cust

[jira] [Commented] (TINKERPOP-2035) Gremlin-JavaScript: Pass custom headers to the websocket connection

2018-09-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613443#comment-16613443 ] ASF GitHub Bot commented on TINKERPOP-2035: --- Github user jorgebay commented

[GitHub] tinkerpop issue #929: TINKERPOP-2035 Pass custom headers to the websocket co...

2018-09-13 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/929 Thanks for the patch @deejvince and thanks for filing TINKERPOP-2035 @beebs-systap ! I think its a good idea to expose ways to set the request header, as it's part of the [protocol](http

[jira] [Assigned] (TINKERPOP-1972) inject() tests are throwing exceptions in .NET GLV tests

2018-09-13 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-1972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette reassigned TINKERPOP-1972: --- Assignee: stephen mallette (was: Jorge Bay) > inject() tests are throwi

[jira] [Closed] (TINKERPOP-2031) Remove support for -i in gremlin-server.sh

2018-09-13 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stephen mallette closed TINKERPOP-2031. --- Resolution: Done Assignee: stephen mallette > Remove support for -i in grem

[GitHub] tinkerpop pull request #926: TINKERPOP-2031 Removed support for -i in gremli...

2018-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/926 ---

[jira] [Commented] (TINKERPOP-2031) Remove support for -i in gremlin-server.sh

2018-09-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613317#comment-16613317 ] ASF GitHub Bot commented on TINKERPOP-2031: --- Github user asfgit closed the