Too bad that the indents had to be changed in the code files, but I like how
the tagging works. Maybe we can fix the indents in the docs post-processor and
keep the code files clean...
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1025 ]
This message was relayed
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1024 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
Also, I think this PR is a replacement for #1013 (meaning the old one can be
closed).
[ Full content available at: https://github.com/apache/tinkerpop/pull/1023 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1021 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1022 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
tp33, master both pass up to the python module.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1027 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1022 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1025 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I think the readability during authoring isn't that bad when you use a tool
that can preview AsciiDoc like the [AsciiDoc plugin for VS
Code](https://marketplace.visualstudio.com/items?itemName=joaompinto.asciidoctor-vscode)
as it can directly include the code examples. So, at least in the
Will do.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1027 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1024 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
This is good and bad at the same time. we get tested code but at the expense of
readability in the docs during authoring. I guess it's more good than bad
though. Do you feel like this needs to be merged for 3.4.0?
[ Full content available at: https://github.com/apache/tinkerpop/pull/1025 ]
> We don't need to merge this for the upcoming release,
agreed - let's save this so that we don't do anything to throw a wrench into
release at this point given those environment changes that are required here.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1026 ]
This
have you tested this all the way through the other branches yet?
VOTE +1 - assuming everything passes there as well.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1027 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Hi all, just checking in during the holiday period. My laptop will return
to the off position shortly, but I wanted to point out that we seem to have
a problem with Python:
https://travis-ci.org/apache/tinkerpop/jobs/472444735
every current PR seems to be in fail mode right now. We will want to
stephen mallette created TINKERPOP-2122:
---
Summary: Expose status codes from server errors
Key: TINKERPOP-2122
URL: https://issues.apache.org/jira/browse/TINKERPOP-2122
Project: TinkerPop
`mvn clean install -DskipIntegrationTests=false` SUCCESS
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1027 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
I also had problems building with the Docker image when I used the flags `-i
-t` recently, so there seems to be a problem in general.
VOTE +1
[ Full content available at: https://github.com/apache/tinkerpop/pull/1027 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
18 matches
Mail list logo