Looks good to me.
Robert Dale
On Thu, Jan 3, 2019 at 4:06 PM Daniel Kuppitz wrote:
> Yea, I already had them locally, I just didn't feel like changing that part
> of the validation script. Since we don't touch the zip files after they
> were generated, I assume that signing still works as expe
Yea, I already had them locally, I just didn't feel like changing that part
of the validation script. Since we don't touch the zip files after they
were generated, I assume that signing still works as expected.
Cheers,
Daniel
On Thu, Jan 3, 2019 at 2:03 PM Stephen Mallette
wrote:
> btw, in cas
Skimmed over the docs, they look good, too.
VOTE +1
On Thu, Jan 3, 2019 at 5:07 AM Robert Dale wrote:
> validate-distribution.sh 3.2.11 passes.
>
> VOTE +1
>
> Robert Dale
>
>
> On Wed, Jan 2, 2019 at 4:49 PM Stephen Mallette
> wrote:
>
> > Hello,
> >
> > We are happy to announce that TinkerPo
btw, in case you want to test you need to do:
$ mvn install -Papache-release -DcreateChecksum=true -DskipTests
and you will see the zip with signatures in /target. if you don't have gpg
stuff setup you can at least check the zip by changng "install" to
"package".
On Thu, Jan 3, 2019 at 3:14 PM S
I modified my validation script so that it copies the files from my m2
directory instead of downloading them. I also commented out the checksum
check (it can only fail as it would compare my local zip files against
remote checksum files) and the docs check (I haven't built them locally).
With that
I think I figured out how to ignore those directories. Had to override the
default apache parent pom source distribution process - it didn't take into
account non-JVM file stuffs. I didn't see where it was easily accessible to
extend so I just overrode the whole thing. Just pushed a fix on tp33 and
Hi,
Sqlg passes all its own tests and TinkerPop's structure and process
tests.
Vote +1
Cheers
Pieter
On Wed, 2019-01-02 at 16:49 -0500, Stephen Mallette wrote:
> Hello,
>
> We are happy to announce that TinkerPop 3.3.5 is ready for release.
>
> The release artifacts can be found at this locat
rm -rf gremlin-dotnet/src/{obj,_site}
rm -rf
gremlin-javascript/src/main/javascript/gremlin-javascript/node_modules
This helps to get a clean build, git clean seems to be the better choice
though.
However, I have no clue how we can control the contents of the src zip
file, I don't even know which
Maybe anything generated should be excluded:
src/docfx
src/gremlin-dotnet-source.iml
src/Gremlin.Net/Driver/obj
src/Gremlin.Net.Template.3.3.4.nupkg
src/nuget-4.4.1.exe
src/obj
src/_site
.vscode
or better yet, 'git clean -fdx' before building the src zip. I haven't
looked at the src zip build pr
it's too bad validate-distribution.sh passed on my environment. should
docker be rigged to run it instead so it's run on a clean environment from
now on? like:
docker/validate-distribution.sh
??
On Thu, Jan 3, 2019 at 10:34 AM Daniel Kuppitz wrote:
> I just found this entry in my log:
>
>
I just found this entry in my log:
[exec] [19-01-03 03:20:16.409]Error:System.AggregateException: One or
more errors occurred.
(/home/smallette/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/build/y2x4l8vu.n3b/hlxtywvr.c9b
does not exist)
(/home/smallette/git/apache/incubator-ti
Confirmed, building the tag just worked for me, too.
On Thu, Jan 3, 2019 at 7:59 AM Robert Dale wrote:
> Building the tag from github works fine. Looks like some local build
> artifacts snuck into the src.zip.
>
> Excluding gremlin-dotnet, validate-distribution passes.
>
> Robert Dale
>
>
> On
Building the tag from github works fine. Looks like some local build
artifacts snuck into the src.zip.
Excluding gremlin-dotnet, validate-distribution passes.
Robert Dale
On Thu, Jan 3, 2019 at 9:49 AM Robert Dale wrote:
> Daniel, I had to install 'msbuild' in addition to the mono packages.
Daniel, I had to install 'msbuild' in addition to the mono packages. I
also installed mono-addins-devel. I don't know if that actually did
anything.
But now I get some errors with :
System.IO.FileNotFoundException:
*/home/smallette*/git/apache/incubator-tinkerpop/gremlin-dotnet/src/obj/.cache/bu
Do you guys have Mono installed and the nuget-4.4.1.exe in
gremlin-dotnet/src?
The step that seems to fail for you is where mono executes nuget to
install docfx and a library used by docfx into the directory
gremlin-dotnet/src/docfx. Is that directory maybe already present on
your machines? If so,
I skimmed over the docs, they look good to me, but the
validate-distribution.sh script fails the same way as for Robert.
Investigating
Cheers,
Daniel
On Wed, Jan 2, 2019 at 2:58 PM Stephen Mallette
wrote:
> Hello,
>
> We are happy to announce that TinkerPop 3.3.5 is ready for release.
>
>
1. bin/validate-distribution.sh 3.3.5 error:
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-antrun-plugin:1.8:run (docfx) on project
gremlin-dotnet-source: An Ant BuildException has occured: exec returned: 1
[ERROR] around Ant part .. @
31:50 in
/tmp/tpdv/tinkerpop-3.3.5/gremlin
on #1, I did a system upgrade recently and looks like I lost nuget.
Installed nuget, progresses further but ran into other issues. Will keep
you posted.
Robert Dale
On Thu, Jan 3, 2019 at 8:54 AM Robert Dale wrote:
> 1. bin/validate-distribution.sh 3.3.5 error:
>
> [ERROR] Failed to execute go
validate-distribution.sh 3.2.11 passes.
VOTE +1
Robert Dale
On Wed, Jan 2, 2019 at 4:49 PM Stephen Mallette
wrote:
> Hello,
>
> We are happy to announce that TinkerPop 3.2.11 is ready for release.
>
> The release artifacts can be found at this location:
> https://dist.apache.org/repos
[
https://issues.apache.org/jira/browse/TINKERPOP-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16732965#comment-16732965
]
stephen mallette commented on TINKERPOP-2027:
-
Hi [~tec-goblin] thanks fo
I realized that i didn't remove the bindings content - i just moved it out from
under its own section header to the "lambda" stuff where it has more meaning as
bindings only have context in relation to those lambda based traversals:
https://github.com/apache/tinkerpop/commit/4658d8342d4d7b4e92d4
21 matches
Mail list logo
