[jira] [Updated] (TINKERPOP-2177) Streaming response immediately after authentication stops after first partial response

2019-03-08 Thread Jayanta Mondal (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jayanta Mondal updated TINKERPOP-2177: -- Description: +*Repro step*+:  Use gremlinpython 3.4.0 to issue 'g.V()' (or any gre

[jira] [Updated] (TINKERPOP-2177) Streaming response immediately after authentication stops after first partial response

2019-03-08 Thread Jayanta Mondal (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jayanta Mondal updated TINKERPOP-2177: -- Attachment: gremlinpythonbug.png > Streaming response immediately after authenticat

[jira] [Created] (TINKERPOP-2177) Streaming response immediately after authentication stops after first partial response

2019-03-08 Thread Jayanta Mondal (JIRA)
Jayanta Mondal created TINKERPOP-2177: - Summary: Streaming response immediately after authentication stops after first partial response Key: TINKERPOP-2177 URL: https://issues.apache.org/jira/browse/TINKERPOP-

[jira] [Commented] (TINKERPOP-2169) Responses exceeding maxContentLength cause subsequent queries to hang

2019-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788393#comment-16788393 ] ASF GitHub Bot commented on TINKERPOP-2169: --- divijvaidya commented on pull

[jira] [Commented] (TINKERPOP-2169) Responses exceeding maxContentLength cause subsequent queries to hang

2019-03-08 Thread Divij Vaidya (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788395#comment-16788395 ] Divij Vaidya commented on TINKERPOP-2169: - Summarizing the list of bugs discu

[GitHub] [tinkerpop] divijvaidya opened pull request #1082: TINKERPOP-2169 Responses exceeding maxContentLength cause subsequent queries to hang

2019-03-08 Thread GitHub
https://issues.apache.org/jira/browse/TINKERPOP-2169 https://issues.apache.org/jira/browse/TINKERPOP-2173 Similar pull request associated with master branch: #1081 This pull request corresponds to branch tp33. **Problem** 1. On receiving a CorruptedFrameException, the current code does not dec

[jira] [Created] (TINKERPOP-2176) Incorrect decision of host unavailable in Java client

2019-03-08 Thread Divij Vaidya (JIRA)
Divij Vaidya created TINKERPOP-2176: --- Summary: Incorrect decision of host unavailable in Java client Key: TINKERPOP-2176 URL: https://issues.apache.org/jira/browse/TINKERPOP-2176 Project: TinkerPop

[jira] [Created] (TINKERPOP-2175) Executor thread is not returned on channel close

2019-03-08 Thread Divij Vaidya (JIRA)
Divij Vaidya created TINKERPOP-2175: --- Summary: Executor thread is not returned on channel close Key: TINKERPOP-2175 URL: https://issues.apache.org/jira/browse/TINKERPOP-2175 Project: TinkerPop

[jira] [Commented] (TINKERPOP-2173) Incorrect reset of log level in integration test

2019-03-08 Thread Divij Vaidya (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788337#comment-16788337 ] Divij Vaidya commented on TINKERPOP-2173: - I was working around this code bas

[GitHub] [tinkerpop] divijvaidya opened pull request #1081: Tinkerpop-2169:Responses exceeding maxContentLength cause subsequent queries to hang

2019-03-08 Thread GitHub
https://issues.apache.org/jira/browse/TINKERPOP-2169 https://issues.apache.org/jira/browse/TINKERPOP-2173 **Problem** 1. On receiving a CorruptedFrameException, the current code does not decrement the borrowed count on the connection and marks the connection for destruction. However, the connect

[GitHub] [tinkerpop] olivertowers commented on issue #1077: TINKERPOP-2135/2148 Fix removal of closed connections and add round-robin scheduling

2019-03-08 Thread GitHub
I had started working on implementing an improved the connection pool handling for Gremlin.NET, which I based very closely on the java gremlin-driver connection pool implementation. It attempted to solve the similar areas that this PR is addressing as well as few other key areas: - Select conn

[jira] [Commented] (TINKERPOP-2174) Improve Docker Image Security

2019-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16788029#comment-16788029 ] ASF GitHub Bot commented on TINKERPOP-2174: --- robertdale commented on pull r

[GitHub] [tinkerpop] robertdale opened pull request #1080: TINKERPOP-2174 Improve Docker Image Security

2019-03-08 Thread GitHub
https://issues.apache.org/jira/browse/TINKERPOP-2174 - use least privileged user:group - `gremlin` - use the dynamic tag to get the latest image: `openjdk:8-jre-alpine` also snuck in some non-security ones: - replaced deprecated `MAINTAINER` with `LABEL maintainer...` - use `--no-cache` instea

Re: [DISCUSS] proposed release of 3.3.6/3.4.1

2019-03-08 Thread Robert Dale
I'd like to get this in before the freeze (if it counts towards the freeze): https://issues.apache.org/jira/browse/TINKERPOP-2174 Robert Dale On Wed, Mar 6, 2019 at 2:06 PM Stephen Mallette wrote: > Thanks for sharing TINKERPOP-2169 as something to keep an eye on. Depending > on the nature of

[jira] [Created] (TINKERPOP-2174) Improve Docker Image Security

2019-03-08 Thread Robert Dale (JIRA)
Robert Dale created TINKERPOP-2174: -- Summary: Improve Docker Image Security Key: TINKERPOP-2174 URL: https://issues.apache.org/jira/browse/TINKERPOP-2174 Project: TinkerPop Issue Type: Impro

[GitHub] [tinkerpop] dkuppitz commented on pull request #1076: TINKERPOP-2112 Fold property() so that T values can work in any order

2019-03-08 Thread GitHub
I think this part should also take the graph's default cardinality (`graph().features().vertex().getCardinality(key)`) into account. [ Full content available at: https://github.com/apache/tinkerpop/pull/1076 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] dkuppitz commented on issue #1074: TINKERPOP-2171 Allow sparql() to be extended with Gremlin steps.

2019-03-08 Thread GitHub
VOTE +1 [ Full content available at: https://github.com/apache/tinkerpop/pull/1074 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2076) TinkerPop does not build with current (v11) Java version

2019-03-08 Thread Robert Dale (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787838#comment-16787838 ] Robert Dale commented on TINKERPOP-2076: I didn't read it thoroughly. I saw t

[jira] [Commented] (TINKERPOP-2076) TinkerPop does not build with current (v11) Java version

2019-03-08 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787818#comment-16787818 ] stephen mallette commented on TINKERPOP-2076: - Well, that fix went to mas

[jira] [Commented] (TINKERPOP-2173) Incorrect reset of log level in integration test

2019-03-08 Thread stephen mallette (JIRA)
[ https://issues.apache.org/jira/browse/TINKERPOP-2173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787807#comment-16787807 ] stephen mallette commented on TINKERPOP-2173: - Looks like a cut/paste err

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1077: TINKERPOP-2135/2148 Fix removal of closed connections and add round-robin scheduling

2019-03-08 Thread GitHub
> If there is another connection open, I would prefer > EnsurePoolIsPopulatedAsync() to occur in the background That is what you suggested with the task scheduler, right? (Maybe I'm just understanding you wrong here, I'm especially not sure about how a back-off delay could work.) I agree that d

[GitHub] [tinkerpop] jorgebay commented on pull request #1077: TINKERPOP-2135/2148 Fix removal of closed connections and add round-robin scheduling

2019-03-08 Thread GitHub
Depends on how we want to handle pool failures. >From what I understand, `GetAvailableConnectionAsync()` gets called every >time, and it calls `EnsurePoolIsPopulatedAsync()` so, it's possible that >during the lifetime of the driver, a connection is closed and >`EnsurePoolIsPopulatedAsync()` nee

[GitHub] [tinkerpop] jorgebay commented on pull request #1077: TINKERPOP-2135/2148 Fix removal of closed connections and add round-robin scheduling

2019-03-08 Thread GitHub
I'm thinking on situations when you end up with a half backed pool, that can be because initially its not possible to create all connections or because one of the connections in the pool closes, after the successfully establishing it. > Maybe a try-finally where we just Dispose() all createdConn

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1077: TINKERPOP-2135/2148 Fix removal of closed connections and add round-robin scheduling

2019-03-08 Thread GitHub
Good catch. Maybe a try-finally where we just `Dispose()` all `createdConnections` in the `finally` block? I think if a connection establishment fails then we should just let the exception be raised to the user as we can't really handle that. (Maybe it makes sense later to add a retry here, but

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1077: TINKERPOP-2135/2148 Fix removal of closed connections and add round-robin scheduling

2019-03-08 Thread GitHub
So, a counter that breaks out of the loop after like 10 retries and `Task.Delay(TimeSpan.FromMilliseconds(5))` before the `continue`? [ Full content available at: https://github.com/apache/tinkerpop/pull/1077 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1077: TINKERPOP-2135/2148 Fix removal of closed connections and add round-robin scheduling

2019-03-08 Thread GitHub
Hmm, yes, kind of obvious now that you mention it. [ Full content available at: https://github.com/apache/tinkerpop/pull/1077 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on pull request #1077: TINKERPOP-2135/2148 Fix removal of closed connections and add round-robin scheduling

2019-03-08 Thread GitHub
This can be the condition of the `while` statement. [ Full content available at: https://github.com/apache/tinkerpop/pull/1077 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on pull request #1077: TINKERPOP-2135/2148 Fix removal of closed connections and add round-robin scheduling

2019-03-08 Thread GitHub
Note that, if there are 2 or more connections being created and one creation fails, the other connection will be open but not returned / or added to the `_connections` list, so it will be leaked. [ Full content available at: https://github.com/apache/tinkerpop/pull/1077 ] This message was relaye

[GitHub] [tinkerpop] jorgebay commented on pull request #1077: TINKERPOP-2135/2148 Fix removal of closed connections and add round-robin scheduling

2019-03-08 Thread GitHub
I think we should implement some kind of back-off or delayed retry. Otherwise, if there is a failure, this loop will never stop until we get it to the pool gets to the final length. [ Full content available at: https://github.com/apache/tinkerpop/pull/1077 ] This message was relayed via gitbox.a