Previously if message was null:
1. First line in try fails.
2. Catch fail on first line with null.
3. No handling at all.
Current:
1. First line fails with reasonable error.
Result:
Exactly same exception handling behavior, but more clean message we can work
with.
[ Full content available
I seem to have resolved the docker problem with:
https://github.com/apache/tinkerpop/commit/9c829cab193d769afb0d3687b37d372418d135f9
travis appears content with that aspect of the build now on all release
branches.
On Tue, Feb 18, 2020 at 6:50 AM Stephen Mallette
wrote:
> We can't seem to
[
https://issues.apache.org/jira/browse/TINKERPOP-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040206#comment-17040206
]
Anton edited comment on TINKERPOP-2340 at 2/19/20 4:51 PM:
---
Interesting, if
[
https://issues.apache.org/jira/browse/TINKERPOP-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040206#comment-17040206
]
Anton commented on TINKERPOP-2340:
--
Interesting, if I am reading this right, it looks like the
> Will not because message is null. There there is silent error eating.
You're right. I should have looked taken a closer look.
> Could we just check that deserialized object is not null and throw exception.
Yes, I think that might be the best option as we expect the message to never be
null.
[
https://issues.apache.org/jira/browse/TINKERPOP-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florian Hockmann reopened TINKERPOP-2019:
-
OK, looks like the bug is still present. I however agree with Stephen that we
@greedy , could we set a new version node, v7.6 or other for travis-ci ?
I found async/await failed.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1251 ]
[
https://issues.apache.org/jira/browse/TINKERPOP-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen Mallette updated TINKERPOP-2340:
Component/s: process
> MatchStep with VertexStep - Neither the sideEffects,
[
https://issues.apache.org/jira/browse/TINKERPOP-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040018#comment-17040018
]
Stephen Mallette commented on TINKERPOP-2340:
-
I'm not sure what the problem is, but the
> Parse and we notify the response handler about the exception.
Will not because message is null. There there is silent error eating.
Could we just check that deserialized object is not null and throw exception.
```
var receivedMsg =
_messageSerializer.DeserializeMessage>(received);
[ pull request closed by heljoyLiu ]
[ Full content available at: https://github.com/apache/tinkerpop/pull/1243 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
Thanks @heljoyLiu , I'll review it shortly.
Feel free to close this one.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1243 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
> Also at same time not sure if it hides bad JSON setting or other json related
> behind. Should we fail totally in this case?
We would still get an error in that case [from
here](https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs#L136)
where
[
https://issues.apache.org/jira/browse/TINKERPOP-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039816#comment-17039816
]
Dzmitry.Lahoda commented on TINKERPOP-2019:
---
Please reopen issue.
>
[
https://issues.apache.org/jira/browse/TINKERPOP-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039801#comment-17039801
]
Dzmitry.Lahoda commented on TINKERPOP-2192:
---
[
https://issues.apache.org/jira/browse/TINKERPOP-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039799#comment-17039799
]
ASF GitHub Bot commented on TINKERPOP-2192:
---
dzmitry-lahoda commented on pull request
[
https://issues.apache.org/jira/browse/TINKERPOP-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039796#comment-17039796
]
Dzmitry.Lahoda commented on TINKERPOP-2192:
---
Not sure if `TryRemove` can `out` null. I see
[
https://issues.apache.org/jira/browse/TINKERPOP-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039792#comment-17039792
]
Dzmitry.Lahoda commented on TINKERPOP-2192:
---
I was able to reproduce issues once. With
18 matches
Mail list logo
