Re: [DISCUSS] withEmbedded()

2020-09-02 Thread Jorge Bay Gondra
I think naming it withEmbedded() can help users understand the difference between the two modes (I remember it took me a while to grasp it). On Tue, Sep 1, 2020 at 4:51 PM Kelvin Lawrence wrote: > I think this makes good sense and improves the naming consistency. > > Cheers, > Kelvin > > On 2020

Re: [DISCUSS] withEmbedded()

2020-09-02 Thread Stephen Mallette
It's interesting - we never actually went forward promoting withGraph() at all. I seem to recall that we might have expected to promote it in full in 3.5.0, but we've been delayed a bit in that version's development so it's been forgotten. :/ Personally, i don't see a problem with changing the docu

[jira] [Commented] (TINKERPOP-2413) Prefer withEmbedded() to withGraph() on AnonymousTraversalSource

2020-09-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189271#comment-17189271 ] ASF GitHub Bot commented on TINKERPOP-2413: --- spmallette opened a new pull r

Re: [DISCUSS] withEmbedded()

2020-09-02 Thread Stephen Mallette
Here's the PR for withEmbedded(Graph) https://github.com/apache/tinkerpop/pull/1322 I opted to leave this method out of GLVs since there is no real "embedded graph" to provide there. So, a bit inconsistent, but it seems better than creating the idea that it's possible to do embedded connections w

[jira] [Commented] (TINKERPOP-2392) Improve module level documentation for GLVs

2020-09-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189285#comment-17189285 ] ASF GitHub Bot commented on TINKERPOP-2392: --- jorgebay commented on a change

[jira] [Commented] (TINKERPOP-2392) Improve module level documentation for GLVs

2020-09-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189287#comment-17189287 ] ASF GitHub Bot commented on TINKERPOP-2392: --- spmallette commented on a chan

[jira] [Commented] (TINKERPOP-2405) gremlinpython: traversal hangs when the connection is established but the servers stops responding later

2020-09-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189290#comment-17189290 ] ASF GitHub Bot commented on TINKERPOP-2405: --- spmallette merged pull request

[jira] [Closed] (TINKERPOP-2405) gremlinpython: traversal hangs when the connection is established but the servers stops responding later

2020-09-02 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette closed TINKERPOP-2405. --- Fix Version/s: 3.4.9 3.5.0 Resolution: Fixed > gremlinp

[jira] [Commented] (TINKERPOP-2392) Improve module level documentation for GLVs

2020-09-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189306#comment-17189306 ] ASF GitHub Bot commented on TINKERPOP-2392: --- spmallette merged pull request

[jira] [Updated] (TINKERPOP-2392) Improve module level documentation for GLVs

2020-09-02 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette updated TINKERPOP-2392: Component/s: python dotnet > Improve module level documentatio

[jira] [Closed] (TINKERPOP-2392) Improve module level documentation for GLVs

2020-09-02 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette closed TINKERPOP-2392. --- Fix Version/s: 3.4.9 3.5.0 Resolution: Done not sure th

[jira] [Updated] (TINKERPOP-2392) Improve module level documentation for GLVs

2020-09-02 Thread Stephen Mallette (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Mallette updated TINKERPOP-2392: Component/s: (was: python) (was: javascript)

[jira] [Commented] (TINKERPOP-2389) Authorization support in TinkerPop

2020-09-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TINKERPOP-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189864#comment-17189864 ] ASF GitHub Bot commented on TINKERPOP-2389: --- vtslab commented on pull reque