[GitHub] tinkerpop issue #876: TINKERPOP-967 Support nested-repeat() structures

Github user GCHQResearcher1337 commented on the issue: https://github.com/apache/tinkerpop/pull/876 @spmallette Yep. Awesome - thanks for all your input + reviews! ---

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

Github user GCHQResearcher1337 commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202452106 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_LP_NL_O_P_S_SE_SL_Traverser.java --- @@ -0,0

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

Github user GCHQResearcher1337 commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202445268 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_LP_NL_O_P_S_SE_SL_Traverser.java --- @@ -0,0

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

Github user GCHQResearcher1337 commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202442057 --- Diff: gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStepTest.java --- @@ -39,7 +39,9

[GitHub] tinkerpop issue #876: TINKERPOP-967 Support nested-repeat() structures

Github user GCHQResearcher1337 commented on the issue: https://github.com/apache/tinkerpop/pull/876 @dkuppitz Thanks for your comments. I think I've fixed the issues you spotted. ---

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

Github user GCHQResearcher1337 commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202418371 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/util/LabelledCounter.java --- @@ -0,0 +1,85

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

Github user GCHQResearcher1337 commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r202415964 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/traverser/B_LP_NL_O_P_S_SE_SL_Traverser.java --- @@ -0,0

[GitHub] tinkerpop issue #876: TINKERPOP-967 Support nested-repeat() structures

Github user GCHQResearcher1337 commented on the issue: https://github.com/apache/tinkerpop/pull/876 I've now added support for named loops - described in https://issues.apache.org/jira/browse/TINKERPOP-967, however I have not introduced a new `times()` step. I think

[GitHub] tinkerpop issue #876: TINKERPOP-967 Support nested-repeat() structures

Github user GCHQResearcher1337 commented on the issue: https://github.com/apache/tinkerpop/pull/876 @spamallete I think I steered away from that because I initially misunderstood what marko meant - as you pointed out the plumbing (`incrLoops` taking a `stepLabel`) for nested repeats

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

Github user GCHQResearcher1337 commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r196370588 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatTest.java --- @@ -386,5 +456,26

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

Github user GCHQResearcher1337 commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/876#discussion_r195046349 --- Diff: gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatTest.java --- @@ -386,5 +456,26

[GitHub] tinkerpop pull request #876: TINKERPOP-967 Support nested-repeat() structure...

GitHub user GCHQResearcher1337 opened a pull request: https://github.com/apache/tinkerpop/pull/876 TINKERPOP-967 Support nested-repeat() structures https://issues.apache.org/jira/browse/TINKERPOP-967 This allows nested loops to be used in traversals e.g. ```gremlin