Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/865
VOTE +1
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/870
VOTE +1
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/869
VOTE +1
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/854
My bad on the lack of merge. I'll do it today.
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/854
I'm happy to write a test. Is there an established way to to test large
streaming responses? Or any tips on how to write one?
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/854
VOTE +1
---
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/854
TINKERPOP-1933 gremlin-python maximum recursion depth exceeded on large
responses
https://issues.apache.org/jira/browse/TINKERPOP-1933
Recursive calls to the `data_received` were
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/796
sweet
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/796
Yes this affects both 32 and master
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/797
There is a bit of a learning curve working with the Gremlin-Python source.
Do you plan on giving this another try? If so, I will help you review. If not,
let me know and I can give it a go.
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/797
https://github.com/apache/tinkerpop/tree/master/gremlin-python/src/main/jython/tests
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/797
This needs a test to demonstrate that it works. I haven't run the code yet,
but what happens to the key value of the binding? Does this generate GraphSON
with bindings, or just the valu
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/796
LGTM
VOTE +1
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/790
VOTE +1
---
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/790#discussion_r165509842
--- Diff: gremlin-python/src/main/jython/tests/conftest.py ---
@@ -1,4 +1,4 @@
-'''
+"""
--- End diff --
Ok willdo.
---
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/790#discussion_r164506631
--- Diff: gremlin-python/src/main/jython/tests/conftest.py ---
@@ -1,4 +1,4 @@
-'''
+"""
--- End diff --
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/790
TINKERPOP-1875 Gremlin-Python only aggregates to list when using GraphSON3
https://issues.apache.org/jira/browse/TINKERPOP-1875
This PR fixes server response message deserialization in
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/769
VOTE +1
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/749
Done. VOTE +1
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/749
Does this need a changelog for 3.3.1 as well, or are the 3.2.7 changes
assumed to be included in 3.3.1?
---
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/749
Tinkerpop 1807 Gremlin-Python doesn't support GraphSON types g:Date,
g:Timestamp and g:UUID
https://issues.apache.org/jira/browse/TINKERPOP-1807
This PR follows #741, adding su
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/741#discussion_r150620490
--- Diff:
gremlin-python/src/main/jython/tests/structure/io/test_graphson.py ---
@@ -121,6 +125,19 @@ class X(object
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/741#discussion_r150589566
--- Diff:
gremlin-python/src/main/jython/tests/structure/io/test_graphson.py ---
@@ -121,6 +125,19 @@ class X(object
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/741
TINKERPOP-1807 Gremlin-Python doesn't support GraphSON types g:Date,
g:Timestamp and g:UUID
https://issues.apache.org/jira/browse/TINKERPOP-1807
This PR add support for GraphSON
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/728
VOTE +1
---
Github user davebshow closed the pull request at:
https://github.com/apache/tinkerpop/pull/691
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/691
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/691
Yeah well there are different approaches we could have taken, e.g. leaving
the custom reader/writer options for the v2 and v3 serializer classes, but it
seems to me that the point of those
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/691
TINKERPOP-1747 Streamline inheritance for gremlin-python GrapnSON
serializer classes
https://issues.apache.org/jira/browse/TINKERPOP-1747
This PR cleans up the code used to define
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/678
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/675
Vote +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user davebshow commented on the pull request:
https://github.com/apache/tinkerpop/commit/f99f5524183891372ae7ac60651ff8ac7d23e7d7#commitcomment-22104442
In gremlin-python/src/main/jython/tests/process/test_dsl.py:
In gremlin-python/src/main/jython/tests/process/test_dsl.py
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/594
Tested using mvn clean install with .glv file. Gremlin tests ran
successfully against Python 2.7 and Python 3.5 interpreter.
VOTE +1
---
If your project is set up for it, you can
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/594
Should this include documentation on how to run against the different
interpreters?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/591
LGTM. Also ran server/console integration. Docs are clear.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/593
Didn't even know that existed. Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/593
TINKERPOP-1665 Remove unittest from Gremlin-Python tests
A simple PR that removes unnecessary `unittest` code from the
Gremlin-Python test suite.
VOTE +1
You can merge this pull
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/565
`docker/build.sh -t -n -i` succeeded.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/554
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user davebshow closed the pull request at:
https://github.com/apache/tinkerpop/pull/554
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/554
I think this is ready. Anyone want to be a third reviewer for this?
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/558
`mvn clean install` passes.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/561
Yeah it looks fine to me. It seems that properties are serialized before
the element dict is "cleaned up". I don't see why you would serialize it again.
However, I haven't
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/554
Well, I've made my last review of this code and pushed a bit of cleanup and
a small fix. IMHO, this is ready to be merged. I'll wait to see if there are
any more comments or feedb
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/554
Ok, I have now rebased ad added docs to both reference and upgrading. I
also reviewed the old implementation and made a couple small fixes for
consistency. I also added standard op processor
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/554
Yeah I figured we would need to add docs. Where should I add to the
reference docs? Maybe in [Gremlin
Applications](https://github.com/apache/tinkerpop/blob/master/docs/src/reference/gremlin
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/554
TINKERPOP-1599 implement real gremlin-python driver
https://issues.apache.org/jira/browse/TINKERPOP-1599
This PR adds a better driver implementation for gremlin-python:
- Uses
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/553
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/551
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/551
This makes a lot of sense. You can probably remove the instance check for
the custom long type after making this change:
https://github.com/apache/tinkerpop/blob/master/gremlin-python/src/main
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/533
All of my driver tests succeed against this branch. They use
`'saslMechanism': 'PLAIN'`, so they don't expect any `sasl` value to be
returned.
VOTE +1
---
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/515
TINKERPOP-1581 Gremlin-Python driver connection is not thread safe.
https://issues.apache.org/jira/browse/TINKERPOP-1581
This was a simple fix. The `DriverRemoteConnection.__init__
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/478
Tests pass. I think this is a good base to move forward to a fully
functional async API for Gremlin.
VOTE +1
---
If your project is set up for it, you can reply to this email and have
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/478
Well I implemented this API for gremlin-python. There is one major problem:
side effects. Since the current side effect API is designed to be synchronous
(calling `run_sync`), it cannot be used
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/478
As long as the driver returns a future with a compatible API, yes, it can
be used with all Python versions. The snippet you provided will throw an error
with an Asyncio or Tornado client, as
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/505
TINKERPOP-1561 gremiln-python GraphSONWriter doesn't properly serialize
long in Python 3.5
https://issues.apache.org/jira/browse/TINKERPOP-1561
Added custom `dictify()` meth
Github user davebshow commented on the pull request:
https://github.com/apache/tinkerpop/commit/aa85a9b5278c55aa28014aa135c8498428295071#commitcomment-19905983
In
gremlin-python/src/main/jython/gremlin_python/driver/driver_remote_connection.py:
In
gremlin-python/src/main/jython
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/478
I put together a quick example of how this can be implemented in
gremlin-python. Obviously the example is incomplete, but hopefully it can help
move the discussion forward:
https://github.com
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/478
I agree with the `RemoteConnection` implementation being pluggable.
Therefore, the GLV should be able to use any remote connection as long as it
complies with the API. But, since pre-Python3
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/478
@aholmberg I'm not sure if I follow...it seems to me that if a
`RemoteConnection` implementation returns a list (or future list ) of
`FutureTraversers`, the traversal API can still r
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/478
After actually thinking about this, the type of future returned will depend
on the underlying `RemoteConnection` implementation. A call to the
method`promise` will cause a `(async
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/478
@spmallette you can easily implement something similar in Python using
Futures. Using `tornado.concurrent.Future` would probably make the most sense,
as is is already 2/3 compatible and should
Github user davebshow closed the pull request at:
https://github.com/apache/tinkerpop/pull/451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/451
Manually closing post merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/448
Yeah makes sense. I'm hoping to do some major refactors of the Driver over
the next couple months anyway, but I'm juggling too many things right now.
Either way this seems good to go
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/448
I like this. Much simpler, well tested, in general a nice PR. Pretty slick
using the metaclass to create the de-/serializer maps. One thing I wonder:
Presumably using the `GraphSONIO
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/451
Alright I think this branch is ready to go. VOTE + 1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82311244
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java
---
@@ -39,12 +40,14
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/448
To be honest, I think that we should move away from the `unittest`
framework in the future. I know that `pytest` allows for unittest integration,
but in general this is to facilitate the
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82239737
--- Diff:
gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffectsTest.java
---
@@ -0,0 +1,116
Github user davebshow commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/451#discussion_r82095012
--- Diff:
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/remote/DriverRemoteTraversalSideEffects.java
---
@@ -54,22 +57,30 @@ public
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/451
Tinkerpop 1458 Gremlin Server doesn't return confirmation upon Traversal
OpProcessor "close" op
https://issues.apache.org/jira/browse/TINKERPOP-1458
This PR updates the
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/437
Good stuff, I should get there today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/418
I agree, the tests need work. I'm hoping to get there this weekend. I think
though, as Stephen said, this can be merged pretty safely.
---
If your project is set up for it, you can rep
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/413
Stop accepting transactions after a close makes sense to me. This branch
builds successfully using mvn clean install. VOTE +1
---
If your project is set up for it, you can reply to this email
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/412
This branch builds successfully using mvn clean install. VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/415
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/416
Worked like a charm. Vote +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/415
1c5e698 add simple package metadata.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/415
Maintaining compatibility should be pretty simple, but as you can see from
the PR, there are little things that can go wrong. I think the main issue we
will run into with this library is
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/415
Sounds good to me. I'll make the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/415
Tinkerpop 1448: gremlin-python should be Python 2/3 compatible
https://issues.apache.org/jira/browse/TINKERPOP-1448
This PR adds code to promote Python 2/3 compatibility in the gremlin
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/408
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/393
@spmallette I think when you run the tests in the virtualenv you may have
trouble with the site-package test suites being invoked (specifically wheel).
To remedy this, I added lib/lib64 to the
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/393
Add pytest-runner in order to properly build gremlin-python dependencies.
Use `pytest-runner` in order to invoke `pytest` using the `setup.py test`
command and properly build dependencies
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/389
Implemented side effect interface for gremlin-python
This is my first go at implementing a side effects interface for
gremlin-python. It allows you to do things like:
```python
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/388
Cleanup of Python code in groovy traversal generator
This PR makes some very simple changes to the groovy traversal source
generator:
- Removes unnecessary `return` statements (Python
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/379
added simple WebSocketRemoteConnection
Also: Made RemoteConnection into actual abstract base class, fixed typo in
remote_graph.
This PR starts the process of adding a websocket driver
Github user davebshow closed the pull request at:
https://github.com/apache/tinkerpop/pull/343
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/343
Sorry, I hurried this because I was leaving town and have not had much
access to the internet. Due to the many conflicts it will be simpler to close
and create a new PR. I will make sure all
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/343
This would probably be because the way tests are set up the modules are
getting executed as a script instead of as a package. I don't know how to fix
this off the top of my head--I ha
GitHub user davebshow opened a pull request:
https://github.com/apache/tinkerpop/pull/343
restructured gremlin-python package
This PR restructures the Gremlin-Python package to unify packages, modules,
and classes under the gremlin_python namespace as discussed on the mailing
list
92 matches
Mail list logo
