[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-26 Thread GitHub
Sure, but that's not what I meant. My problem was simply that I wasn't sure how the value format and the type info are combined to form the full serialized value, but I just read the first paragraph of this document again where this is explained with: ``` {type_code}{type_info}{value_flag}{value

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-22 Thread GitHub
```suggestion - `{item_0}...{item_n}` are the items of the `Tree`. `{item_i}` is composed of a `{key}` which is a fully-qualified typed value ``` [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.or

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-22 Thread GitHub
```suggestion - `{bulk}` is an `Int`. ``` [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-22 Thread GitHub
I think I'm missing something here, but shouldn't the _Type Info_ above include this `{blob}` value? [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-22 Thread GitHub
```suggestion - `{month}` is a `Byte` to represent the month, from 1 (January) to 12 (December) ``` [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-22 Thread GitHub
```suggestion - `{length}` is an `Int` describing the amount of items. ``` [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-22 Thread GitHub
```suggestion - `{configuration}` is a `Map` of data used to configure the strategy that will be given to a `TraversalStrategy` `create(Configuration)` method. ``` [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@t

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-22 Thread GitHub
```suggestion Request and response messages are special container types used to represent messages from client to the server and the ``` [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-22 Thread GitHub
```suggestion - `{strategy_class}` is a `Class` that is of type `TraversalStrategy`. ``` [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-22 Thread GitHub
```suggestion - `{item_0}...{item_n}` are the items of the `BulkSet`. `{item_i}` is a sequence of a fully qualified typed value composed of ``` [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1000: TINKERPOP-1942 New Binary Serialization Format

2018-12-22 Thread GitHub
Not really important, but wouldn't it make more sense to change the ordering here and let the source instructions come first followed by the steps? [ Full content available at: https://github.com/apache/tinkerpop/pull/1000 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.