Github user krlohnes commented on the issue:
https://github.com/apache/tinkerpop/pull/838
@spmallette Yeah, I'm still giving this some thought. Just rebased.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/838
@krlohnes not sure if you're still thinking about this one, but if you are
and you get a chance, could you please rebase your branch to freshen things up
a bit?
---
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r201976894
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +300,40 @@ public
Github user krlohnes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r201906049
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +300,40 @@ public
Github user krlohnes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r201900734
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +300,40 @@ public
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r199549370
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +300,40 @@ public
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r195710841
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +300,40 @@ public
Github user krlohnes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r195496700
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +300,40 @@ public
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r193389532
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +300,40 @@ public
Github user krlohnes commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r192728027
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +300,40 @@ public
RepeatEndStep(final Traversal.Admin traversal)
{
super(traversal);
}
+final LinkedList> stashedStarts = new
LinkedList<>();
+
+private Traverser.Admin nextStart(RepeatStep repeatStep,
boolean useDfs) {
+if
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r191529207
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +300,40 @@ public
RepeatEndStep(final Traversal.Admin traversal)
{
super(traversal);
}
+final LinkedList> stashedStarts = new
LinkedList<>();
+
+private Traverser.Admin nextStart(RepeatStep repeatStep,
boolean useDfs) {
+if
[~dkuppitz]
> Emit predicate ignored after final loop of a RepeatStep with times or until
> ---
>
> Key: TINKERPOP-1973
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1973
>
","b").by().by(loops()))
==>[a:v[1],b:-1]
==>[a:v[3],b:0]
==>[a:v[2],b:0]
==>[a:v[4],b:0]
==>[a:v[5],b:1]
==>[a:v[3],b:1]
{noformat}
> Emit predicate ignored after final loop of a RepeatStep with times or until
>
().is(lt(3))).repeat()}}. The issue was that
repeat was executed for levels less than 3 and then the last level exiting the
repeat.
> Emit predicate ignored after final loop of a RepeatStep with times or un
{{emit())) should not be seen as a filter, but rather as an injector.
> Emit predicate ignored after final loop of a RepeatStep with times or until
> ---
>
> Key: TINKERPOP-1973
>
wanted to double check
with you to see if you thought there was a purpose for it.
> Emit predicate ignored after final loop of a RepeatStep with times or until
> ---
>
> Key: TI
is not
applied to the output of the last loop of the {{RepeatStep}}.
{code}
gremlin> g = TinkerFactory.createModern().traversal()
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
gremlin> g.V().repeat(out()).emit(has('name', 'lop')).values('name')
==>lop
==>lop
==>lo
to
the output of the last loop of the `RepeatStep`.
{code:groovy}
gremlin> g = TinkerFactory.createModern().traversal()
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
gremlin> g.V().repeat(out()).emit(has('name', 'lop')).values('name')
==>lop
==>lop
==>lo
Ted Wilmes created TINKERPOP-1973:
-
Summary: Emit predicate ignored after final loop of a RepeatStep
with times or until
Key: TINKERPOP-1973
URL: https://issues.apache.org/jira/browse/TINKERPOP-1973
More investigation, shows that the new RepeatUnrollStrategy completely
removes the RepeatStep because of the times 0 logic.
For the global case the leaves behind the GraphStep and the HasStep thus
returning a1.
For the LocalStep case the LocalSteps are now empty (after the
RepeatSteps have been
Hi,
I am running the following tests on 3.2.1-SNAPSHOT
@Test
public void testRepeat() {
final TinkerGraph g = TinkerGraph.open();
Vertex a1 = g.addVertex(T.label, "A", "name", "a1");
Vertex b1 = g.addVertex(T.label, "B", "name", "b1");
Vertex b2 =
23 matches
Mail list logo
