svn commit: r651795 - /tomcat/current/tc5.5.x/STATUS.txt

2008-04-25 Thread billbarker
Author: billbarker Date: Fri Apr 25 19:59:01 2008 New Revision: 651795 URL: http://svn.apache.org/viewvc?rev=651795&view=rev Log: Propose patch Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/ST

svn commit: r651793 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-25 Thread billbarker
Author: billbarker Date: Fri Apr 25 19:55:13 2008 New Revision: 651793 URL: http://svn.apache.org/viewvc?rev=651793&view=rev Log: Propose patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.t

svn commit: r651792 - /tomcat/trunk/java/org/apache/jk/core/MsgContext.java

2008-04-25 Thread billbarker
Author: billbarker Date: Fri Apr 25 19:48:40 2008 New Revision: 651792 URL: http://svn.apache.org/viewvc?rev=651792&view=rev Log: Reduce signoff error message to DEBUG, since it is harmless if mod_jk has hung up the phone Modified: tomcat/trunk/java/org/apache/jk/core/MsgContext.java Modifi

DO NOT REPLY [Bug 44879] New: Deploying WAR overwrites context fragment

2008-04-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44879 Summary: Deploying WAR overwrites context fragment Product: Tomcat 5 Version: 5.5.25 Platform: All OS/Version: Mac OS X 10.4 Status: NEW Severity: minor Prior

svn commit: r651734 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 15:59:29 2008 New Revision: 651734 URL: http://svn.apache.org/viewvc?rev=651734&view=rev Log: Propose fix for 43425 Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATU

DO NOT REPLY [Bug 43425] Non-compliant annotations

2008-04-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43425 --- Comment #2 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-25 15:56:06 PST --- Patch has been applied to trunk and proposed for 6.0.x Many thanks for the patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?

svn commit: r651732 - in /tomcat/trunk/java/javax: annotation/security/DenyAll.java ejb/EJB.java persistence/PersistenceContext.java persistence/PersistenceProperty.java

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 15:55:38 2008 New Revision: 651732 URL: http://svn.apache.org/viewvc?rev=651732&view=rev Log: Fix bug https://issues.apache.org/bugzilla/show_bug.cgi?id=43425 Annotations not spec compliant. Patch provided by Dain Sundstrom. Added: tomcat/trunk/java/javax/persis

DO NOT REPLY [Bug 43617] attribute values within a .tag(x) file are not properly escaped

2008-04-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43617 --- Comment #4 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-25 15:40:15 PST --- Thanks for the additional test case. I have applied a better patch based on your original proposal. -- Configure bugmail: https://issues.apache.org/bugzi

svn commit: r651730 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 15:42:52 2008 New Revision: 651730 URL: http://svn.apache.org/viewvc?rev=651730&view=rev Log: Propose better patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS

svn commit: r651729 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 15:40:55 2008 New Revision: 651729 URL: http://svn.apache.org/viewvc?rev=651729&view=rev Log: Better fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43617 Correctly handle quotes in attribute values for tag(x) files. Modified: tomcat/trunk/java/org/apache

svn commit: r651725 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 15:39:52 2008 New Revision: 651725 URL: http://svn.apache.org/viewvc?rev=651725&view=rev Log: Revert previous patch. It didn't cover all cases. Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Modified: tomcat/trunk/java/org/apache/jasper/c

DO NOT REPLY [Bug 43578] Tomcat fails to start on linux if CATALINA_HOME contains a space

2008-04-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43578 --- Comment #4 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-25 15:09:00 PST --- Thanks for the patch suggestion. This has been committed to trunk and proposed for 6.0.x and 5.5.x. -- Configure bugmail: https://issues.apache.org/bugzi

svn commit: r651715 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 15:11:54 2008 New Revision: 651715 URL: http://svn.apache.org/viewvc?rev=651715&view=rev Log: Propose patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

svn commit: r651714 - /tomcat/current/tc5.5.x/STATUS.txt

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 15:11:33 2008 New Revision: 651714 URL: http://svn.apache.org/viewvc?rev=651714&view=rev Log: Propose patch Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.

svn commit: r651713 - /tomcat/trunk/bin/catalina.sh

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 15:07:55 2008 New Revision: 651713 URL: http://svn.apache.org/viewvc?rev=651713&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43578 Tomcat doesn't start in linux if CATALINA_BASE contains a space Patch provided by Ray Sauers Modified: tomc

DO NOT REPLY [Bug 43617] attribute values within a .tag(x) file are not properly escaped

2008-04-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43617 --- Comment #3 from Lucas Galfaso <[EMAIL PROTECTED]> 2008-04-25 14:57:46 PST --- Hi Mark and sorry to bug you, but the commited patch is still not good, the test case is http://java.sun.com/JSP/Page"; xmlns="http://www.w3.o

DO NOT REPLY [Bug 44877] New: ClassCastException due to bad TagHandlerPool name generation of two different tags

2008-04-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44877 Summary: ClassCastException due to bad TagHandlerPool name generation of two different tags Product: Tomcat 5 Version: 5.5.26 Platform: PC OS/Version: Windows XP

DO NOT REPLY [Bug 29936] XML parser loading problems by container

2008-04-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=29936 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED]

DO NOT REPLY [Bug 43444] Class loading problem

2008-04-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43444 Mark Thomas <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED

Re: Osgifing Tomcat

2008-04-25 Thread Henri Gomez
> But I think the main question is if it's worth it - there is a lot of > complexity and many things that can go wrong. Very few advanced users > will be able to use this - in particular if they have production > environments and some release testing is required ( i.e. it would be > quite hard

Re: Osgifing Tomcat

2008-04-25 Thread Costin Manolache
On Fri, Apr 25, 2008 at 12:49 AM, David Jencks <[EMAIL PROTECTED]> wrote: > > On Apr 24, 2008, at 11:11 PM, Henri Gomez wrote: > > > > > > > I've heard various claims of this nature from osgi zealots, but when > > > talking to apparent experts the only things resembling this they seemed > to > > >

svn commit: r651680 - in /tomcat/trunk/java/org/apache/catalina/deploy: ContextHandler.java ContextService.java ContextTransaction.java FilterDef.java NamingResources.java ResourceBase.java

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 11:38:38 2008 New Revision: 651680 URL: http://svn.apache.org/viewvc?rev=651680&view=rev Log: Fix compiler warnings for o.a.c.deploy.* Note using generics would have highlighted bug 43470 Modified: tomcat/trunk/java/org/apache/catalina/deploy/ContextHandler.java

svn commit: r651676 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 11:21:13 2008 New Revision: 651676 URL: http://svn.apache.org/viewvc?rev=651676&view=rev Log: Proposals Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=65

DO NOT REPLY [Bug 43470] ClassCastException at org.apache.catalina.deploy. NamingResources

2008-04-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43470 --- Comment #3 from Mark Thomas <[EMAIL PROTECTED]> 2008-04-25 11:17:47 PST --- Thanks for the patch. I had to make a few tweaks. See http://svn.apache.org/viewvc?rev=651675&view=rev It has been committed to trunk and proposed for 6.0.

svn commit: r651675 - /tomcat/trunk/java/org/apache/catalina/deploy/NamingResources.java

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 11:16:36 2008 New Revision: 651675 URL: http://svn.apache.org/viewvc?rev=651675&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43470 Based on a changes provided by Lucas Galfaso Modified: tomcat/trunk/java/org/apache/catalina/deploy/NamingR

svn commit: r651662 - /tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadWithAttributes.java

2008-04-25 Thread markt
Author: markt Date: Fri Apr 25 10:40:47 2008 New Revision: 651662 URL: http://svn.apache.org/viewvc?rev=651662&view=rev Log: Add missing access check. Modified: tomcat/trunk/java/org/apache/tomcat/util/threads/ThreadWithAttributes.java Modified: tomcat/trunk/java/org/apache/tomcat/util/thre

Re: Osgifing Tomcat

2008-04-25 Thread Damien B
David Jencks wrote: > On Apr 24, 2008, at 11:11 PM, Henri Gomez wrote: > > We'll see how OSGI works underload with Glassfish v3. Are they planning to support "gapless" redeployment of web apps using only osgi features, with no other servlet container support? If so is can you point to an explan

Re: Osgifing Tomcat

2008-04-25 Thread Henri Gomez
> Since this requires state mutation (see the hooks that an Erlang OTP > application will supply for state upgrade, for instance) there won't be > a "no other hooks" version, I think :-) > > This is doable (I've done it, but only as a proof of concept - as > pointed out, this is a long way awa

Re: Osgifing Tomcat

2008-04-25 Thread Jan Grant
On Fri, 25 Apr 2008, David Jencks wrote: > Are they planning to support "gapless" redeployment of web apps using only > osgi features, with no other servlet container support? If so is can you > point to an explanation of how they plan to do this? Since this requires state mutation (see the hook

Re: Osgifing Tomcat

2008-04-25 Thread David Jencks
On Apr 24, 2008, at 11:11 PM, Henri Gomez wrote: I've heard various claims of this nature from osgi zealots, but when talking to apparent experts the only things resembling this they seemed to know about were grad student experiments that did not have production use as even a far-in-the-fut