DO NOT REPLY [Bug 47240] New: catalina.bat typo when setting java.security.policy

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47240 Summary: catalina.bat typo when setting java.security.policy Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Windows XP Status: NEW Severity: trivial

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread William A. Rowe, Jr.
Filip Hanik - Dev Lists wrote: > sebb wrote: >> There's also a suggested set on the Apache site, see: >> >> http://www.apache.org/dev/version-control.html#https-svn-config >> > that's exactly my point, everytime I just onto a new machine, and I > forget, which I'm bound to do, to set the config

Re: Coding Guidelines, encodings, keywords

2009-05-21 Thread Filip Hanik - Dev Lists
Konstantin Kolinko wrote: Hi, all! Are there any Coding Guidelines that we ought to follow, or is our project on our own there? spaces instead of tabs :) I am interested in clarifying the following question: What is the character encoding for our sources. Our build scripts do not specify

Re: Coding Guidelines, encodings, keywords

2009-05-21 Thread sebb
On 22/05/2009, Konstantin Kolinko wrote: > Hi, all! > > Are there any Coding Guidelines that we ought to follow, > or is our project on our own there? > > I am interested in clarifying the following question: > What is the character encoding for our sources. > > Our build scripts do not speci

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Filip Hanik - Dev Lists
sebb wrote: On 22/05/2009, Rainer Jung wrote: On 22.05.2009 01:07, Filip Hanik - Dev Lists wrote: > rj...@apache.org wrote: >> Guys fix your svn configuration. ;) >> > This happens to me all the time, as I move between machines very often. > > Why is the ~/.subversion/config a client s

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Filip Hanik - Dev Lists
Konstantin Kolinko wrote: 2009/5/22 Filip Hanik - Dev Lists : rj...@apache.org wrote: Guys fix your svn configuration. ;) This happens to me all the time, as I move between machines very often. Why is the ~/.subversion/config a client setting? isn't there a way to setup proper

Coding Guidelines, encodings, keywords

2009-05-21 Thread Konstantin Kolinko
Hi, all! Are there any Coding Guidelines that we ought to follow, or is our project on our own there? I am interested in clarifying the following question: What is the character encoding for our sources. Our build scripts do not specify an explicit encoding yet, and, as I heard, some months ago

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread sebb
On 22/05/2009, Rainer Jung wrote: > On 22.05.2009 01:07, Filip Hanik - Dev Lists wrote: > > rj...@apache.org wrote: > >> Guys fix your svn configuration. ;) > >> > > This happens to me all the time, as I move between machines very often. > > > > Why is the ~/.subversion/config a client setti

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Rainer Jung
On 22.05.2009 01:07, Filip Hanik - Dev Lists wrote: > rj...@apache.org wrote: >> Guys fix your svn configuration. ;) >> > This happens to me all the time, as I move between machines very often. > > Why is the ~/.subversion/config a client setting? isn't there a way to > setup properties on the

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Konstantin Kolinko
2009/5/22 Filip Hanik - Dev Lists : > rj...@apache.org wrote: >> >> Guys fix your svn configuration. ;) >> > > This happens to me all the time, as I move between machines very often. > > Why is the ~/.subversion/config a client setting? isn't there a way to setup > properties on the server the clie

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Rainer Jung
On 22.05.2009 00:48, sebb wrote: > Some more fixes for trunk: > > svn ps svn:eol-style native > java/org/apache/catalina/ha/backend/CollectedInfo.java > svn ps svn:eol-style native > java/org/apache/catalina/ha/backend/HeartbeatListener.java > svn ps svn:eol-style native > java/org/apache/catalina

svn commit: r777319 - in /tomcat/trunk: java/org/apache/catalina/ha/backend/ modules/bayeux/ modules/bayeux/webapps/cometd/examples/simplechat/ modules/jdbc-pool/test/org/apache/tomcat/jdbc/test/ modu

2009-05-21 Thread rjung
Author: rjung Date: Thu May 21 23:29:02 2009 New Revision: 777319 URL: http://svn.apache.org/viewvc?rev=777319&view=rev Log: More missing svn properties. Modified: tomcat/trunk/java/org/apache/catalina/ha/backend/CollectedInfo.java (props changed) tomcat/trunk/java/org/apache/catalina/

svn commit: r777317 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-21 Thread fhanik
Author: fhanik Date: Thu May 21 23:23:55 2009 New Revision: 777317 URL: http://svn.apache.org/viewvc?rev=777317&view=rev Log: trivial Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=777

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Filip Hanik - Dev Lists
rj...@apache.org wrote: Guys fix your svn configuration. ;) This happens to me all the time, as I move between machines very often. Why is the ~/.subversion/config a client setting? isn't there a way to setup properties on the server the client can inherit from? so when I check out a proje

svn commit: r777307 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-21 Thread rjung
Author: rjung Date: Thu May 21 23:01:03 2009 New Revision: 777307 URL: http://svn.apache.org/viewvc?rev=777307&view=rev Log: Propose subversion property fixes. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread sebb
Some more fixes for trunk: svn ps svn:eol-style native java/org/apache/catalina/ha/backend/CollectedInfo.java svn ps svn:eol-style native java/org/apache/catalina/ha/backend/HeartbeatListener.java svn ps svn:eol-style native java/org/apache/catalina/ha/backend/MultiCastSender.java svn ps svn:eol-s

Re: Mutable public fields in Tomcat 6 code

2009-05-21 Thread Filip Hanik - Dev Lists
sebb wrote: There are quite a lot of public mutable static fields in the current Tomcat6 codebase. Such fields can allow malicious or accidental changes to occur, so should be avoided as far as possible. [And if a class has public mutable static fields it's generally impossible to make it thread

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Rainer Jung
On 21.05.2009 23:29, sebb wrote: > Here are a few more missing properties: > > svn ps svn:eol-style native java/javax/el/LocalStrings_es.properties > svn ps svn:eol-style native java/javax/servlet/LocalStrings_es.properties > svn ps svn:eol-style native > java/org/apache/catalina/ha/LocalStrings_e

Mutable public fields in Tomcat 6 code

2009-05-21 Thread sebb
There are quite a lot of public mutable static fields in the current Tomcat6 codebase. Such fields can allow malicious or accidental changes to occur, so should be avoided as far as possible. [And if a class has public mutable static fields it's generally impossible to make it thread-safe.] The c

Re: [VOTE] Release build 6.0.20

2009-05-21 Thread Rainer Jung
On 14.05.2009 01:33, Remy Maucherat wrote: > The candidates binaries are available here: > http://people.apache.org/~remm/tomcat-6/v6.0.20/ > > According to the release process, the 6.0.20 tag is: > [ ] Broken > [ ] Alpha > [ ] Beta > [X] Stable --

svn commit: r777268 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2009-05-21 Thread markt
Author: markt Date: Thu May 21 21:30:23 2009 New Revision: 777268 URL: http://svn.apache.org/viewvc?rev=777268&view=rev Log: Make a few methods static so they can easily be used from other classes (like LifecycleListeners) Add a note about manual context configuration and reload. Modified: t

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread sebb
Here are a few more missing properties: svn ps svn:eol-style native java/javax/el/LocalStrings_es.properties svn ps svn:eol-style native java/javax/servlet/LocalStrings_es.properties svn ps svn:eol-style native java/org/apache/catalina/ha/LocalStrings_es.properties svn ps svn:eol-style native java

DO NOT REPLY [Bug 47239] New: Fix Copyright sign in generated Javadoc

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47239 Summary: Fix Copyright sign in generated Javadoc Product: Tomcat 6 Version: unspecified Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5

svn commit: r777251 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread rjung
Author: rjung Date: Thu May 21 20:38:53 2009 New Revision: 777251 URL: http://svn.apache.org/viewvc?rev=777251&view=rev Log: Add missing keywords svn property. Already applied to tc6. Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java (props c

svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread rjung
Author: rjung Date: Thu May 21 20:35:36 2009 New Revision: 777247 URL: http://svn.apache.org/viewvc?rev=777247&view=rev Log: Missing svn properties keywords and eol-style. Found while checking the 6.0.20 release candidate. Guys fix your svn configuration. ;) Modified: tomcat/tc6.0.x/trunk/ja

DO NOT REPLY [Bug 47234] serviceStartTime is different in MemberImpl from McastServiceImpl

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47234 Filip Hanik changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r777210 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java

2009-05-21 Thread fhanik
Author: fhanik Date: Thu May 21 18:35:40 2009 New Revision: 777210 URL: http://svn.apache.org/viewvc?rev=777210&view=rev Log: Consolidate the use of service start time into one local variable https://issues.apache.org/bugzilla/show_bug.cgi?id=47234 Modified: tomcat/trunk/java/org/apache/cat

DO NOT REPLY [Bug 47234] serviceStartTime is different in MemberImpl from McastServiceImpl

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47234 --- Comment #2 from Ariel 2009-05-21 11:11:56 PST --- Hi Filip, I agree with your change. Do you know when it could be commited into the repository? Regards, Ariel -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.

DO NOT REPLY [Bug 47234] serviceStartTime is different in MemberImpl from McastServiceImpl

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47234 --- Comment #1 from Filip Hanik 2009-05-21 09:30:55 PST --- Created an attachment (id=23703) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23703) Proposed patch Consolidated service start time to use a single value -- C

DO NOT REPLY [Bug 47237] New: Put a hard limit on Http11NioProcessor objects

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47237 Summary: Put a hard limit on Http11NioProcessor objects Product: Tomcat 6 Version: 6.0.18 Platform: All OS/Version: All Status: NEW Severity: normal Priority:

Re: DO NOT REPLY [Bug 47234] New: serviceStartTime is different in MemberImpl from McastServiceImpl

2009-05-21 Thread Xie Xiaodong
Hello, Could you please only use serviceStartTime in McastServiceImpl, since serviceStartTime in MemberImpl has a comment "For the local member only"? Maybe the latter one is not designed to be used as you do now. 2009/5/21 > https://issues.apache.org/bugzilla/show_bug.cgi?id=47234 > >

Re: svn commit: r776940 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-21 Thread Rainer Jung
Hi Kontantin, On 21.05.2009 05:22, kkoli...@apache.org wrote: > Author: kkolinko > Date: Thu May 21 03:21:58 2009 > New Revision: 776940 > > URL: http://svn.apache.org/viewvc?rev=776940&view=rev > Log: > proposals > > Modified: > tomcat/tc6.0.x/trunk/STATUS.txt > > Modified: tomcat/tc6.0.x/

DO NOT REPLY [Bug 47235] New: MySQL example should *not* include usage of the autoReconnect flag

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47235 Summary: MySQL example should *not* include usage of the autoReconnect flag Product: Tomcat 6 Version: unspecified Platform: PC URL: http://tomcat.apache.org/tomca

DO NOT REPLY [Bug 47234] serviceStartTime is different in MemberImpl from McastServiceImpl

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47234 Ariel changed: What|Removed |Added CC||arieland...@hotmail.com -- Configure

DO NOT REPLY [Bug 47234] New: serviceStartTime is different in MemberImpl from McastServiceImpl

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47234 Summary: serviceStartTime is different in MemberImpl from McastServiceImpl Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Linux Status: NEW

DO NOT REPLY [Bug 47231] New: http://tomcat.apache.org/tomcat-6.0-doc/ssl-howto.html improvements

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47231 Summary: http://tomcat.apache.org/tomcat-6.0-doc/ssl-howto.html improvements Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Windows XP Status

DO NOT REPLY [Bug 47230] New: Include sample cert attributes for SSL connectors

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47230 Summary: Include sample cert attributes for SSL connectors Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Windows XP Status: NEW Severity: enhancement

DO NOT REPLY [Bug 46950] SSL renegotiation does not occur when resource with CLIENT-CERT auth is requested

2009-05-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46950 Alexey changed: What|Removed |Added CC||li...@liosa.net -- Configure bugmail