svn commit: r898682 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread kkolinko
Author: kkolinko Date: Wed Jan 13 08:48:12 2010 New Revision: 898682 URL: http://svn.apache.org/viewvc?rev=898682view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

Re: svn commit: r898496 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread Konstantin Kolinko
2010/1/12 ma...@apache.org: Author: markt Date: Tue Jan 12 20:30:46 2010 New Revision: 898496 URL: http://svn.apache.org/viewvc?rev=898496view=rev Log: Add note Modified:    tomcat/tc6.0.x/trunk/STATUS.txt  * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48421   Prevent

tagging 6.0.23

2010-01-13 Thread jean-frederic clere
Hi, I plan to tag 6.0.23 tomorrow lunch time (~13h00 my time). Please complain if that is not ok. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

Re: modify the source code to measure the time of processing a request

2010-01-13 Thread Pid
On 13/01/2010 06:37, Bao wrote: Hi, Our company is using the apache tomcat 6.0.20 as our server. And now I plan to measure the time of every requet processed in the server without the help of any benchmark tool. I plan to modify the code to add a time stamp in a request when it comes

Re: modify the source code to measure the time of processing a request

2010-01-13 Thread Bao
Thanks! could you tell me under the what content? --- 10年1月13日,周三, Pid p...@pidster.com 写道: 发件人: Pid p...@pidster.com 主题: Re: modify the source code to measure the time of processing a request 收件人: dev@tomcat.apache.org 日期: 2010年1月13日,周三,下午5:14 On 13/01/2010 06:37, Bao wrote: Hi,     Our

svn commit: r898697 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread rjung
Author: rjung Date: Wed Jan 13 10:16:21 2010 New Revision: 898697 URL: http://svn.apache.org/viewvc?rev=898697view=rev Log: Vote. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

Re: With a view to 6.0.23

2010-01-13 Thread Rainer Jung
On 12.01.2010 19:35, Mark Thomas wrote: On 12/01/2010 18:24, Konstantin Kolinko wrote: 2010/1/12 Mark Thomasma...@apache.org: Thank you for vote. I would very like to see the JULI FileHandler buffering patch in 6.0.23. A third vote is required. Done. I think we need to get 6.0.23 out asap.

Re: tagging 6.0.23

2010-01-13 Thread Rainer Jung
On 13.01.2010 10:09, jean-frederic clere wrote: Hi, I plan to tag 6.0.23 tomorrow lunch time (~13h00 my time). +1 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

svn commit: r898703 - /tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 10:26:58 2010 New Revision: 898703 URL: http://svn.apache.org/viewvc?rev=898703view=rev Log: Add TODO Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java URL:

DO NOT REPLY [Bug 48470] Tomcat hangs while stoppping

2010-01-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48470 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r898705 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 10:30:50 2010 New Revision: 898705 URL: http://svn.apache.org/viewvc?rev=898705view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48470 Ensure Tomcat does not lock up if shut down under load. Modified: tomcat/tc6.0.x/trunk/STATUS.txt

svn commit: r898707 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 10:37:53 2010 New Revision: 898707 URL: http://svn.apache.org/viewvc?rev=898707view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48516 Prevent possible NPE in JNDIRealm when user does not exist Patch provided by Kevin Conaway Modified:

DO NOT REPLY [Bug 48516] NullPointerException in JNDIRealm

2010-01-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48516 Mark Thomas ma...@apache.org changed: What|Removed |Added Component|Catalina|Catalina

Re: tagging 6.0.23

2010-01-13 Thread Mladen Turk
On 01/13/2010 10:09 AM, jean-frederic clere wrote: Hi, I plan to tag 6.0.23 tomorrow lunch time (~13h00 my time). Third luck ;) Please complain if that is not ok. +1 Cheers -- ^TM - To unsubscribe, e-mail:

svn commit: r898709 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/coyote/http11/ webapps/docs/ webapps/docs/config/

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 10:42:08 2010 New Revision: 898709 URL: http://svn.apache.org/viewvc?rev=898709view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48004 Allow applications to set the Server header Modified: tomcat/tc6.0.x/trunk/STATUS.txt

DO NOT REPLY [Bug 48004] setHeader() does not replace the previous value for a Server

2010-01-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48004 --- Comment #3 from Mark Thomas ma...@apache.org 2010-01-13 02:42:12 GMT --- The patch has been applied to 6.0.x and will be included in 6.0.23 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email

DO NOT REPLY [Bug 48464] Feature request: startup.bat: -title option needed

2010-01-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48464 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r898718 - /tomcat/trunk/webapps/docs/config/http.xml

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 11:18:10 2010 New Revision: 898718 URL: http://svn.apache.org/viewvc?rev=898718view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48532 Better documentation of the SSL connector defaults Modified: tomcat/trunk/webapps/docs/config/http.xml

svn commit: r898719 - in /tomcat/tc6.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/http.xml

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 11:22:47 2010 New Revision: 898719 URL: http://svn.apache.org/viewvc?rev=898719view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48532 Better documentation of the SSL connector defaults Modified: tomcat/tc6.0.x/trunk/ (props changed)

svn commit: r898722 - in /tomcat/tc5.5.x/trunk/container/webapps/docs: changelog.xml config/http.xml

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 11:26:39 2010 New Revision: 898722 URL: http://svn.apache.org/viewvc?rev=898722view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48532 Better documentation of the SSL connector defaults Modified:

DO NOT REPLY [Bug 48532] try to read truststore even when clientauth is false

2010-01-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48532 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r898742 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread jim
Author: jim Date: Wed Jan 13 13:27:33 2010 New Revision: 898742 URL: http://svn.apache.org/viewvc?rev=898742view=rev Log: tested and ok Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r898743 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread jim
Author: jim Date: Wed Jan 13 13:27:58 2010 New Revision: 898743 URL: http://svn.apache.org/viewvc?rev=898743view=rev Log: promote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r898745 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/juli/FileHandler.java webapps/docs/logging.xml

2010-01-13 Thread jim
Author: jim Date: Wed Jan 13 13:28:54 2010 New Revision: 898745 URL: http://svn.apache.org/viewvc?rev=898745view=rev Log: Merge r897380, r897381 from trunk: Followup for r816252/r891328 Allow to disable buffering in JULI FileHandler The previous implementation did not work as expected because of

svn commit: r898779 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread yoavs
Author: yoavs Date: Wed Jan 13 14:45:18 2010 New Revision: 898779 URL: http://svn.apache.org/viewvc?rev=898779view=rev Log: Add my votes pre 6.0.23 release. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

Re: svn commit: r897380 - /tomcat/trunk/java/org/apache/juli/FileHandler.java

2010-01-13 Thread Filip Hanik - Dev Lists
On 01/08/2010 09:00 PM, kkoli...@apache.org wrote: Author: kkolinko Date: Sat Jan 9 03:59:59 2010 New Revision: 897380 URL: http://svn.apache.org/viewvc?rev=897380view=rev Log: Followup for r816252/r891328 Allow to disable buffering in JULI FileHandler The previous implementation did not work

Re: svn commit: r898745 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/juli/FileHandler.java webapps/docs/logging.xml

2010-01-13 Thread Filip Hanik - Dev Lists
-1, I would propose this one to be writer.write(result); if (bufferSize 0) flush(); Here is why 1. No synchronized(this) - not sure why we think its needed 2. It allows a setting of bufferSize==0 - use system default 3. bufferSize0 do a flush of the writer best Filip On 01/13/2010

Re: svn commit: r898745 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/juli/FileHandler.java webapps/docs/logging.xml

2010-01-13 Thread Konstantin Kolinko
2010/1/13 Filip Hanik - Dev Lists devli...@hanik.com: -1, I would propose this one to be writer.write(result); if (bufferSize 0)    flush(); Here is why 1. No synchronized(this) - not sure why we think its needed Re: synchronized(this) -writer.write(result); +

Re: svn commit: r898745 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/juli/FileHandler.java webapps/docs/logging.xml

2010-01-13 Thread Mark Thomas
On 13/01/2010 16:24, Konstantin Kolinko wrote: There is Mark's patch for that (r898468), but I have doubts regarding Runtime.getRuntime().addShutdownHook(new Cleaner()); used there. Why? It is pretty much identical to the code in the standard LogManager. We could disable log buffering in

Re: svn commit: r898745 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/juli/FileHandler.java webapps/docs/logging.xml

2010-01-13 Thread Filip Hanik - Dev Lists
On 01/13/2010 09:24 AM, Konstantin Kolinko wrote: 2010/1/13 Filip Hanik - Dev Listsdevli...@hanik.com: -1, I would propose this one to be writer.write(result); if (bufferSize 0) flush(); Here is why 1. No synchronized(this) - not sure why we think its needed Re:

svn commit: r898836 - in /tomcat/trunk: java/org/apache/juli/FileHandler.java webapps/docs/logging.xml

2010-01-13 Thread fhanik
Author: fhanik Date: Wed Jan 13 17:00:26 2010 New Revision: 898836 URL: http://svn.apache.org/viewvc?rev=898836view=rev Log: Following changes 1. Default bufferSize is 0 - rely on system behavior 2. bufferSize of 0 will automatically flush the writer on each write 3. autoFlush for printWriter is

svn commit: r898838 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread fhanik
Author: fhanik Date: Wed Jan 13 17:01:52 2010 New Revision: 898838 URL: http://svn.apache.org/viewvc?rev=898838view=rev Log: well defined buffering behavior and sensible default Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r898860 - /tomcat/trunk/java/javax/el/BeanELResolver.java

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 17:53:36 2010 New Revision: 898860 URL: http://svn.apache.org/viewvc?rev=898860view=rev Log: If the method is found, mark the property as resolved Modified: tomcat/trunk/java/javax/el/BeanELResolver.java Modified: tomcat/trunk/java/javax/el/BeanELResolver.java

svn commit: r898862 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 18:00:24 2010 New Revision: 898862 URL: http://svn.apache.org/viewvc?rev=898862view=rev Log: Up the timeout. 100s isn't always long enough when stepping through why a failing test. Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

svn commit: r898863 - in /tomcat/trunk/test: org/apache/el/TestELInJsp.java org/apache/el/TesterBeanA.java org/apache/el/TesterBeanB.java webapp/el-method.jsp

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 18:01:26 2010 New Revision: 898863 URL: http://svn.apache.org/viewvc?rev=898863view=rev Log: Add a test for method invocation with parameters Added: tomcat/trunk/test/org/apache/el/TesterBeanA.java (with props)

svn commit: r898864 - in /tomcat/trunk/java/org/apache/el/parser: AstBracketSuffix.java AstDotSuffix.java AstValue.java ELParser.jjt Suffix.java

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 18:02:36 2010 New Revision: 898864 URL: http://svn.apache.org/viewvc?rev=898864view=rev Log: Implement method invocation with parameters Added: tomcat/trunk/java/org/apache/el/parser/Suffix.java (with props) Modified:

svn commit: r898865 - /tomcat/trunk/java/org/apache/el/parser/ELParser.java

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 18:05:59 2010 New Revision: 898865 URL: http://svn.apache.org/viewvc?rev=898865view=rev Log: Updated autogenerated code after r898864 Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.java Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.java

svn commit: r898889 - in /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool: DataSourceFactory.java DataSourceProxy.java PoolConfiguration.java PoolProperties.java jmx/ConnectionPool.jav

2010-01-13 Thread fhanik
Author: fhanik Date: Wed Jan 13 19:08:09 2010 New Revision: 898889 URL: http://svn.apache.org/viewvc?rev=898889view=rev Log: Remove a dependency on Java 6 that accidentally got introduced Modified: tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java

svn commit: r898897 - /tomcat/trunk/java/javax/el/

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 19:18:08 2010 New Revision: 898897 URL: http://svn.apache.org/viewvc?rev=898897view=rev Log: Tab police, fix Eclipse warnings, add @since Javadoc Modified: tomcat/trunk/java/javax/el/BeanELResolver.java tomcat/trunk/java/javax/el/CompositeELResolver.java

svn commit: r898900 - /tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 19:19:25 2010 New Revision: 898900 URL: http://svn.apache.org/viewvc?rev=898900view=rev Log: Jasper Parser change so methods with parameters aren't mistaken for functions Modified: tomcat/trunk/java/org/apache/jasper/compiler/ELParser.java Modified:

svn commit: r898902 - in /tomcat/trunk/java/javax/el: MethodExpression.java ValueExpression.java ValueReference.java

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 19:20:42 2010 New Revision: 898902 URL: http://svn.apache.org/viewvc?rev=898902view=rev Log: Implement remainder of EL 2.2. API changes Added: tomcat/trunk/java/javax/el/ValueReference.java (with props) Modified:

svn commit: r898906 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/ReplicationTransmitter.java

2010-01-13 Thread fhanik
Author: fhanik Date: Wed Jan 13 19:23:53 2010 New Revision: 898906 URL: http://svn.apache.org/viewvc?rev=898906view=rev Log: Force a unconditional disconnect when an error happens, like dropped connections to a firewall Modified:

svn commit: r898909 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread fhanik
Author: fhanik Date: Wed Jan 13 19:26:16 2010 New Revision: 898909 URL: http://svn.apache.org/viewvc?rev=898909view=rev Log: backport of connectivity fix Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

svn commit: r898912 - /tomcat/trunk/modules/jdbc-pool/build.properties.default

2010-01-13 Thread fhanik
Author: fhanik Date: Wed Jan 13 19:32:51 2010 New Revision: 898912 URL: http://svn.apache.org/viewvc?rev=898912view=rev Log: Up the version num Modified: tomcat/trunk/modules/jdbc-pool/build.properties.default Modified: tomcat/trunk/modules/jdbc-pool/build.properties.default URL:

svn commit: r898913 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java

2010-01-13 Thread fhanik
Author: fhanik Date: Wed Jan 13 19:34:31 2010 New Revision: 898913 URL: http://svn.apache.org/viewvc?rev=898913view=rev Log: Fix javadoc warnings Modified: tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java Modified:

svn commit: r898915 - /tomcat/tags/JDBC_POOL_1_0_8_4/

2010-01-13 Thread fhanik
Author: fhanik Date: Wed Jan 13 19:36:05 2010 New Revision: 898915 URL: http://svn.apache.org/viewvc?rev=898915view=rev Log: Tag current state Added: tomcat/tags/JDBC_POOL_1_0_8_4/ (props changed) - copied from r898914, tomcat/trunk/modules/jdbc-pool/ Propchange:

[Tomcat Wiki] Update of HowTo by ChristopherSchultz

2010-01-13 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The HowTo page has been changed by ChristopherSchultz. The comment on this change is: Fixed spelling of priviledges. Added reference to jsvc to the section on running without root..

svn commit: r898945 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread kkolinko
Author: kkolinko Date: Wed Jan 13 21:23:03 2010 New Revision: 898945 URL: http://svn.apache.org/viewvc?rev=898945view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL:

Re: svn commit: r898909 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread Konstantin Kolinko
2010/1/13 fha...@apache.org: Author: fhanik Date: Wed Jan 13 19:26:16 2010 New Revision: 898909 URL: http://svn.apache.org/viewvc?rev=898909view=rev Log: backport of connectivity fix Modified:    tomcat/tc6.0.x/trunk/STATUS.txt + +* Force disconnect upon transmission failure +  

Re: svn commit: r898909 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-13 Thread Filip Hanik - Dev Lists
On 01/13/2010 02:40 PM, Konstantin Kolinko wrote: 2010/1/13fha...@apache.org: Author: fhanik Date: Wed Jan 13 19:26:16 2010 New Revision: 898909 URL: http://svn.apache.org/viewvc?rev=898909view=rev Log: backport of connectivity fix Modified: tomcat/tc6.0.x/trunk/STATUS.txt

svn commit: r898967 - /tomcat/trunk/test/org/apache/el/TestValueExpressionImpl.java

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 22:08:54 2010 New Revision: 898967 URL: http://svn.apache.org/viewvc?rev=898967view=rev Log: Add a test case for the new ValueExpression.getValueReference() method. Added: tomcat/trunk/test/org/apache/el/TestValueExpressionImpl.java (with props) Added:

svn commit: r898969 - in /tomcat/trunk/java/org/apache/el: MethodExpressionImpl.java ValueExpressionImpl.java parser/AstValue.java parser/Node.java parser/SimpleNode.java

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 22:10:49 2010 New Revision: 898969 URL: http://svn.apache.org/viewvc?rev=898969view=rev Log: Implement the new ValueExpression.getValueReference() method. Add some plumbing for MethodExpression.isParametersProvided() Add some more generics where we can without

svn commit: r898975 - in /tomcat/site/trunk: docs/download-native.html docs/resources.html docs/stylesheets/tomcat.css xdocs/resources.xml

2010-01-13 Thread markt
Author: markt Date: Wed Jan 13 22:26:59 2010 New Revision: 898975 URL: http://svn.apache.org/viewvc?rev=898975view=rev Log: Add new Tomcat book Update generated content Modified: tomcat/site/trunk/docs/download-native.html tomcat/site/trunk/docs/resources.html

DO NOT REPLY [Bug 48498] 6.0.22RC: ArrayIndexOutOfBoundsException from Jasper when compilation error inside a CDATA block

2010-01-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48498 --- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com 2010-01-13 17:00:40 UTC --- Reproducible in 6.0.20. So, it is not a regression in the current 6.0.x. If anyone encounters this, one way to find where it failed is to search in

Re: svn commit: r898745 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/juli/FileHandler.java webapps/docs/logging.xml

2010-01-13 Thread Konstantin Kolinko
2010/1/13 Mark Thomas ma...@apache.org: On 13/01/2010 16:24, Konstantin Kolinko wrote: There is Mark's patch for that (r898468), but I have doubts regarding Runtime.getRuntime().addShutdownHook(new Cleaner()); used there. Why? It is pretty much identical to the code in the standard