org.apache.catalina.WELCOME_FILES constant (was: svn commit: r1043265)

2010-12-08 Thread Konstantin Kolinko
2010/12/8 ma...@apache.org: Author: markt Date: Wed Dec  8 01:14:43 2010 New Revision: 1043265 URL: http://svn.apache.org/viewvc?rev=1043265view=rev Log: Remove unused code. Make spacing consistent. Modified:    tomcat/trunk/java/org/apache/catalina/Globals.java Modified:

Re: org.apache.catalina.WELCOME_FILES constant (was: svn commit: r1043265)

2010-12-08 Thread Mark Thomas
On 08/12/2010 11:05, Konstantin Kolinko wrote: 2010/12/8 ma...@apache.org: Author: markt Date: Wed Dec 8 01:14:43 2010 New Revision: 1043265 URL: http://svn.apache.org/viewvc?rev=1043265view=rev Log: Remove unused code. Make spacing consistent. Modified:

svn commit: r1043364 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 11:36:49 2010 New Revision: 1043364 URL: http://svn.apache.org/viewvc?rev=1043364view=rev Log: Remove unused welcome file handling code Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified:

DO NOT REPLY [Bug 48973] Don't create SESSIONS.ser when no session exists

2010-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48973 --- Comment #2 from Marc Guillemot mguille...@yahoo.fr 2010-12-08 06:44:40 EST --- In fact the patch was incomplete and applying it as it introduces a bug: if no session exist, no SESSIONS.ser should be created AND previous SESSIONS.ser

DO NOT REPLY [Bug 50431] New: Creating new Files

2010-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50431 Summary: Creating new Files Product: Tomcat 5 Version: Unknown Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2

DO NOT REPLY [Bug 50431] Creating new Files

2010-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50431 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1043395 - in /tomcat/trunk/java/org/apache/coyote: ./ ajp/ http11/

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 12:57:54 2010 New Revision: 1043395 URL: http://svn.apache.org/viewvc?rev=1043395view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Pull up pause() and resume() methods Modified:

svn commit: r1043399 - in /tomcat/trunk/java/org/apache/coyote: ./ ajp/ http11/

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 13:06:46 2010 New Revision: 1043399 URL: http://svn.apache.org/viewvc?rev=1043399view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Pull up stop() Modified:

svn commit: r1043402 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocolHandler.java LocalStrings.properties

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 13:10:34 2010 New Revision: 1043402 URL: http://svn.apache.org/viewvc?rev=1043402view=rev Log: Nice idea, but need i18n for the actions so each needs its own string Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocolHandler.java

svn commit: r1043410 - in /tomcat/trunk/java/org/apache/coyote: ajp/AjpAprProtocol.java ajp/AjpProtocol.java ajp/Constants.java http11/Http11AprProtocol.java http11/Http11NioProtocol.java http11/Http1

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 13:37:11 2010 New Revision: 1043410 URL: http://svn.apache.org/viewvc?rev=1043410view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Align the init() methods (JSSE still to go) Modified:

DO NOT REPLY [Bug 48973] Don't create SESSIONS.ser when no session exists

2010-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48973 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com 2010-12-08 08:47:30 EST --- (In reply to comment #2) AFAIK, the SESSIONS.ser file is deleted in StandardManager.doLoad() upon successful or unsuccessful attempt to read it. Do

svn commit: r1043420 - /tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 13:51:42 2010 New Revision: 1043420 URL: http://svn.apache.org/viewvc?rev=1043420view=rev Log: JSSE will always be available in Tomcat 7 Modified: tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java Modified:

svn commit: r1043421 - /tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 13:52:06 2010 New Revision: 1043421 URL: http://svn.apache.org/viewvc?rev=1043421view=rev Log: Fix indents Modified: tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java Modified:

DO NOT REPLY [Bug 48973] Don't create SESSIONS.ser when no session exists

2010-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48973 --- Comment #4 from Marc Guillemot mguille...@yahoo.fr 2010-12-08 08:57:37 EST --- (In reply to comment #3) I hadn't checked doLoad(). I was only thinking that not writing a file with 0 sessions could have a consequence. I think that

Re: svn commit: r1043420 - /tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSEImplementation.java

2010-12-08 Thread sebb
On 8 December 2010 13:51, ma...@apache.org wrote: Author: markt Date: Wed Dec  8 13:51:42 2010 New Revision: 1043420 URL: http://svn.apache.org/viewvc?rev=1043420view=rev Log: JSSE will always be available in Tomcat 7 Modified:    

svn commit: r1043425 - /tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 14:09:26 2010 New Revision: 1043425 URL: http://svn.apache.org/viewvc?rev=1043425view=rev Log: Align BIO+JSSE with NIO+JSSE Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java Modified:

svn commit: r1043429 - in /tomcat/trunk/java/org/apache/coyote: ./ ajp/ http11/

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 14:19:23 2010 New Revision: 1043429 URL: http://svn.apache.org/viewvc?rev=1043429view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Pull up init() Modified:

svn commit: r1043433 - /tomcat/trunk/java/org/apache/coyote/LocalStrings.properties

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 14:33:51 2010 New Revision: 1043433 URL: http://svn.apache.org/viewvc?rev=1043433view=rev Log: Fix copy/paste error Modified: tomcat/trunk/java/org/apache/coyote/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/coyote/LocalStrings.properties URL:

svn commit: r1043437 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocolHandler.java LocalStrings.properties ajp/AjpAprProtocol.java ajp/AjpProtocol.java http11/Http11AprProtocol.java http11/H

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 14:36:26 2010 New Revision: 1043437 URL: http://svn.apache.org/viewvc?rev=1043437view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Move MBean registration from start() to init(). More MBean refactoring expected

svn commit: r1043441 - in /tomcat/trunk/java/org/apache/coyote: AbstractProtocolHandler.java LocalStrings.properties ajp/AjpAprProtocol.java ajp/AjpProtocol.java http11/Http11AprProtocol.java http11/H

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 14:51:10 2010 New Revision: 1043441 URL: http://svn.apache.org/viewvc?rev=1043441view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Pull up start() Modified:

svn commit: r1043444 - in /tomcat/trunk/java/org/apache/coyote/ajp: AbstractAjpProcessor.java AjpMessage.java Constants.java

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 15:07:20 2010 New Revision: 1043444 URL: http://svn.apache.org/viewvc?rev=1043444view=rev Log: Remove some unused code Fix some FindBugs niggles Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java

Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/

2010-12-08 Thread Christopher Schultz
Mark, On 12/5/2010 12:31 PM, Mark Thomas wrote: On 03/12/2010 16:07, schu...@apache.org wrote: Author: schultz Date: Fri Dec 3 16:07:50 2010 New Revision: 1041892 URL: http://svn.apache.org/viewvc?rev=1041892view=rev Log: Fixed bug 48692: Provide option to parse

Re: svn commit: r1043444 - in /tomcat/trunk/java/org/apache/coyote/ajp: AbstractAjpProcessor.java AjpMessage.java Constants.java

2010-12-08 Thread Konstantin Kolinko
2010/12/8 ma...@apache.org: Author: markt Date: Wed Dec  8 15:07:20 2010 New Revision: 1043444 URL: http://svn.apache.org/viewvc?rev=1043444view=rev Log: Remove some unused code Fix some FindBugs niggles Modified:    tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProcessor.java    

Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/

2010-12-08 Thread Mark Thomas
On 08/12/2010 15:39, Christopher Schultz wrote: Mark, On 12/5/2010 12:31 PM, Mark Thomas wrote: On 03/12/2010 16:07, schu...@apache.org wrote: Author: schultz Date: Fri Dec 3 16:07:50 2010 New Revision: 1041892 URL: http://svn.apache.org/viewvc?rev=1041892view=rev Log: Fixed bug

Re: svn commit: r1043444 - in /tomcat/trunk/java/org/apache/coyote/ajp: AbstractAjpProcessor.java AjpMessage.java Constants.java

2010-12-08 Thread Mark Thomas
On 08/12/2010 15:52, Konstantin Kolinko wrote: 2010/12/8 ma...@apache.org: Author: markt Date: Wed Dec 8 15:07:20 2010 New Revision: 1043444 URL: http://svn.apache.org/viewvc?rev=1043444view=rev Log: Remove some unused code Fix some FindBugs niggles Modified:

svn commit: r1043531 - in /tomcat/trunk: checkstyle.xml java/org/apache/catalina/connector/Connector.java java/org/apache/catalina/connector/CoyoteAdapter.java java/org/apache/coyote/AbstractProtocolH

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 17:15:50 2010 New Revision: 1043531 URL: http://svn.apache.org/viewvc?rev=1043531view=rev Log: Re-factoring in support of https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 ProtocolHandler should register itself with MBean server rather than have the

Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/

2010-12-08 Thread Christopher Schultz
Mark, On 12/5/2010 12:31 PM, Mark Thomas wrote: On 03/12/2010 16:07, schu...@apache.org wrote: Author: schultz Date: Fri Dec 3 16:07:50 2010 New Revision: 1041892 +if(methodSet.contains(TRACE)) +throw new IllegalArgumentException(TRACE method MUST NOT include an

svn commit: r1043611 - /tomcat/native/trunk/native/src/poll.c

2010-12-08 Thread costin
Author: costin Date: Wed Dec 8 19:07:41 2010 New Revision: 1043611 URL: http://svn.apache.org/viewvc?rev=1043611view=rev Log: Javadoc for Poll.create() describes ENOTIMPL error if THREADSAFE is requested but not supported. The old code was silently removing THREADSAFE flag, java side wouldn't

Re: svn commit: r1043611 - /tomcat/native/trunk/native/src/poll.c

2010-12-08 Thread Mladen Turk
On 12/08/2010 08:07 PM, cos...@apache.org wrote: Author: costin +// Pass the ENOTIMPL to java, as described in javadocs. Java must clean the +// flag, will know it's not supported. .c file and c++ style comment ??? Welcome to the beautiful land of native code, Costin :)

Re: svn commit: r1041892 - in /tomcat/trunk: java/org/apache/catalina/connector/ test/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/

2010-12-08 Thread Mark Thomas
On 08/12/2010 18:03, Christopher Schultz wrote: Mark, On 12/5/2010 12:31 PM, Mark Thomas wrote: On 03/12/2010 16:07, schu...@apache.org wrote: Author: schultz Date: Fri Dec 3 16:07:50 2010 New Revision: 1041892 +if(methodSet.contains(TRACE)) +throw new

svn commit: r1043696 - /tomcat/native/trunk/native/src/poll.c

2010-12-08 Thread costin
Author: costin Date: Wed Dec 8 21:45:05 2010 New Revision: 1043696 URL: http://svn.apache.org/viewvc?rev=1043696view=rev Log: Fix comment style, thanks Mladen. Modified: tomcat/native/trunk/native/src/poll.c Modified: tomcat/native/trunk/native/src/poll.c URL:

tc-native: adding few more features

2010-12-08 Thread Costin Manolache
Hi, I have few features mostly done - I'm looking to add them in a way that allows Java code to detect if the new methods are there and use them, or use the old library if needed. What I'm trying to add: - BIO pair mode for SSL - right now we attach to a socket, in BIO pair you can just

svn commit: r1043734 - in /tomcat/trunk/java/org/apache/coyote: Constants.java Request.java

2010-12-08 Thread markt
Author: markt Date: Wed Dec 8 22:25:04 2010 New Revision: 1043734 URL: http://svn.apache.org/viewvc?rev=1043734view=rev Log: Removed a little more unused code Modified: tomcat/trunk/java/org/apache/coyote/Constants.java tomcat/trunk/java/org/apache/coyote/Request.java Modified:

DO NOT REPLY [Bug 50360] Server socket still bound after Embedded.stop is invoked

2010-12-08 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 --- Comment #9 from Martin Grotzke martin.grot...@googlemail.com 2010-12-08 19:15:46 EST --- D'oh. Is there another solution in sight? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are