svn commit: r1515282 - /tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/WsConfigListener.java

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 06:35:58 2013 New Revision: 1515282 URL: http://svn.apache.org/r1515282 Log: Remove dependency on Tomcat internals from examples. Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/websocket/echo/WsConfigListener.java Modified:

svn commit: r1515286 - /tomcat/trunk/webapps/docs/web-socket-howto.xml

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 06:48:36 2013 New Revision: 1515286 URL: http://svn.apache.org/r1515286 Log: Fix typos Modified: tomcat/trunk/webapps/docs/web-socket-howto.xml Modified: tomcat/trunk/webapps/docs/web-socket-howto.xml URL:

svn commit: r1515290 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/LocalStrings.properties

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 07:05:24 2013 New Revision: 1515290 URL: http://svn.apache.org/r1515290 Log: Remove unused string Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/LocalStrings.properties Modified:

buildbot failure in ASF Buildbot on tomcat-trunk

2013-08-19 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4847 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

Re: Back-porting JSR-356 Progress update

2013-08-19 Thread Mark Thomas
On 16/08/2013 15:46, Mark Thomas wrote: The JSR-356 API and implementation has been back-ported to Tomcat 7. The necessary plumbing for the non-blocking support required by JSR-356 has been back-ported to Tomcat 7. All compilation errors have been resolved. The unit tests all pass.

Re: Back-porting JSR-356 Progress update

2013-08-19 Thread jean-frederic clere
On 08/19/2013 03:22 PM, Mark Thomas wrote: I plan to commit what I have so far once I am happy that the unit tests still work. Cool Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

svn commit: r1515433 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 14:12:01 2013 New Revision: 1515433 URL: http://svn.apache.org/r1515433 Log: Simplify Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java URL:

svn commit: r1515454 - in /tomcat/trunk: java/org/apache/catalina/connector/InputBuffer.java java/org/apache/catalina/connector/Request.java java/org/apache/coyote/Request.java test/org/apache/catalin

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 14:54:15 2013 New Revision: 1515454 URL: http://svn.apache.org/r1515454 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55438 Don't call onAllDataRead() twice for an empty request body. Make the non-blocking test more robust as on client disconnect the

[Bug 55438] Non Blocking API's onAllDataRead being called twice

2013-08-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55438 --- Comment #2 from Mark Thomas ma...@apache.org --- Thanks for the test case. I have committed it to trunk along with a fix that works on OSX. I need to check the fix on Windows and Linux before closing this issue. -- You are receiving

svn propchange: r1515454 - svn:log

2013-08-19 Thread markt
Author: markt Revision: 1515454 Modified property: svn:log Modified: svn:log at Mon Aug 19 14:55:50 2013 -- --- svn:log (original) +++ svn:log Mon Aug 19 14:55:50 2013 @@ -1,3 +1,4 @@ Fix

[Bug 55438] Non Blocking API's onAllDataRead being called twice

2013-08-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55438 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1515583 - in /tomcat/tc7.0.x/trunk/java/org/apache: catalina/mbeans/ catalina/tribes/ catalina/tribes/transport/ coyote/http11/upgrade/servlet31/ jasper/ tomcat/util/modeler/

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 20:11:47 2013 New Revision: 1515583 URL: http://svn.apache.org/r1515583 Log: Fix some Javadoc errors Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/mbeans/MBeanFactory.java tomcat/tc7.0.x/trunk/java/org/apache/catalina/tribes/MembershipService.java

Re: Constants.IS_SECURITY_ENABLED

2013-08-19 Thread Raymond Auge
On Sun, Aug 18, 2013 at 3:36 PM, Mark Thomas ma...@apache.org wrote: On 18/08/2013 20:06, Raymond Auge wrote: On Sun, Aug 18, 2013 at 1:59 PM, Mark Thomas ma...@apache.org wrote: First of all this is a container concern, not an application concern. Secondly, a security manager applies JVM

svn commit: r1515587 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsDOMSource.java

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 20:19:23 2013 New Revision: 1515587 URL: http://svn.apache.org/r1515587 Log: Deprecate an unused class Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsDOMSource.java Modified:

svn commit: r1515588 - in /tomcat/trunk/java/org/apache/tomcat/websocket/server: UpgradeUtil.java WsFilter.java

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 20:21:32 2013 New Revision: 1515588 URL: http://svn.apache.org/r1515588 Log: Fix typo Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java tomcat/trunk/java/org/apache/tomcat/websocket/server/WsFilter.java Modified:

Re: Constants.IS_SECURITY_ENABLED

2013-08-19 Thread Mark Thomas
On 19/08/2013 21:11, Raymond Auge wrote: On Sun, Aug 18, 2013 at 3:36 PM, Mark Thomas ma...@apache.org wrote: On 18/08/2013 20:06, Raymond Auge wrote: On Sun, Aug 18, 2013 at 1:59 PM, Mark Thomas ma...@apache.org wrote: First of all this is a container concern, not an application concern.

Re: Constants.IS_SECURITY_ENABLED

2013-08-19 Thread Raymond Auge
Fair enough! Thank you On Mon, Aug 19, 2013 at 4:49 PM, Mark Thomas ma...@apache.org wrote: On 19/08/2013 21:11, Raymond Auge wrote: On Sun, Aug 18, 2013 at 3:36 PM, Mark Thomas ma...@apache.org wrote: On 18/08/2013 20:06, Raymond Auge wrote: On Sun, Aug 18, 2013 at 1:59 PM, Mark

svn commit: r1515612 - /tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 21:24:05 2013 New Revision: 1515612 URL: http://svn.apache.org/r1515612 Log: Don't try and register a WebSocket session that we know to be closed. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java Modified:

buildbot success in ASF Buildbot on tomcat-trunk

2013-08-19 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4850 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build

svn commit: r1515663 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 23:25:14 2013 New Revision: 1515663 URL: http://svn.apache.org/r1515663 Log: Correct comment Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsFrameBase.java URL:

svn commit: r1515664 - in /tomcat/trunk/java/org/apache/tomcat/websocket/server: WsHttpUpgradeHandler.java WsServerContainer.java

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 23:32:28 2013 New Revision: 1515664 URL: http://svn.apache.org/r1515664 Log: Rework r1515612 Avoid ISE when session is closed. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java

svn commit: r1515669 - in /tomcat/trunk/test/org/apache/tomcat/websocket: TestUtil.java pojo/TestPojoEndpointBase.java

2013-08-19 Thread markt
Author: markt Date: Mon Aug 19 23:41:30 2013 New Revision: 1515669 URL: http://svn.apache.org/r1515669 Log: Fix unit test failure observed on command line on Windows. SecureRandom took took long to initialise causing test to fail. Initialize a SecureRandom instance before running the test.

[GUMP@vmgump]: Project jakarta-tomcat-jasper_tc5 (in module jakarta-tomcat-jasper_tc5) failed

2013-08-19 Thread bobh
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project jakarta-tomcat-jasper_tc5 has an issue affecting its community

[GUMP@vmgump]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed

2013-08-19 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2013-08-19 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This

[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2013-08-19 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration.

[Bug 55453] New: AJP send Body with Status 304

2013-08-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55453 Bug ID: 55453 Summary: AJP send Body with Status 304 Product: Tomcat 7 Version: unspecified Hardware: PC OS: Windows XP Status: NEW Severity:

Re: Back-porting JSR-356 Progress update

2013-08-19 Thread Rainer Jung
On 19.08.2013 15:22, Mark Thomas wrote: On 16/08/2013 15:46, Mark Thomas wrote: Updating the build script has proved interesting. The WebSocket implementation depends on Tomcat internals but was also required to build the examples. That meant that the WebSocket build script was significantly