[Bug 56391] test error for NIO and org.apache.tomcat.util.net.TestSsl

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56391 --- Comment #14 from Remy Maucherat --- >From my debugging, in the test it is never NEED_TASK, so tasks() is not called (and it doesn't feel wrong). However, (tracing the write, since that is what the test is doing) the handshake status go

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2014-04-23 Thread Bill Barker
it-4.12-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20140423-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/pub

[Bug 55483] ELException when object has overloaded methods

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55483 --- Comment #7 from Christopher Ng --- The fix for this has broken one of our EL expressions, we have an overloaded method like so: doSomething(HttpServletRequest a, String b, String c, String d); doSomething(String a, String b, String c,

svn commit: r1589382 - in /tomcat/tc6.0.x/trunk: STATUS.txt res/tomcat.nsi webapps/docs/changelog.xml

2014-04-23 Thread kkolinko
Author: kkolinko Date: Wed Apr 23 12:24:10 2014 New Revision: 1589382 URL: http://svn.apache.org/r1589382 Log: Improvements to exe installer: Specify explicit JVM memory sizes when installing the service (--JvmMs, --JvmMx) with values of 128 Mb and 256 Mb respectively, the same as used by service.

svn commit: r1589384 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java

2014-04-23 Thread remm
Author: remm Date: Wed Apr 23 12:27:52 2014 New Revision: 1589384 URL: http://svn.apache.org/r1589384 Log: Do 10 requests even if the listener is complete, to check if everything is still fine after the handshake. Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java Modified:

RE: svn propchange: r1588102 - svn:log

2014-04-23 Thread Konstantin Preißer
Hi, > -Original Message- > From: Konstantin Kolinko [mailto:knst.koli...@gmail.com] > Sent: Tuesday, April 22, 2014 10:50 PM > > 2014-04-23 0:43 GMT+04:00 Mark Thomas : (snip) > > No objection to the final being restored, it is good practice to use > > final when possible. > > > > It is

svn commit: r1589390 - in /tomcat/tc6.0.x/trunk: STATUS.txt bin/service.bat webapps/docs/changelog.xml webapps/docs/tomcat-docs.xsl webapps/docs/windows-service-howto.xml

2014-04-23 Thread kkolinko
Author: kkolinko Date: Wed Apr 23 12:38:58 2014 New Revision: 1589390 URL: http://svn.apache.org/r1589390 Log: * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=56143 and http://issues.apache.org/bugzilla/show_bug.cgi?id=49993 Improve service.bat so that it can be launched from a non-UA

[Bug 56143] Allow "service.bat install" to be used in an non-UAC cmd.exe session

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56143 --- Comment #3 from Konstantin Kolinko --- Fixed in Tomcat 6 with r1589390 , will be in 6.0.40. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 49993] service.bat does not check for JAVA_HOME validity

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49993 --- Comment #3 from Konstantin Kolinko --- Fixed in Tomcat 6 with r1589390 , will be in 6.0.40. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 56383] Securing ErrorReportValve [PATCH]

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56383 --- Comment #4 from Nick Bunn --- Do i need to provide a patch for tomcat 6 and 8? -- You are receiving this mail because: You are the assignee for the bug. - To unsubsc

[Bug 56448] New: Implement a robust solution for client initiated SSL renegotiation with NIO

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56448 Bug ID: 56448 Summary: Implement a robust solution for client initiated SSL renegotiation with NIO Product: Tomcat 8 Version: trunk Hardware: All OS:

[Bug 56391] test error for NIO and org.apache.tomcat.util.net.TestSsl

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56391 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 56448] Implement a robust solution for client initiated SSL renegotiation with NIO

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56448 Petr Sumbera changed: What|Removed |Added CC||petr.sumb...@oracle.com -- You are

[Bug 56448] Implement a robust solution for client initiated SSL renegotiation with NIO

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56448 --- Comment #1 from Remy Maucherat --- I looked at it, but I am still quite lost about why it works or fails. I don't see how it could work with async IO (like Servlet 3.1). Even blocking IO could (possibly) be doing concurrent read / writ

[Bug 56026] RemoteEndpoint.Async#sendText(String, SendHandler) not thread safe

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56026 --- Comment #10 from Mark Thornton --- It may be worth noting that the Tyrus 1.5 implementation does appear to be thread safe. Even arbitrary mixtures of Basic and Async sends work as one might expect: all messages are delivered without err

[Bug 56026] RemoteEndpoint.Async#sendText(String, SendHandler) not thread safe

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56026 Mark Thornton changed: What|Removed |Added CC||mthorn...@optrak.com -- You are r

svn commit: r1589429 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-04-23 Thread fhanik
Author: fhanik Date: Wed Apr 23 14:31:14 2014 New Revision: 1589429 URL: http://svn.apache.org/r1589429 Log: Votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1589429&r1=1589428&r2

Reporting Tomcat version information to end user

2014-04-23 Thread Maarten van Hulsentop
Hello all, Looking at Tomcat bug 56383 - "Securing ErrorReportValve" ( https://issues.apache.org/bugzilla/show_bug.cgi?id=56383 ), i think a similar thing can also be done for the Tomcat version number reported by the DefaultServlet. This servlet will show the version information from ServerInfo w

[Bug 56026] RemoteEndpoint.Async#sendText(String, SendHandler) not thread safe

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56026 --- Comment #11 from Mark Thornton --- Some emails amongst the expert group doesn't constitute information of which users could be expected to be aware. Is this really the only place that the intent is described? -- You are receiving this

Re: NIO buffering

2014-04-23 Thread Filip Hanik
>I am not convinced by the NIO buffering that is used on output. what are you exactly referring to? Maybe I can shed some light on it. On Fri, Apr 18, 2014 at 1:30 PM, Rémy Maucherat wrote: > Hi, > > I am not convinced by the NIO buffering that is used on output. Due to > concurrent access iss

Re: NIO buffering

2014-04-23 Thread Rémy Maucherat
2014-04-23 16:50 GMT+02:00 Filip Hanik : > >I am not convinced by the NIO buffering that is used on output. > > what are you exactly referring to? Maybe I can shed some light on it. > Ok, so more precisely I was talking about the AbstractOutputBuffer.bufferedWrites field. Rémy > > > On Fri, Ap

[Bug 54596] Relative path functionality truncates last character of configuration parameters preventing connector from working.

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54596 --- Comment #3 from Thomas Hoffmann --- I have also encountered this problem. Testet with 1.2.40.0 of isapi_redirect.dll The relative paths are not taken into account. Line-breaks are CR+LF Neither \ nor / are working. Sample Config-File

Re: NIO buffering

2014-04-23 Thread Filip Hanik
Ok, Mark would know the exact details. It simply looks like a when a buffer has been flipped already, to simplify adding more bytes, add it to a new unflipped buffer, rather than append to existing one. So I don't think its about reuse, I think it may be to simplify the handling of buffer flipping.

[Bug 56449] New: WebSocket session get closed if in onOpen will sendText (sync mode)

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56449 Bug ID: 56449 Summary: WebSocket session get closed if in onOpen will sendText (sync mode) Product: Tomcat 8 Version: 8.0.5 Hardware: PC OS: Linux

Re: NIO buffering

2014-04-23 Thread Mark Thomas
On 23/04/2014 16:30, Filip Hanik wrote: > Ok, Mark would know the exact details. I'm not sure where you got that idea from, you introduced this code [1]. > It simply looks like a when a buffer > has been flipped already, to simplify adding more bytes, add it to a new > unflipped buffer, rather th

Re: NIO buffering

2014-04-23 Thread Rémy Maucherat
2014-04-23 18:30 GMT+02:00 Mark Thomas : > I'd agree with that assessment. > > I do remember having to be very careful with some of that code to get > things working correctly. If there is a cleaner solution then I'd be all > for it as long as performance is no worse. > > Mark > > [1] http://svn.a

[Bug 54596] Relative path functionality truncates last character of configuration parameters preventing connector from working.

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54596 --- Comment #4 from Christopher Schultz --- (In reply to Thomas Hoffmann from comment #3) > I have also encountered this problem. > Testet with 1.2.40.0 of isapi_redirect.dll > The relative paths are not taken into account. Line-breaks are

[Bug 56418] Manager incorrectly reports deployment as OK even though it failed

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56418 Sylvain Laurent changed: What|Removed |Added Attachment #31536|0 |1 is obsolete|

[Bug 53011] Ant Jasper task fails after one error

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53011 Marc Pompl changed: What|Removed |Added CC||marc.po...@lynorics.de -- You are re

[Bug 50234] JspC use servlet 3.0 features

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50234 Marc Pompl changed: What|Removed |Added CC||marc.po...@lynorics.de -- You are re

[Bug 50234] JspC use servlet 3.0 features

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50234 --- Comment #4 from Marc Pompl --- 4) abandon the requirement for web.xml if a web-fragment.xml is present At the moment (Tomcat 7), a dummy web.xml has to be defined in order to define the version (i.e. for expresions within the JSPs). --

svn commit: r1589513 - /tomcat/trunk/test/org/apache/tomcat/util/net/TesterSupport.java

2014-04-23 Thread markt
Author: markt Date: Wed Apr 23 20:40:00 2014 New Revision: 1589513 URL: http://svn.apache.org/r1589513 Log: Disable SSL renegotiation test for NIO Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TesterSupport.java Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TesterSupport.ja

svn commit: r1589521 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProcessor.java webapps/docs/changelog.xml

2014-04-23 Thread markt
Author: markt Date: Wed Apr 23 21:11:20 2014 New Revision: 1589521 URL: http://svn.apache.org/r1589521 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56348 Fix slow async reads on non-container thread. Align code with APR. Ensure that selector is woken up when a socket is registered f

[Bug 56348] ReadListener reading stream on different thread very slow

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56348 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 53492] Make JspC shell multithreaded

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53492 Marc Pompl changed: What|Removed |Added CC||marc.po...@lynorics.de -- You are re

[Bug 56449] WebSocket session get closed if in onOpen will sendText (sync mode)

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56449 --- Comment #1 from Mark Thomas --- At the moment, I don't see a code path that could trigger this. The session is open when it is created so something must be closing it very quickly. My assumption is that there must be an error path trigg

svn commit: r1589523 - in /tomcat/trunk/java/org/apache/tomcat/websocket: LocalStrings.properties WsSession.java

2014-04-23 Thread markt
Author: markt Date: Wed Apr 23 21:47:50 2014 New Revision: 1589523 URL: http://svn.apache.org/r1589523 Log: Add session ID to the exception message to aid debugging. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties tomcat/trunk/java/org/apache/tomcat/websock

[Bug 56449] WebSocket session get closed if in onOpen will sendText (sync mode)

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56449 --- Comment #2 from Konstantin Preißer --- Hi Mark, FYI, I can reproduce the given stack trace if I use a client that sends an initial Websocket Request but immediately closes the TCP connection. E.g., when running the following Java code

[Bug 56451] New: JNDI lookups under java:comp/Resources do not access resources

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56451 Bug ID: 56451 Summary: JNDI lookups under java:comp/Resources do not access resources Product: Tomcat 7 Version: 7.0.47 Hardware: PC OS: Linux

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2014-04-23 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. Th

[Bug 56449] WebSocket session get closed if in onOpen will sendText (sync mode)

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56449 --- Comment #3 from Mark Thomas --- Thanks for that. An immediate close was one of the options I considered but I dismissed it as I didn't think the close message could have been read that early. What i didn't consider was that the close o

svn commit: r1589598 - /tomcat/trunk/webapps/docs/changelog.xml

2014-04-23 Thread markt
Author: markt Date: Thu Apr 24 06:09:02 2014 New Revision: 1589598 URL: http://svn.apache.org/r1589598 Log: Whitespace police Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/chang

[Bug 53011] Ant Jasper task fails after one error

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53011 --- Comment #4 from Marc Pompl --- Created attachment 31555 --> https://issues.apache.org/bugzilla/attachment.cgi?id=31555&action=edit Patch to add an option "failFast" Appended is a patch that adds an option "failFast". Default is "fals

[Bug 53011] Ant Jasper task fails after one error

2014-04-23 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53011 --- Comment #5 from Marc Pompl --- (In reply to Marc Pompl from comment #4) > Patch to add an option "failFast" See corresponding issue for the maven-jspc-plugin https://github.com/Jasig/jspc-maven-plugin/issues/17 -- You are receiving t