svn commit: r1635429 - in /tomcat/trunk: java/org/apache/catalina/core/ApplicationPart.java webapps/docs/changelog.xml

2014-10-30 Thread remm
Author: remm Date: Thu Oct 30 08:37:01 2014 New Revision: 1635429 URL: http://svn.apache.org/r1635429 Log: Fileupload respects header ordering, but the part implementation doesn't. Also use a linked collection there to fix the discrepancy. Modified: tomcat/trunk/java/org/apache/catalina/core

svn commit: r1635431 - in /tomcat/trunk: java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2014-10-30 Thread remm
Author: remm Date: Thu Oct 30 08:42:17 2014 New Revision: 1635431 URL: http://svn.apache.org/r1635431 Log: Disable chunking when there's no keepalive (for example when the request specified connection close, which is detected). Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHtt

Re: svn commit: r1635431 - in /tomcat/trunk: java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2014-10-30 Thread Rémy Maucherat
2014-10-30 9:42 GMT+01:00 : > Author: remm > Date: Thu Oct 30 08:42:17 2014 > New Revision: 1635431 > > URL: http://svn.apache.org/r1635431 > Log: > Disable chunking when there's no keepalive (for example when the request > specified connection close, which is detected). > > IMO although chunking

Re: svn commit: r1635154 - in /tomcat/trunk: java/org/apache/tomcat/util/scan/StandardJarScanner.java test/org/apache/catalina/filters/TesterServletContext.java test/org/apache/tomcat/util/scan/TestSt

2014-10-30 Thread Mark Thomas
On 30/10/2014 00:33, Konstantin Kolinko wrote: > 2014-10-29 17:42 GMT+03:00 : >> Author: markt >> Date: Wed Oct 29 14:42:01 2014 >> New Revision: 1635154 >> >> URL: http://svn.apache.org/r1635154 >> Log: >> URLs may be added directly to the web application's class path. ensure that >> they are sc

svn commit: r1635440 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2014-10-30 Thread markt
Author: markt Date: Thu Oct 30 09:28:30 2014 New Revision: 1635440 URL: http://svn.apache.org/r1635440 Log: Update comment as a result of r1635431. Fix some formatting nits spotted while reviewing r1635431 Modified: tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java Modi

Re: svn commit: r1635431 - in /tomcat/trunk: java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2014-10-30 Thread Mark Thomas
On 30/10/2014 08:46, Rémy Maucherat wrote: > 2014-10-30 9:42 GMT+01:00 : > >> Author: remm >> Date: Thu Oct 30 08:42:17 2014 >> New Revision: 1635431 >> >> URL: http://svn.apache.org/r1635431 >> Log: >> Disable chunking when there's no keepalive (for example when the request >> specified connectio

svn commit: r1635444 - /tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

2014-10-30 Thread markt
Author: markt Date: Thu Oct 30 10:00:20 2014 New Revision: 1635444 URL: http://svn.apache.org/r1635444 Log: Use getters. No functional change. Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java Modified: tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarSc

svn commit: r1635449 - /tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java

2014-10-30 Thread markt
Author: markt Date: Thu Oct 30 10:11:02 2014 New Revision: 1635449 URL: http://svn.apache.org/r1635449 Log: Follow-up to r1635154. When scanning the class path, exclude WEB-INF/classes if it has already been scanned and exclude JARs from WEB-INF/lib that have been scanned. Modified: tomcat/t

svn commit: r1635456 - /tomcat/trunk/java/org/apache/jasper/servlet/TldScanner.java

2014-10-30 Thread markt
Author: markt Date: Thu Oct 30 10:27:44 2014 New Revision: 1635456 URL: http://svn.apache.org/r1635456 Log: Fix bug highlighted by test case failure after r1635154. If the webappPath is null, the resourcePath should be null. Also fix some Java8 Javadoc issues. Modified: tomcat/trunk/java/org

Re: svn commit: r1635154 - in /tomcat/trunk: java/org/apache/tomcat/util/scan/StandardJarScanner.java test/org/apache/catalina/filters/TesterServletContext.java test/org/apache/tomcat/util/scan/TestSt

2014-10-30 Thread Mark Thomas
On 30/10/2014 08:48, Mark Thomas wrote: > On 30/10/2014 00:33, Konstantin Kolinko wrote: >> 2014-10-29 17:42 GMT+03:00 : >>> Author: markt >>> Date: Wed Oct 29 14:42:01 2014 >>> New Revision: 1635154 >>> >>> URL: http://svn.apache.org/r1635154 >>> Log: >>> URLs may be added directly to the web app

svn commit: r1635460 - /tomcat/trunk/webapps/docs/changelog.xml

2014-10-30 Thread markt
Author: markt Date: Thu Oct 30 10:34:39 2014 New Revision: 1635460 URL: http://svn.apache.org/r1635460 Log: Update changelog Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/change

Re: svn commit: r1635431 - in /tomcat/trunk: java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2014-10-30 Thread Rémy Maucherat
2014-10-30 10:42 GMT+01:00 Mark Thomas : > Was it just the cost of the chunking that triggered this change or was > it something else? If it was performance, how much difference does this > change make? > Debugging something else, this turned out to not cause a failure, it was the reversed header

[jira] [Updated] (MTOMCAT-284) Add a skip parameter to deploy/redeploy/undeploy goals

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MTOMCAT-284: Attachment: MTOMCAT-284.patch Here is a patch that adds a skip parameter to the container g

[jira] [Created] (MTOMCAT-286) Integration test fails on Windows

2014-10-30 Thread Dennis Lundberg (JIRA)
Dennis Lundberg created MTOMCAT-286: --- Summary: Integration test fails on Windows Key: MTOMCAT-286 URL: https://issues.apache.org/jira/browse/MTOMCAT-286 Project: Apache Tomcat Maven Plugin

[jira] [Updated] (MTOMCAT-286) Integration test fails on Windows

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MTOMCAT-286: Attachment: MTOMCAT-286.patch Patch that fixes the problem in AbstractExecWarMojo. As far a

Re: svn commit: r1635431 - in /tomcat/trunk: java/org/apache/coyote/http11/AbstractHttp11Processor.java webapps/docs/changelog.xml

2014-10-30 Thread Mark Thomas
On 30/10/2014 12:20, Rémy Maucherat wrote: > 2014-10-30 10:42 GMT+01:00 Mark Thomas : > >> Was it just the cost of the chunking that triggered this change or was >> it something else? If it was performance, how much difference does this >> change make? >> > > Debugging something else, this turned

[jira] [Updated] (MTOMCAT-284) Add a skip parameter to deploy/redeploy/undeploy goals

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MTOMCAT-284: Fix Version/s: 2.3 Labels: patch (was: ) > Add a skip parameter to deploy/redep

[jira] [Updated] (MTOMCAT-286) Integration test fails on Windows

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MTOMCAT-286: Fix Version/s: 2.3 Labels: patch (was: ) > Integration test fails on Windows >

[jira] [Updated] (MTOMCAT-280) Allow running deploy-only and redeploy-only goals without pom file

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MTOMCAT-280: Attachment: MTOMCAT-280.patch Here is a proposed patch that adds the ability to specify the

[jira] [Commented] (MTOMCAT-277) ailed to execute goal org.apache.hadoop:hadoop-maven-plugins:2.4.1:protoc (compile-protoc) on project hadoop-common: org.apache.maven.plugin.MojoExecutionException: pr

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190159#comment-14190159 ] Dennis Lundberg commented on MTOMCAT-277: - How is this related to tomcat-maven-pl

[jira] [Updated] (MTOMCAT-280) Allow running deploy-only and redeploy-only goals without pom file

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MTOMCAT-280: Labels: patch (was: ) > Allow running deploy-only and redeploy-only goals without pom file

[jira] [Commented] (MTOMCAT-265) tomcatConfigurationFilesDirectory is not implemented

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190175#comment-14190175 ] Dennis Lundberg commented on MTOMCAT-265: - The cloned issue has been resolved as

[jira] [Commented] (MTOMCAT-262) tomcatConfigurationFilesDirectory not honoured

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190181#comment-14190181 ] Dennis Lundberg commented on MTOMCAT-262: - Checks for this was added in an integr

[jira] [Commented] (MTOMCAT-262) tomcatConfigurationFilesDirectory not honoured

2014-10-30 Thread jieryn (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190184#comment-14190184 ] jieryn commented on MTOMCAT-262: Thanks for adding those tests. I actually migrated to Ap

[jira] [Commented] (MTOMCAT-260) Bad default value for maven.tomcat.path

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190186#comment-14190186 ] Dennis Lundberg commented on MTOMCAT-260: - The class {{AbstractExecWarMojo}} over

[jira] [Resolved] (MTOMCAT-211) The .war file is not extracted from executable war

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved MTOMCAT-211. - Resolution: Fixed Fix Version/s: (was: 3.0) 2.3 > The .war

svn commit: r1635524 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ test/org/apache/coyote/http11/ webapps/docs/ webapps/docs/config/

2014-10-30 Thread markt
Author: markt Date: Thu Oct 30 15:45:21 2014 New Revision: 1635524 URL: http://svn.apache.org/r1635524 Log: Make the disabling of chunked encoding on connection close optional and disable by default since automatically disabling it causes a regression (see this discussion http://tomcat.markmail.

[jira] [Commented] (MTOMCAT-284) Add a skip parameter to deploy/redeploy/undeploy goals

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190279#comment-14190279 ] Dennis Lundberg commented on MTOMCAT-284: - This has apparently already been fixed

[jira] [Commented] (MTOMCAT-225) Documented deployment url returns 403 error

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190284#comment-14190284 ] Dennis Lundberg commented on MTOMCAT-225: - The text appears in two places: - The

[jira] [Closed] (MTOMCAT-225) Documented deployment url returns 403 error

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg closed MTOMCAT-225. --- Resolution: Fixed Fix Version/s: (was: moreinfo) 2.1 > Document

[jira] [Commented] (MTOMCAT-112) file path inside ${basedir}/src/main/tomcatconf is not preserved

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14190295#comment-14190295 ] Dennis Lundberg commented on MTOMCAT-112: - There is an IT for this in tomcat7-mav

[jira] [Updated] (MTOMCAT-284) Add a skip parameter to deploy/redeploy/undeploy goals

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MTOMCAT-284: Attachment: MTOMCAT-284-2.patch New patch that only touches tomcat6-maven-plugin, since tom

[jira] [Updated] (MTOMCAT-284) Add a skip parameter to deploy/redeploy/undeploy goals

2014-10-30 Thread Dennis Lundberg (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg updated MTOMCAT-284: Attachment: (was: MTOMCAT-284.patch) > Add a skip parameter to deploy/redeploy/undeploy

Tagging 7.0.57

2014-10-30 Thread Violeta Georgieva
Hi, I want to start preparing Tomcat 7.0.57. If you would like to add something to this release please reply here. Regards, Violeta

Re: svn commit: r1635524 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ test/org/apache/coyote/http11/ webapps/docs/ webapps/docs/config/

2014-10-30 Thread Rémy Maucherat
2014-10-30 16:45 GMT+01:00 : > Author: markt > Date: Thu Oct 30 15:45:21 2014 > New Revision: 1635524 > > URL: http://svn.apache.org/r1635524 > Log: > Make the disabling of chunked encoding on connection close optional and > disable by default since automatically disabling it causes a regression >

Re: svn commit: r1635524 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ test/org/apache/coyote/http11/ webapps/docs/ webapps/docs/config/

2014-10-30 Thread Mark Thomas
On 30/10/2014 18:57, Rémy Maucherat wrote: > 2014-10-30 16:45 GMT+01:00 : > >> Author: markt >> Date: Thu Oct 30 15:45:21 2014 >> New Revision: 1635524 >> >> URL: http://svn.apache.org/r1635524 >> Log: >> Make the disabling of chunked encoding on connection close optional and >> disable by default

Re: svn commit: r1635524 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ test/org/apache/coyote/http11/ webapps/docs/ webapps/docs/config/

2014-10-30 Thread Rémy Maucherat
2014-10-30 21:18 GMT+01:00 Mark Thomas : > > There should be no difference with the !connectionClosePresent as one of > > the flags is for connection: close in the request, the other one for > > connection: close in the response. And connection: close is added to the > > response if keepAlive is f

svn commit: r1635634 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java

2014-10-30 Thread olamy
Author: olamy Date: Thu Oct 30 22:55:31 2014 New Revision: 1635634 URL: http://svn.apache.org/r1635634 Log: [MTOMCAT-286] Integration test fails on Windows Submitted by Dennis Lundberg Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomc

svn commit: r1635635 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java

2014-10-30 Thread olamy
Author: olamy Date: Thu Oct 30 22:55:40 2014 New Revision: 1635635 URL: http://svn.apache.org/r1635635 Log: format Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/AbstractExecWarMojo.java Modified: tomcat/maven-plugin/trunk/

[jira] [Closed] (MTOMCAT-286) Integration test fails on Windows

2014-10-30 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-286. -- Resolution: Fixed applied Thanks! > Integration test fails on Windows > --

[jira] [Commented] (MTOMCAT-286) Integration test fails on Windows

2014-10-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191002#comment-14191002 ] Hudson commented on MTOMCAT-286: SUCCESS: Integrated in TomcatMavenPlugin-mvn3.x #286 (Se

[jira] [Commented] (MTOMCAT-286) Integration test fails on Windows

2014-10-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191010#comment-14191010 ] Hudson commented on MTOMCAT-286: FAILURE: Integrated in TomcatMavenPlugin-mvn3.x-windows

[jira] [Closed] (MTOMCAT-280) Allow running deploy-only and redeploy-only goals without pom file

2014-10-30 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-280. -- Resolution: Fixed Fix Version/s: 2.3 patch applied. Thanks! > Allow run

svn commit: r1635637 - in /tomcat/maven-plugin/trunk: tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/ tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomca

2014-10-30 Thread olamy
Author: olamy Date: Thu Oct 30 23:16:55 2014 New Revision: 1635637 URL: http://svn.apache.org/r1635637 Log: [MTOMCAT-280] Allow running deploy-only and redeploy-only goals without pom file Submitted by Dennis Lundberg Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org

[jira] [Commented] (MTOMCAT-280) Allow running deploy-only and redeploy-only goals without pom file

2014-10-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191025#comment-14191025 ] Hudson commented on MTOMCAT-280: FAILURE: Integrated in TomcatMavenPlugin-mvn3.x-windows

[jira] [Closed] (MTOMCAT-211) The .war file is not extracted from executable war

2014-10-30 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-211. -- > The .war file is not extracted from executable war >

[jira] [Commented] (MTOMCAT-280) Allow running deploy-only and redeploy-only goals without pom file

2014-10-30 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191032#comment-14191032 ] Hudson commented on MTOMCAT-280: SUCCESS: Integrated in TomcatMavenPlugin-mvn3.x #287 (Se

[jira] [Closed] (MTOMCAT-277) ailed to execute goal org.apache.hadoop:hadoop-maven-plugins:2.4.1:protoc (compile-protoc) on project hadoop-common: org.apache.maven.plugin.MojoExecutionException: proto

2014-10-30 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-277. -- Resolution: Not a Problem Assignee: Olivier Lamy (*$^¨%`£) > ailed to exe

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2014-10-30 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration. Th