svn commit: r1665244 - in /tomcat/trunk: test/org/apache/tomcat/util/net/jsse/openssl/TesterOpenSSL.java webapps/docs/config/http.xml

Author: markt Date: Mon Mar 9 14:10:57 2015 New Revision: 1665244 URL: http://svn.apache.org/r1665244 Log: Correct statement on ordering preferences. Add info on which OpenSSL branch the filtering tracks. Modified: tomcat/trunk/test/org/apache/tomcat/util/net/jsse/openssl/TesterOpenSSL.java

svn commit: r1665242 - /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/jsse/openssl/OpenSSLCipherConfigurationParser.java

Author: markt Date: Mon Mar 9 14:04:51 2015 New Revision: 1665242 URL: http://svn.apache.org/r1665242 Log: OpenSSL 1.0.2-dev includes EXPORT ciphers in COMPLEMENTOFDEFAULT Modified: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/jsse/openssl/OpenSSLCipherConfigurationParser.java

svn commit: r1665241 - /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/jsse/openssl/OpenSSLCipherConfigurationParser.java

Author: markt Date: Mon Mar 9 14:02:47 2015 New Revision: 1665241 URL: http://svn.apache.org/r1665241 Log: Read test results the wrong way around. OpenSSL 1.0.2-dev includes SSLv2 ciphers in COMPLEMENTOFDEFAULT Modified:

svn commit: r1665245 - in /tomcat/tc8.0.x/trunk: test/org/apache/tomcat/util/net/jsse/openssl/TesterOpenSSL.java webapps/docs/changelog.xml webapps/docs/config/http.xml

Author: markt Date: Mon Mar 9 14:14:33 2015 New Revision: 1665245 URL: http://svn.apache.org/r1665245 Log: Correct statement on ordering preferences. Add info on which OpenSSL branch the filtering tracks. Modified:

svn commit: r1665192 - /tomcat/tc7.0.x/trunk/build.xml

Author: rjung Date: Mon Mar 9 11:28:57 2015 New Revision: 1665192 URL: http://svn.apache.org/r1665192 Log: Try to fix gump build: Guess java 7 home from JAVA_HOME if java.7.home is not set. JAVA_HOME is only used, if the current JVM is at least java 7. This will not work correctly, if the

svn commit: r1665222 - /tomcat/trunk/java/org/apache/coyote/ajp/AjpProcessor.java

Author: markt Date: Mon Mar 9 12:59:05 2015 New Revision: 1665222 URL: http://svn.apache.org/r1665222 Log: Fix the 9.0.x version of BZ 57638. The assumption that a blocking read would fill the provided buffer was not valid. Modified:

[Bug 57532] Session expire message sent to cluster nodes even with DeltaSession configuration not to

https://bz.apache.org/bugzilla/show_bug.cgi?id=57532 --- Comment #6 from andrew jardine andrew.jard...@jardineworks.com --- Hey Mark, Sorry for the delay -- other priorities came up. I'm trying this again right now, though I think I tried that as well already. Could be though that I did not have

svn commit: r1665240 - /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/jsse/openssl/OpenSSLCipherConfigurationParser.java

Author: markt Date: Mon Mar 9 14:00:02 2015 New Revision: 1665240 URL: http://svn.apache.org/r1665240 Log: OpenSSL 1.0.2-dev now excludes SSLv2 ciphers from DEFAULT and COMPLEMENTOFDEFAULT Modified:

svn commit: r1665238 - /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/jsse/openssl/OpenSSLCipherConfigurationParser.java

Author: markt Date: Mon Mar 9 13:57:07 2015 New Revision: 1665238 URL: http://svn.apache.org/r1665238 Log: OpenSSL 1.0.2-dev now excludes export ciphers from DEFAULT Modified: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/net/jsse/openssl/OpenSSLCipherConfigurationParser.java Modified:

svn commit: r1665251 - /tomcat/tc8.0.x/trunk/java/org/apache/coyote/ajp/AjpNio2Processor.java

Author: markt Date: Mon Mar 9 14:44:43 2015 New Revision: 1665251 URL: http://svn.apache.org/r1665251 Log: Follow-up to r1665061 Correct fix for BZ57674 Modified: tomcat/tc8.0.x/trunk/java/org/apache/coyote/ajp/AjpNio2Processor.java Modified:

[Bug 57532] Session expire message sent to cluster nodes even with DeltaSession configuration not to

https://bz.apache.org/bugzilla/show_bug.cgi?id=57532 --- Comment #7 from andrew jardine andrew.jard...@jardineworks.com --- Hey Mark, UPDATE: I am seeing the same behaviour, even with the JvmRouteBinderValve. At first I enabled the jvmRoute, but that was problematic because, as previusly

Re: svn commit: r1665062 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/AjpNioProcessor.java test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java webapps/docs/changelog.xml

Mark, On 3/8/15 1:45 PM, ma...@apache.org wrote: Author: markt Date: Sun Mar 8 17:45:44 2015 New Revision: 1665062 URL: http://svn.apache.org/r1665062 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57674 Avoid a BufferOverflowException when an AJP response body chunk larger

[Bug 57674] BufferOverflowException in AjpNioProcessor when writing content larger than the underlying buffer

https://bz.apache.org/bugzilla/show_bug.cgi?id=57674 Christopher Schultz ch...@christopherschultz.net changed: What|Removed |Added Status|RESOLVED

svn commit: r1665296 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/server/LocalStrings.properties java/org/apache/tomcat/websocket/server/WsServerContainer.java webapps/docs/changelo

Author: schultz Date: Mon Mar 9 16:29:15 2015 New Revision: 1665296 URL: http://svn.apache.org/r1665296 Log: Back-port r1665292 to fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57676 - Report conflicting WebSocket endpoint classes when there is a path conflict. Modified:

svn commit: r1665252 - /tomcat/tc7.0.x/trunk/test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java

Author: markt Date: Mon Mar 9 14:48:06 2015 New Revision: 1665252 URL: http://svn.apache.org/r1665252 Log: Fix back-port error in unit test Modified: tomcat/tc7.0.x/trunk/test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java Modified:

Impossible branch in o.a.t.websocket.server.WsServerContainer.addEndpoint

All, I was looking at https://bz.apache.org/bugzilla/show_bug.cgi?id=57676 (a simple proposed patch to improve an error message) and I was trying to figure out what to do with a bit of code in addEndpoint. Reading the code, I think I've spotted a problem: [187] UriTemplate uriTemplate = new

svn commit: r1665292 - in /tomcat/trunk/java/org/apache/tomcat/websocket/server: LocalStrings.properties WsServerContainer.java

Author: schultz Date: Mon Mar 9 16:21:15 2015 New Revision: 1665292 URL: http://svn.apache.org/r1665292 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57676 Improve error message when multiple Websocket endpoints are bound to the same path. Modified:

[Bug 57674] BufferOverflowException in AjpNioProcessor when writing content larger than the underlying buffer

https://bz.apache.org/bugzilla/show_bug.cgi?id=57674 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

svn commit: r1665297 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java

Author: markt Date: Mon Mar 9 16:32:43 2015 New Revision: 1665297 URL: http://svn.apache.org/r1665297 Log: Follow up to r1665062 Callers assume that output() will fully write the data that is passed to it. Ensure that this is the case when the AJP message size is larger than the output buffer.

[Bug 57676] WebSocket check same path endpoint implementation enhancement

https://bz.apache.org/bugzilla/show_bug.cgi?id=57676 Christopher Schultz ch...@christopherschultz.net changed: What|Removed |Added Resolution|---

[Bug 57676] WebSocket check same path endpoint implementation enhancement

https://bz.apache.org/bugzilla/show_bug.cgi?id=57676 --- Comment #2 from Christopher Schultz ch...@christopherschultz.net --- Note that I do not intend to back-port this to Tomcat 7 unless someone requests it. -- You are receiving this mail because: You are the assignee for the bug.

Re: svn commit: r1665297 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java

On 9 March 2015 16:35:57 GMT+00:00, Christopher Schultz ch...@christopherschultz.net wrote: Mark, On 3/9/15 12:32 PM, ma...@apache.org wrote: Author: markt Date: Mon Mar 9 16:32:43 2015 New Revision: 1665297 URL: http://svn.apache.org/r1665297 Log: Follow up to r1665062 Callers assume

Re: svn commit: r1665297 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java

Mark, On 3/9/15 12:32 PM, ma...@apache.org wrote: Author: markt Date: Mon Mar 9 16:32:43 2015 New Revision: 1665297 URL: http://svn.apache.org/r1665297 Log: Follow up to r1665062 Callers assume that output() will fully write the data that is passed to it. Ensure that this is the case

[Bug 57674] BufferOverflowException in AjpNioProcessor when writing content larger than the underlying buffer

https://bz.apache.org/bugzilla/show_bug.cgi?id=57674 --- Comment #4 from Christopher Schultz ch...@christopherschultz.net --- This is looking much better. I was fortunate that I could reproduce this very easily in my application and we are humming-along quite smoothly, now. -- You are

[Bug 57674] BufferOverflowException in AjpNioProcessor when writing content larger than the underlying buffer

https://bz.apache.org/bugzilla/show_bug.cgi?id=57674 --- Comment #3 from Christopher Schultz ch...@christopherschultz.net --- Thanks for the fixes, Mark. I probably could have done these changes myself, but I wasn't sure of the implications of making changes in these areas. -- You are

[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name

https://bz.apache.org/bugzilla/show_bug.cgi?id=56530 --- Comment #13 from Mark Thomas ma...@apache.org --- No. It requires Java 7 and Tomcat 7 has to run on Java 6. -- You are receiving this mail because: You are the assignee for the bug.

Re: svn commit: r1665297 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java

Mark, On 3/9/15 4:26 PM, Mark Thomas wrote: On 09/03/2015 18:34, Christopher Schultz wrote: Mark, Glad to see it is working now. The next jobs are a) documenting the expected behavior re full vs partial write and b) take a look at trying to reduce the number of array copies (or equivalent)

[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name

https://bz.apache.org/bugzilla/show_bug.cgi?id=56530 --- Comment #14 from Christopher Schultz ch...@christopherschultz.net --- (In reply to Mark Thomas from comment #13) No. It requires Java 7 and Tomcat 7 has to run on Java 6. Could we wrap some of this capability in Jre7Compat.isSupported()?

Re: svn commit: r1665297 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java

On 09/03/2015 18:34, Christopher Schultz wrote: Mark, Glad to see it is working now. The next jobs are a) documenting the expected behavior re full vs partial write and b) take a look at trying to reduce the number of array copies (or equivalent) that the I/O codes does. I'm not sure it's

[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name

https://bz.apache.org/bugzilla/show_bug.cgi?id=56530 --- Comment #12 from kotur...@amazon.com kotur...@amazon.com --- Hi, is it possible to port this change to Tomcat 7 in /tomcat/tc7.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java ? -- You are receiving this mail because: You

Re: svn commit: r1665297 - /tomcat/tc7.0.x/trunk/java/org/apache/coyote/ajp/AjpNioProcessor.java

Mark, On 3/9/15 1:23 PM, Mark Thomas wrote: On 9 March 2015 16:35:57 GMT+00:00, Christopher Schultz ch...@christopherschultz.net wrote: Mark, On 3/9/15 12:32 PM, ma...@apache.org wrote: Author: markt Date: Mon Mar 9 16:32:43 2015 New Revision: 1665297 URL:

[Bug 57681] New: Allow parallel class loading in web application class loader by synchronizing on class specific object

https://bz.apache.org/bugzilla/show_bug.cgi?id=57681 Bug ID: 57681 Summary: Allow parallel class loading in web application class loader by synchronizing on class specific object Product: Tomcat 7 Version: trunk Hardware:

[Bug 57681] Allow parallel class loading in web application class loader by synchronizing on class specific object

https://bz.apache.org/bugzilla/show_bug.cgi?id=57681 --- Comment #2 from Mark Thomas ma...@apache.org --- And for the record the patch is nowhere close to correct. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 57681] Allow parallel class loading in web application class loader by synchronizing on class specific object

https://bz.apache.org/bugzilla/show_bug.cgi?id=57681 --- Comment #3 from Alex Koturanov kotur...@amazon.com --- The fix in bug 56530 is for Tomcat 8, not Tomcat 7. Why my request is marked as resolved? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 57681] Allow parallel class loading in web application class loader by synchronizing on class specific object

https://bz.apache.org/bugzilla/show_bug.cgi?id=57681 --- Comment #4 from Mark Thomas ma...@apache.org --- Because we don't have separate Bugzilla entries for exactly the same issue in different versions of Tomcat. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name

https://bz.apache.org/bugzilla/show_bug.cgi?id=56530 --- Comment #17 from Alex Koturanov kotur...@amazon.com --- Please consider not only the performance impact but also stability of web application. I am seeing 2-10 sec pauses for all requests in my web application caused by some bad code in

[Bug 57681] Allow parallel class loading in web application class loader by synchronizing on class specific object

https://bz.apache.org/bugzilla/show_bug.cgi?id=57681 Alex Koturanov kotur...@amazon.com changed: What|Removed |Added CC|

[Bug 57681] Allow parallel class loading in web application class loader by synchronizing on class specific object

https://bz.apache.org/bugzilla/show_bug.cgi?id=57681 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name

https://bz.apache.org/bugzilla/show_bug.cgi?id=56530 Mark Thomas ma...@apache.org changed: What|Removed |Added CC||kotur...@amazon.com ---

[Bug 56530] WebappClassLoader.loadClass synchronization issue due to coarse lock at WebappClassLoader instance level instead of been by class name

https://bz.apache.org/bugzilla/show_bug.cgi?id=56530 --- Comment #15 from Mark Thomas ma...@apache.org --- Oracle's public support has ended for Java 6 but other vendors may have different policies and if you pay Oracle $ you can still get support, updates etc. (and lots of companies do). Using

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150309-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed

-Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150309-native-src.tar.gz -Dtest.reports=output/logs-NIO -Dtomcat

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

-Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150309-native-src.tar.gz -Dtest.reports=output/logs-BIO -Dtomcat

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) failed

/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150309-native

[Bug 57676] WebSocket check same path endpoint implementation enhancement

https://bz.apache.org/bugzilla/show_bug.cgi?id=57676 Mark Thomas ma...@apache.org changed: What|Removed |Added OS||All

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150309-native-src.tar.gz -Dexamples.sources.skip=true

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150309-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar=/srv/gump

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar -Dtest.reports=output/logs-NIO2 -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150309-native-src.tar.gz -Dexamples.sources.skip=true -Djdt.jar

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150309-native-src.tar.gz -Dtest.reports=output/logs-APR -Dtomcat-native.tar.gz=/srv/gump/public/workspace

svn commit: r1665169 - in /tomcat/tc7.0.x/trunk: java/org/apache/jasper/servlet/JspCServletContext.java webapps/docs/changelog.xml

Author: markt Date: Mon Mar 9 10:00:59 2015 New Revision: 1665169 URL: http://svn.apache.org/r1665169 Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57643 Use new File(URI) to correctly convert between a file:// URL and an absolute path. Fixes JspC when getResource() returns an encoded

[Bug 57643] jasper ant task fails when there is a space in uriroot

https://bz.apache.org/bugzilla/show_bug.cgi?id=57643 Mark Thomas ma...@apache.org changed: What|Removed |Added Resolution|--- |FIXED

svn commit: r1665171 - /tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java

Author: markt Date: Mon Mar 9 10:04:57 2015 New Revision: 1665171 URL: http://svn.apache.org/r1665171 Log: Use new File(URI) to correctly convert between a file:// URL and an absolute path. Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java Modified:

svn commit: r1665172 - /tomcat/tc8.0.x/trunk/java/org/apache/jasper/servlet/JspCServletContext.java

Author: markt Date: Mon Mar 9 10:05:10 2015 New Revision: 1665172 URL: http://svn.apache.org/r1665172 Log: Use new File(URI) to correctly convert between a file:// URL and an absolute path. Modified: tomcat/tc8.0.x/trunk/java/org/apache/jasper/servlet/JspCServletContext.java Modified: