Author: markt
Date: Wed Jun 24 21:01:24 2015
New Revision: 1687369
URL: http://svn.apache.org/r1687369
Log:
Remove unnecessary code
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL:
Author: markt
Date: Wed Jun 24 20:26:17 2015
New Revision: 1687361
URL: http://svn.apache.org/r1687361
Log:
Fix typo
Modified:
tomcat/trunk/java/org/apache/coyote/http2/AbstractStream.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/AbstractStream.java
URL:
http://svn.apache.org/vie
Author: markt
Date: Wed Jun 24 19:45:46 2015
New Revision: 1687352
URL: http://svn.apache.org/r1687352
Log:
Add some more false positives
Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL:
http://svn.apache.org/
Author: markt
Date: Wed Jun 24 19:44:51 2015
New Revision: 1687351
URL: http://svn.apache.org/r1687351
Log:
Correct boundary condition
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL
Author: markt
Date: Wed Jun 24 19:37:02 2015
New Revision: 1687350
URL: http://svn.apache.org/r1687350
Log:
Fix logic
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL:
http://svn.apa
The Buildbot has detected a build exception on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/303
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranc
The Buildbot has detected a restored build on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/302
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranch
The Buildbot has detected a new failure on builder tomcat-7-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/689
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Author: markt
Date: Wed Jun 24 19:26:00 2015
New Revision: 1687349
URL: http://svn.apache.org/r1687349
Log:
Fix copy/paste error spotted by FindBugs
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/jaspic/PrincipalGroupCallback.java
Modified:
tomcat/trunk/java/org/apache/catal
Author: markt
Date: Wed Jun 24 19:10:57 2015
New Revision: 1687346
URL: http://svn.apache.org/r1687346
Log:
Fix FindBugs warnings. activeRemoteStreamCount wasn't thread safe.
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/c
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1454
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedu
Author: markt
Date: Wed Jun 24 18:45:59 2015
New Revision: 1687342
URL: http://svn.apache.org/r1687342
Log: (empty)
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
Propchange: tomcat/tc7.0.x/trunk/
--
Author: markt
Date: Wed Jun 24 18:45:20 2015
New Revision: 1687341
URL: http://svn.apache.org/r1687341
Log:
Fix FindBugs warning. Don't use != with Strings
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
Propchan
Author: markt
Date: Wed Jun 24 18:44:18 2015
New Revision: 1687340
URL: http://svn.apache.org/r1687340
Log:
Fix FindBugs warning. Don't use != with Strings
Modified:
tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
Modified: tomcat/trunk/java/org/apache/catalina/filters/Remo
https://bz.apache.org/bugzilla/show_bug.cgi?id=57546
--- Comment #14 from Mark Thomas ---
(In reply to Paul Gaylie from comment #13)
> Created attachment 32854 [details]
> Screen Shot from hprof
>
> Guys,
Please consider using a more gender neutral form of address when addressing the
Tomcat com
https://bz.apache.org/bugzilla/show_bug.cgi?id=57546
Paul Gaylie changed:
What|Removed |Added
CC||paul.gay...@gmail.com
--- Comment #13 fr
https://bz.apache.org/bugzilla/show_bug.cgi?id=57700
Violeta Georgieva changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
Author: violetagg
Date: Wed Jun 24 17:37:39 2015
New Revision: 1687334
URL: http://svn.apache.org/r1687334
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57700
Merged revision 1687268 from tomcat/trunk:
ADD_CHILD_EVENT must be sent even when there are failures during child's start,
thus
Author: violetagg
Date: Wed Jun 24 17:33:17 2015
New Revision: 1687333
URL: http://svn.apache.org/r1687333
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57700
Merged revision 1687268 from tomcat/trunk:
ADD_CHILD_EVENT must be sent even when there are failures during child's start,
thus
2015-06-24 18:37 GMT+03:00 Christopher Schultz :
>
> Mark,
>
> On 6/24/15 9:57 AM, Mark Thomas wrote:
> > On 24/06/2015 14:43, Violeta Georgieva wrote:
> >> Hi Mark,
> >>
> >> 2015-06-24 16:27 GMT+03:00 :
> >>>
> >>> https://bz.apache.org/bugzilla/show_bug.cgi?id=58031
> >>>
> >>> --- Comment #10 f
Mark,
On 6/24/15 9:57 AM, Mark Thomas wrote:
> On 24/06/2015 14:43, Violeta Georgieva wrote:
>> Hi Mark,
>>
>> 2015-06-24 16:27 GMT+03:00 :
>>>
>>> https://bz.apache.org/bugzilla/show_bug.cgi?id=58031
>>>
>>> --- Comment #10 from Mark Thomas ---
>>> I've patched trunk (9.0.x) to make the reason f
Violeta,
On 6/24/15 2:34 AM, Violeta Georgieva wrote:
> Hi,
>
> 2015-06-23 20:53 GMT+03:00 Christopher Schultz > :
>>
>> All,
>>
>> Some recent bugs have been fixed and there is some community demand for
>> 7.0.63.
>>
>> e.g.
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=57783
>>
>> Violetta,
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1453
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Author: markt
Date: Wed Jun 24 14:15:32 2015
New Revision: 1687292
URL: http://svn.apache.org/r1687292
Log:
Correct error code
Modified:
tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettings.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/ConnectionSettings.java
URL:
http://
https://bz.apache.org/bugzilla/show_bug.cgi?id=58074
--- Comment #2 from qed...@gmail.com ---
(In reply to Mark Thomas from comment #1)
> A profiler confirms that there is no memory leak here. weak references !=
> memory leaks. GC will clear them as/if necessary to relieve memory pressure.
I must
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1452
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedu
On 24/06/2015 14:43, Violeta Georgieva wrote:
> Hi Mark,
>
> 2015-06-24 16:27 GMT+03:00 :
>>
>> https://bz.apache.org/bugzilla/show_bug.cgi?id=58031
>>
>> --- Comment #10 from Mark Thomas ---
>> I've patched trunk (9.0.x) to make the reason for the failure available
> as a
>> request attribute th
Author: markt
Date: Wed Jun 24 13:55:44 2015
New Revision: 1687278
URL: http://svn.apache.org/r1687278
Log:
Make writing the settings frame unit tests easier.
Modified:
tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_
Hi Mark,
2015-06-24 16:27 GMT+03:00 :
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=58031
>
> --- Comment #10 from Mark Thomas ---
> I've patched trunk (9.0.x) to make the reason for the failure available
as a
> request attribute that the FailedRequestFilter can then use to provide a
better
Author: violetagg
Date: Wed Jun 24 13:40:34 2015
New Revision: 1687268
URL: http://svn.apache.org/r1687268
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57700
ADD_CHILD_EVENT must be sent even when there are failures during child's start,
thus MapperListener will be added as Container/L
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1450
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
https://bz.apache.org/bugzilla/show_bug.cgi?id=58031
--- Comment #10 from Mark Thomas ---
I've patched trunk (9.0.x) to make the reason for the failure available as a
request attribute that the FailedRequestFilter can then use to provide a better
status code to the client.
I'll give it a few day
Author: markt
Date: Wed Jun 24 13:26:06 2015
New Revision: 1687261
URL: http://svn.apache.org/r1687261
Log:
Make the (first) reason parameter parsing failed available as a request
attribute and then use it to provide a better status code via the
FailedRequstFilter (if configured).
Modified:
https://bz.apache.org/bugzilla/show_bug.cgi?id=57700
--- Comment #8 from Remy Maucherat ---
Would be fine then, but +1 for the finally.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe
https://bz.apache.org/bugzilla/show_bug.cgi?id=57700
--- Comment #7 from Violeta Georgieva ---
(In reply to Mark Thomas from comment #5)
> I'm wary of changing the order since it might break something else. How about
> a
> finally block?
+1
(In reply to Remy Maucherat from comment #6)
> I agre
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1449
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedu
https://bz.apache.org/bugzilla/show_bug.cgi?id=57700
--- Comment #6 from Remy Maucherat ---
I agree it will have side effects, like maybe mapping requests while the
context is being deployed ? A finally seems better but even that would still
change the current behavior (previously requests would
https://bz.apache.org/bugzilla/show_bug.cgi?id=58052
--- Comment #5 from Remy Maucherat ---
I have documented explicitly the difference with the current mod_rewrite in
that area.
--
You are receiving this mail because:
You are the assignee for the bug.
-
Author: remm
Date: Wed Jun 24 12:34:07 2015
New Revision: 1687251
URL: http://svn.apache.org/r1687251
Log:
Port 58052: Clarify that some newer additions from the mod_rewrite
documentation are not supported in Tomcat.
Modified:
tomcat/tc8.0.x/trunk/webapps/docs/rewrite.xml
Modified: tomcat/t
Author: remm
Date: Wed Jun 24 12:33:24 2015
New Revision: 1687250
URL: http://svn.apache.org/r1687250
Log:
58052: Clarify that some newer additions from the mod_rewrite documentation are
not supported in Tomcat.
Modified:
tomcat/trunk/webapps/docs/rewrite.xml
Modified: tomcat/trunk/webapps/
https://bz.apache.org/bugzilla/show_bug.cgi?id=57700
--- Comment #5 from Mark Thomas ---
I'm wary of changing the order since it might break something else. How about a
finally block?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57700
--- Comment #4 from Violeta Georgieva ---
Hi,
I succeeded to reproduce the scenario on all Tomcat versions.
The issue is the following:
- The implementation of Manager web app invokes HostConfig to deploy the web
application.
...
at org.a
The Buildbot has detected a build exception on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1448
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSc
Author: markt
Date: Wed Jun 24 11:58:57 2015
New Revision: 1687242
URL: http://svn.apache.org/r1687242
Log:
Differentiate between failure modes. Handling is currently identical but it
won't be once BZ 58031 is addressed.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
https://bz.apache.org/bugzilla/show_bug.cgi?id=58074
Mark Thomas changed:
What|Removed |Added
Resolution|--- |INVALID
Status|NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=58074
Bug ID: 58074
Summary: Memory leak - session serialization
Product: Tomcat 7
Version: 7.0.62
Hardware: PC
Status: NEW
Severity: minor
Priority: P2
Co
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1446
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Author: markt
Date: Wed Jun 24 08:02:34 2015
New Revision: 1687193
URL: http://svn.apache.org/r1687193
Log:
Add unit tests for rst frames
Added:
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_4.java (with
props)
Added: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Secti
Author: markt
Date: Wed Jun 24 07:53:55 2015
New Revision: 1687184
URL: http://svn.apache.org/r1687184
Log:
Use constants
Modified:
tomcat/trunk/test/org/apache/coyote/http2/Http2TestBase.java
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_2.java
Modified: tomcat/trunk/test
Author: markt
Date: Wed Jun 24 07:53:20 2015
New Revision: 1687183
URL: http://svn.apache.org/r1687183
Log:
Add unit tests for priority frames
Added:
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_6_3.java (with
props)
Added: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2
50 matches
Mail list logo
