RE: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Filip Hanik
Hi Romain, > -Original Message- > From: Romain Manni-Bucau > Sent: Wednesday, July 22, 2020 12:48 PM > To: Tomcat Developers List > Subject: Re: [tomcat] branch master updated: Simpler way to determine Graal > runtime > > Thinking out loud: cant you substitute it to be hardcoded to

[GitHub] [tomcat-maven-plugin] karlvr commented on a change in pull request #30: Tc9.x Initial suport for Tomact9

2020-07-22 Thread GitBox
karlvr commented on a change in pull request #30: URL: https://github.com/apache/tomcat-maven-plugin/pull/30#discussion_r459138051 ## File path: tomcat9-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat9/run/RunMojo.java ## @@ -479,18 +480,23 @@ private

Re: Jakarta EE APIs

2020-07-22 Thread Martin Grigorov
On Wed, Jul 22, 2020, 18:10 Mark Thomas wrote: > Hi all, > > We currently have implementations for all of the Jakarta APIs that ship > with Tomcat and partial implementations for 5 additional Jakarta APIs that > are compile time only dependencies. > > I was checking those partial implementations

Re: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Filip Hanik
Good idea, I’ll add that as a separate commit. On Wed, Jul 22, 2020 at 13:08 Rémy Maucherat wrote: > On Wed, Jul 22, 2020 at 8:17 PM Filip Hanik wrote: > >> Thanks Remy, >> >> >> >> I ran into some failures when running the test suite using the substrate >> VM, but it makes more sense to

Re: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Rémy Maucherat
On Wed, Jul 22, 2020 at 8:17 PM Filip Hanik wrote: > Thanks Remy, > > > > I ran into some failures when running the test suite using the substrate > VM, but it makes more sense to adjust those tests. > > I’ll revert these today > I think you should leave the additional check for the system

Re: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Romain Manni-Bucau
Thinking out loud: cant you substitute it to be hardcoded to true in native mode? This way you get the best of both. Le mer. 22 juil. 2020 à 20:17, Filip Hanik a écrit : > Thanks Remy, > > > > I ran into some failures when running the test suite using the substrate > VM, but it makes more sense

[tomcat] branch master updated: Revert "Simpler way to determine Graal runtime"

2020-07-22 Thread fhanik
This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new cb5eaa3 Revert "Simpler way to determine Graal

[tomcat] branch 9.0.x updated: Revert "Simpler way to determine Graal runtime"

2020-07-22 Thread fhanik
This is an automated email from the ASF dual-hosted git repository. fhanik pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 87cbed1 Revert "Simpler way to determine Graal

Re: Jakarta EE APIs

2020-07-22 Thread Rémy Maucherat
On Wed, Jul 22, 2020 at 5:10 PM Mark Thomas wrote: > Hi all, > > We currently have implementations for all of the Jakarta APIs that ship > with Tomcat and partial implementations for 5 additional Jakarta APIs that > are compile time only dependencies. > > I was checking those partial

RE: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Filip Hanik
Thanks Remy, I ran into some failures when running the test suite using the substrate VM, but it makes more sense to adjust those tests. I’ll revert these today Filip From: Rémy Maucherat Sent: Wednesday, July 22, 2020 12:10 AM To: Tomcat Developers List Subject: Re: [tomcat] branch master

Re: Jakarta EE APIs

2020-07-22 Thread Romain Manni-Bucau
Le mer. 22 juil. 2020 à 18:29, Mark Thomas a écrit : > On 22/07/2020 17:11, Romain Manni-Bucau wrote: > > Hi Mark, > > > > Another option is to use Apache Geronimo specs (and update/create > > missing ones - think new mail one is not yet there for ex). > > This is a distinct disadvantage. > You

RE: [tomcat] branch master updated: Avoid reflection for default instantiation

2020-07-22 Thread Filip Hanik
Hi Christopher, > > environments. -Class clazz = > > Class.forName(className); -return > > (AuthConfigFactory) clazz.getConstructor().newInstance(); + if > > (className.equals("org.apache.catalina.authenticator.jaspic.AuthConfig >

Re: Jakarta EE APIs

2020-07-22 Thread Mark Thomas
On 22/07/2020 17:11, Romain Manni-Bucau wrote: > Hi Mark, > > Another option is to use Apache Geronimo specs (and update/create > missing ones - think new mail one is not yet there for ex). This is a distinct disadvantage. > Advantage would be we wouldn't lose all the work around OSGi and jpms

Re: JAX-RPC and Tomcat 10

2020-07-22 Thread Mark Thomas
On 21/07/2020 14:44, Romain Manni-Bucau wrote: > Yes, was thinking to tomee in particular since it does not use tomcat as > a lib but really as the container so if the container fails then it can > become hard if not "disabl-able" somehow (at least with subclassing or > something programmatic). I

Re: Jakarta EE APIs

2020-07-22 Thread Romain Manni-Bucau
Hi Mark, Another option is to use Apache Geronimo specs (and update/create missing ones - think new mail one is not yet there for ex). Advantage would be we wouldn't lose all the work around OSGi and jpms eclipse does not - and will not probably - handle (at least for the first part). It also

Re: Jakarta EE APIs

2020-07-22 Thread Mark Thomas
On 22/07/2020 15:53, Mark Thomas wrote: > Hi all, > > We currently have implementations for all of the Jakarta APIs that ship with > Tomcat and partial implementations for 5 additional Jakarta APIs that are > compile time only dependencies. > > I was checking those partial implementations

Re: [tomcat] branch master updated: Avoid reflection for default instantiation

2020-07-22 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Filip, On 7/21/20 11:22, fha...@apache.org wrote: > This is an automated email from the ASF dual-hosted git > repository. > > fhanik pushed a commit to branch master in repository > https://gitbox.apache.org/repos/asf/tomcat.git > > > The following

Jakarta EE APIs

2020-07-22 Thread Mark Thomas
Hi all, We currently have implementations for all of the Jakarta APIs that ship with Tomcat and partial implementations for 5 additional Jakarta APIs that are compile time only dependencies. I was checking those partial implementations earlier today when I noticed the Jakarta Mail API needed

[Bug 64614] tomcat doesn't work with JSSE FIPS-compliant with NSS

2020-07-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64614 --- Comment #12 from Christopher Schultz --- Aren't we just "always wrapping" because it was simpler than only wrapping when necessary? Why don't we "only" wrap when we must? I think the wrapper is only for certain scenarios. Why not detect

[Bug 64619] Regression: Removal of scratchdir fallback affects existing code

2020-07-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64619 --- Comment #3 from Markus Schlegel --- Thanks for the clarification. I can understand your demand for having the codebase of the maintenance branches somewhat in sync. Since the checkin was not associated with a issue, I thought that it was

[tomcat] branch master updated: Complete javax -> jakarta rename.

2020-07-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new f5efdad Complete javax -> jakarta rename.

[tomcat] branch master updated: Remove the javax.transaction.xa package. It is provided by the JRE.

2020-07-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 500d21d Remove the javax.transaction.xa

[tomcat] branch 9.0.x updated: Remove the javax.transaction.xa package. It is provided by the JRE.

2020-07-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9018af8 Remove the javax.transaction.xa package.

[Bug 64619] Regression: Removal of scratchdir fallback affects existing code

2020-07-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64619 --- Comment #2 from Mark Thomas --- The Tomcat code base being the age and size it is, it isn't uncommon to come across cruft while researching other issues. The decision when and how to remove such cruft is always going to be taken on a case

Re: [tomcat] 02/02: Avoid reflection for default instantiation

2020-07-22 Thread Martin Grigorov
Hi, On Wed, Jul 22, 2020 at 2:18 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > fhanik pushed a commit to branch 9.0.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit f4dac6846c548144799b1c3f33aba4eb320a3413 > Author: Filip Hanik >

Re: Jakarta EE - JASPIC TCK (nightly)

2020-07-22 Thread Jean-Louis MONTEIRO
Hi, Small update on the progress. Passed: 52 and Failed: 9 I had a lot of random passed/failed for quite a while and finally found the reason yesterday. I'd be interested in having some thoughts AuthenticatorBase uses by default CallbackHandlerImpl The CallbackHandlerImpl will create the

[Bug 64619] Regression: Removal of scratchdir fallback affects existing code

2020-07-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64619 mgrigorov changed: What|Removed |Added OS||All --- Comment #1 from mgrigorov ---

[Bug 64619] New: Regression: Removal of scratchdir fallback affects existing code

2020-07-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64619 Bug ID: 64619 Summary: Regression: Removal of scratchdir fallback affects existing code Product: Tomcat 8 Version: 8.5.57 Hardware: PC Status: NEW

[tomcat] branch 9.0.x updated: Add code generation for TLD rules

2020-07-22 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 9c4b131 Add code generation for TLD rules 9c4b131

[tomcat] branch master updated: Add code generation for TLD rules

2020-07-22 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new d467154 Add code generation for TLD rules

Re: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Rémy Maucherat
On Tue, Jul 21, 2020 at 11:16 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > fhanik pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >