michael-o commented on pull request #337:
URL: https://github.com/apache/tomcat/pull/337#issuecomment-672641726
The entire ETag handling requires an overhaul.
This is an automated message from the Apache Git Service.
To respo
malaysf commented on pull request #332:
URL: https://github.com/apache/tomcat/pull/332#issuecomment-672635038
@michael-o Can you please review the updates? I believe I've addressed your
comments. Thanks!
This is an automated
Chris,
On Mon, Aug 10, 2020 at 12:20 PM Martin Grigorov
wrote:
>
> On Tue, Jul 28, 2020, 16:48 Christopher Schultz <
> ch...@christopherschultz.net> wrote:
>
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA256
>>
>> All,
>>
>> I was looking at this PR[1] and wondering why we have huge swaths o
stokito opened a new pull request #337:
URL: https://github.com/apache/tomcat/pull/337
In the scope of bef507e1b7ac2eb0ff012d0d40035e218a5839cc was added a bug:
```
curl -vv http://localhost:8080/tomcat.png -H 'If-None-Match:
W/"5103-159588774"'
> GET /tomcat.png HTTP/1.1
Am 2020-08-11 um 21:04 schrieb Mark Thomas:
On 11/08/2020 17:30, Michael Osipov wrote:
Am 2020-08-10 um 17:46 schrieb Mark Thomas:
Hi all,
I'd like to propose removing all the functional spec pages from the
documentation web application.
+1
Can you list them specifically? I am a bit lost
On 11/08/2020 17:30, Michael Osipov wrote:
> Am 2020-08-10 um 17:46 schrieb Mark Thomas:
>> Hi all,
>>
>> I'd like to propose removing all the functional spec pages from the
>> documentation web application.
> +1
>
> Can you list them specifically? I am a bit lost which you exactly mean.
Every
https://bz.apache.org/bugzilla/show_bug.cgi?id=64645
--- Comment #3 from Mark Thomas ---
For clarity, the only change required here is that the exit code should be
non-zero. The validation of JAVA_HOME and JAVA_HOME vs JRE_HOME is sufficient.
--
You are receiving this mail because:
You are the
kamnani commented on pull request #331:
URL: https://github.com/apache/tomcat/pull/331#issuecomment-672153051
@ChristopherSchultz Are there any updates on this ?
This is an automated message from the Apache Git Service.
To
On 11/08/2020 18:06, Michael Osipov wrote:
> Am 2020-08-11 um 18:53 schrieb Mark Thomas:
>> On 11/08/2020 17:29, Michael Osipov wrote:
>>> Am 2020-08-11 um 16:52 schrieb ma...@apache.org:
>>
>>
>>
commit bef507e1b7ac2eb0ff012d0d40035e218a5839cc
Author: Mark Thomas
AuthorDate: Tue A
Am 2020-08-11 um 18:53 schrieb Mark Thomas:
On 11/08/2020 17:29, Michael Osipov wrote:
Am 2020-08-11 um 16:52 schrieb ma...@apache.org:
commit bef507e1b7ac2eb0ff012d0d40035e218a5839cc
Author: Mark Thomas
AuthorDate: Tue Aug 11 15:27:45 2020 +0100
Improve entity tag handling
@@
On 11/08/2020 17:29, Michael Osipov wrote:
> Am 2020-08-11 um 16:52 schrieb ma...@apache.org:
>> commit bef507e1b7ac2eb0ff012d0d40035e218a5839cc
>> Author: Mark Thomas
>> AuthorDate: Tue Aug 11 15:27:45 2020 +0100
>>
>> Improve entity tag handling
>> @@ -279,6 +280,8 @@ public class Def
The Buildbot has detected a restored build on builder tomcat-9-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-9-trunk/builds/360
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchSchedu
The Buildbot has detected a restored build on builder tomcat-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/5334
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchScheduler
markt-asf commented on pull request #330:
URL: https://github.com/apache/tomcat/pull/330#issuecomment-672078710
There needs to be a *really* good reason to essentially introduce a Tomcat
specific extension to the Jakarta WebSocket specification and thie PR hasn't
(yet) provided such a just
Am 2020-08-11 um 16:52 schrieb ma...@apache.org:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
n
Am 2020-08-10 um 17:46 schrieb Mark Thomas:
Hi all,
I'd like to propose removing all the functional spec pages from the
documentation web application.
My reasoning for this proposal is, in short, that we aren't using or
maintaining these pages.
I don't recall any discussion of these docs on th
markt-asf commented on pull request #304:
URL: https://github.com/apache/tomcat/pull/304#issuecomment-672066549
Closing as this PR cannot be applied as-is. Anyone interested in following
through on this should start a discussion on the dev list as per my previous
comment.
---
markt-asf closed pull request #304:
URL: https://github.com/apache/tomcat/pull/304
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new 6f96d40 Fix indentation of versionLoggerListener.*
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 4b36bc7 Fix indentation of versionLoggerListener.*
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new beee990 Fix indentation of versionLoggerListener.*
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 7110da9 Update changelog
7110da9 is described be
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new e6afc85 Fix indentation of versionLoggerListener
markt-asf merged pull request #328:
URL: https://github.com/apache/tomcat/pull/328
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new 005d790 Add missing Javadoc
005d790 is described b
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new b50d633 Add missing Javadoc
b50d633 is described b
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new cfd498e Add missing Javadoc
cfd498e is described b
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 7aec7a7 Add missing Javadoc
7aec7a7 is described
The Buildbot has detected a new failure on builder tomcat-7-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-7-trunk/builds/1746
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchSchedule
The Buildbot has detected a new failure on builder tomcat-9-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-9-trunk/builds/359
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchScheduler
The Buildbot has detected a new failure on builder tomcat-trunk while building
tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/5333
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchScheduler sc
markt-asf closed pull request #325:
URL: https://github.com/apache/tomcat/pull/325
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
markt-asf commented on pull request #325:
URL: https://github.com/apache/tomcat/pull/325#issuecomment-672005180
Simplifying the matching is the wrong approach. The matching needs to be
tightened up to be more spec compliant. A change to that effect has now been
implemented.
-
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new 52e2b0a Improve entity tag handling
52e2b0a is des
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new cd0dc59 Improve entity tag handling
cd0dc59 is des
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 1960471 Improve entity tag handling
1960471 is des
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new bef507e Improve entity tag handling
bef507e is d
+1
On Mon, Aug 10, 2020 at 08:46 Mark Thomas wrote:
> Hi all,
>
> I'd like to propose removing all the functional spec pages from the
> documentation web application.
>
> My reasoning for this proposal is, in short, that we aren't using or
> maintaining these pages.
>
> I don't recall any discus
On Mon, Aug 10, 2020 at 6:46 PM Mark Thomas wrote:
> Hi all,
>
> I'd like to propose removing all the functional spec pages from the
> documentation web application.
>
> My reasoning for this proposal is, in short, that we aren't using or
> maintaining these pages.
>
> I don't recall any discussi
https://bz.apache.org/bugzilla/show_bug.cgi?id=64660
--- Comment #1 from mgrigorov ---
The problem is that "socketWrapper" is null at
https://github.com/apache/tomcat/blob/9.0.x/java/org/apache/tomcat/util/net/AprEndpoint.java#L725
SocketWrapperBase socketWrapper = connections.get(Long.valueOf(
https://bz.apache.org/bugzilla/show_bug.cgi?id=64628
--- Comment #4 from Gavin.peng ---
Thanks Mark Thomas 's help ,the cache size exceed shown in the attachment is
tomcat6,the default cache size is -1 in tomcat6,so has many request processor
cached
the tomcat7/8/9 the default cache is is 200,m
markt-asf commented on a change in pull request #325:
URL: https://github.com/apache/tomcat/pull/325#discussion_r468504398
##
File path: java/org/apache/catalina/servlets/DefaultServlet.java
##
@@ -2611,6 +2574,44 @@ private PrecompressedResource(WebResource resource,
Compress
42 matches
Mail list logo
