Re: svn commit: r1642307 - in /tomcat/trunk: java/org/apache/tomcat/websocket/CaseInsensitiveKeyMap.java test/org/apache/tomcat/websocket/TestCaseInsensitiveKeyMap.java

2014-11-28 Thread Martin Grigorov
Hi, Performance wise isn't it better to transform the String key to lowerCase at Key construction time and later use it in equals/hashCode ? Now the lower-ification would happen for most Map operation. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Fri, N

Re: [VOTE] Release Apache Tomcat 8.0.15

2014-11-04 Thread Martin Grigorov
[X] Stable - go ahead and release as 8.0.15 Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Nov 4, 2014 at 3:54 PM, Rémy Maucherat wrote: > 2014-11-03 10:51 GMT+01:00 Mark Thomas : > > > The proposed 8.0.15 release is: > > [ ] Broke

Re: Summary: Migration from svn to git

2014-10-16 Thread Martin Grigorov
Hi, On Thu, Oct 16, 2014 at 9:38 PM, Konstantin Kolinko wrote: > Just several technical notes, > > > If anyone wants to comment on Github, I think that it is already > possible. I think that it works and the messages are forwarded to the > dev list. > > Unfortunately this is not true. At the mo

Re: svn commit: r1630065 - in /tomcat/trunk: java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/ webapps/docs/

2014-10-08 Thread Martin Grigorov
On Wed, Oct 8, 2014 at 1:02 PM, Mark Thomas wrote: > On 08/10/2014 11:41, Martin Grigorov wrote: > > It really helps if you are going to comment on a small part of a large > commit if you trim the irrelevant parts of the original in your reply. > I'll try to remember for

Re: svn commit: r1630065 - in /tomcat/trunk: java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/ webapps/docs/

2014-10-08 Thread Martin Grigorov
Hi, On Wed, Oct 8, 2014 at 12:38 PM, wrote: > Author: markt > Date: Wed Oct 8 10:38:33 2014 > New Revision: 1630065 > > URL: http://svn.apache.org/r1630065 > Log: > Extend support for permessage-deflate to the WebSocket client > implementation. > > Modified: > tomcat/trunk/java/org/apache/t

Re: svn commit: r1628984 - in /tomcat/trunk/webapps/docs: changelog.xml config/engine.xml

2014-10-02 Thread Martin Grigorov
On Thu, Oct 2, 2014 at 9:14 PM, Christopher Schultz < ch...@christopherschultz.net> wrote: > Mark, > > On 10/2/14 10:54 AM, Mark Thomas wrote: > > On 02/10/2014 15:41, Martin Grigorov wrote: > >> Hi, > >> > >> On Thu, Oct 2, 2014 at 4:36 PM, wrote

Re: svn commit: r1628984 - in /tomcat/trunk/webapps/docs: changelog.xml config/engine.xml

2014-10-02 Thread Martin Grigorov
Hi, On Thu, Oct 2, 2014 at 4:36 PM, wrote: > Author: schultz > Date: Thu Oct 2 14:36:27 2014 > New Revision: 1628984 > > URL: http://svn.apache.org/r1628984 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57049 > Clarified that jvmRoute can be set using Engine.jvmRoute or a syst

Re: [VOTE] Release Apache Tomcat 8.0.14

2014-09-25 Thread Martin Grigorov
[ X ] Stable - go ahead and release as 8.0.14 Tested Apache Wicket impl for JSR 356 with the tar.gz bundle. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Wed, Sep 24, 2014 at 11:07 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.14 release is

Re: svn commit: r1622434 - /tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java

2014-09-04 Thread Martin Grigorov
On Thu, Sep 4, 2014 at 12:42 PM, wrote: > Author: markt > Date: Thu Sep 4 09:42:04 2014 > New Revision: 1622434 > > URL: http://svn.apache.org/r1622434 > Log: > Fix corrupted characters. > > Modified: > tomcat/trunk/test/org/apache/catalina/connector/TestRequest.java > > Modified: tomcat/tru

Re: svn commit: r1622302 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Request.java test/org/apache/catalina/connector/TestRequest.java test/org/apache/catalina/connector/TesterReq

2014-09-04 Thread Martin Grigorov
Hi, On Wed, Sep 3, 2014 at 8:37 PM, wrote: > Author: markt > Date: Wed Sep 3 17:37:51 2014 > New Revision: 1622302 > > URL: http://svn.apache.org/r1622302 > Log: > Correctly handle multiple accept-language headers rather than just using > the first header to determine the user's preferred Local

Re: git (yet again)

2014-09-03 Thread Martin Grigorov
On Thu, Sep 4, 2014 at 12:46 AM, sebb wrote: > On 3 September 2014 16:10, Martin Grigorov wrote: > > On Wed, Sep 3, 2014 at 2:54 PM, Stefan Bodewig > wrote: > > > >> On 2014-09-03, sebb wrote: > >> > >> > Maybe it's possible to configure t

Re: git (yet again)

2014-09-03 Thread Martin Grigorov
On Wed, Sep 3, 2014 at 2:54 PM, Stefan Bodewig wrote: > On 2014-09-03, sebb wrote: > > > Maybe it's possible to configure the commit messages so that diffs are > > shown; if not, then perhaps there needs to be a convention for how to > > comment on commits. > > Might be something that can be conf

Re: git (yet again)

2014-09-03 Thread Martin Grigorov
d thing, are we confident, that we can get back? > > - Konstantin provided some reasons against git during the last three discussions. Some of the might be mitigated by now (e.g. svn externals vs. git submodules? Version diffs), some of them might not (Buildbot and Jenkins integration, m

Re: Too few fatal log ststements

2014-08-11 Thread Martin Grigorov
Hi, On Mon, Aug 11, 2014 at 11:45 AM, Leon Rosenberg wrote: > maybe tomcat is just so robust, that nothing is fatal to it ;-) > Leon > > > On Mon, Aug 11, 2014 at 11:41 AM, sangeeta lal > wrote: > > > Hi Mark, > > > > Actually I have data for other log levels also. Debug =600 statements, > > er

Re: svn commit: r1605890 - in /tomcat/trunk/java/org/apache/tomcat/websocket: LocalStrings.properties TransformationFactory.java

2014-06-27 Thread Martin Grigorov
Hi Mark, On Thu, Jun 26, 2014 at 10:44 PM, wrote: > Author: markt > Date: Thu Jun 26 19:44:54 2014 > New Revision: 1605890 > > URL: http://svn.apache.org/r1605890 > Log: > Fix an i18n TODO > > Modified: > tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties > > tomcat/trunk

Re: [VOTE] Release Apache Tomcat 8.0.9

2014-06-23 Thread Martin Grigorov
[X] Stable - go ahead and release as 8.0.9 (stable) On Mon, Jun 23, 2014 at 11:52 AM, Mark Thomas wrote: > On 19/06/2014 15:00, Mark Thomas wrote: > > The proposed Apache Tomcat 8.0.9 release is now available for voting. > > > > The main changes since 8.0.8 are: > > - Start to move towards RFC6

Re: Git (again)

2014-05-26 Thread Martin Grigorov
Hi, On Mon, May 26, 2014 at 4:18 PM, Konstantin Kolinko wrote: > 2014-05-24 0:51 GMT+04:00 Sylvain Laurent : > > Hello, > > > > Back in january/february there was a thread on moving to git with many > +1 for it. Are there any concrete plans for this ? > > > > I'm looking forward to it as using S

Re: Tomcat Buildbot configuration - JIRA issue

2014-05-26 Thread Martin Grigorov
Hi Konstantin, On Mon, May 26, 2014 at 2:59 PM, Konstantin Kolinko wrote: > Hi! > > I filed the issue for our Buildbot configuration: > https://issues.apache.org/jira/browse/INFRA-7807 > > You may want to keep a watch on it or add a comment. > > Best regards, > Konstantin Kolinko > I don't remem

Re: CI

2014-04-17 Thread Martin Grigorov
Hi, There are failed disks with BuildBot's master server (hostname: aegis). pctony (infra guy) said that they have ordered new ones and they will replace them today (US time ?!). Martin Grigorov Wicket Training and Consulting On Thu, Apr 17, 2014 at 3:37 PM, Rémy Maucherat wrote:

Re: [VOTE] Release Apache Tomcat 8.0.4

2014-03-20 Thread Martin Grigorov
> > >> Cheers, >> >> Mark >> >> [X] Stable - go ahead and release as 8.0.4 (stable) Martin Grigorov Wicket Training and Consulting > - >> To uns

Re: [VOTE] Release Apache Tomcat 7.0.52

2014-02-13 Thread Martin Grigorov
[ X ] Stable - go ahead and release as 7.0.52 Stable Tested Wicket Native WebSocket old and new impls Martin Grigorov Wicket Training and Consulting On Thu, Feb 13, 2014 at 9:17 AM, Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.52 release is now available for voting. > >

Re: [VOTE] Release Apache Tomcat 8.0.1

2014-01-30 Thread Martin Grigorov
[ X ] Stable - go ahead and release as 8.0.1 (stable) I see no problems with 8.0.1 Martin Grigorov Wicket Training and Consulting On Thu, Jan 30, 2014 at 12:43 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.1 release is now available for voting. > > This should be the fir

Re: Request parameters in HandshakeRequest

2014-01-29 Thread Martin Grigorov
On Wed, Jan 29, 2014 at 1:06 PM, Mark Thomas wrote: > On 29/01/2014 11:44, Martin Grigorov wrote: > > Hi, > > > > Apologies in advance if this is for users@. > > > > Should javax.websocket.server.HandshakeRequest#getParameterMap() contain > > the parameter

Request parameters in HandshakeRequest

2014-01-29 Thread Martin Grigorov
od so I this the parameter map should contain the parsed query string, no ? In the voted 8.0.0 release the map is empty when there is non-empty query string. Thanks! Martin Grigorov Wicket Training and Consulting

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Martin Grigorov
On Wed, Jan 29, 2014 at 12:37 PM, Mark Thomas wrote: > On 29/01/2014 10:11, Martin Grigorov wrote: > > Hi, > > > > Broken - do not release. > > > > It seems WebSocket support is broken for Google Chrome 32+. > > > > I tested Apache Wicket integration

Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Martin Grigorov
ocusedCommentId=13853464&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13853464 I run Ubuntu 13.10 and my Chrome version is 32.0.1700.77 Martin Grigorov Wicket Training and Consulting On Tue, Jan 28, 2014 at 9:28 PM, Mark Thomas wrote: > The proposed Apa

Re: Git

2014-01-21 Thread Martin Grigorov
Hi Rainer, On Tue, Jan 21, 2014 at 1:01 PM, Rainer Jung wrote: > On 21.01.2014 10:58, Mark Thomas wrote: > > I've been using Git more and more for Tomcat development and was > > wondering what folks thought about moving Tomcat to git. This isn't a > > formal proposal or a vote, I'm just trying t

Re: WebappClassLoader and prohibited classes/packages

2013-10-24 Thread Martin Grigorov
Hi, On Wed, Oct 23, 2013 at 6:38 PM, Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > I went looking into WebappClassLoader's validateJarFile() and filter() > methods, and I noticed two things: > > 1. The error message for locating an illegal class being loaded from a > JAR

Re: [VOTE] Release Apache Tomcat 7.0.45

2013-09-25 Thread Martin Grigorov
On Wed, Sep 25, 2013 at 3:37 PM, Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.45 release is now available for voting. > This release candidate contains JSR-356 Java WebSocket 1.0 implementation. > Note that use of this functionality requires Java 7. > > It can be obtained from: > http

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Martin Grigorov
Hi Rossen, On Tue, Sep 24, 2013 at 4:35 PM, Rossen Stoyanchev < rstoyanc...@gopivotal.com> wrote: > I am getting a ClassCastException when using (non JSR-356) upgrade, > i.e. WsServerContainer.doUpgrade: > > Caused by: java.lang.ClassCastException: > > org.springframework.security.web.servletapi

Re: [VOTE] Release Apache Tomcat 7.0.44

2013-09-24 Thread Martin Grigorov
On Mon, Sep 23, 2013 at 10:58 PM, Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.44 release is now available for voting. > This release candidate contains JSR-356 Java WebSocket 1.0 implementation. > Note that use of this functionality requires Java 7. > > It can be obtained from: > htt

Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-23 Thread Martin Grigorov
On Fri, Sep 20, 2013 at 12:36 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.0 release candidate 3 is now available > for voting. > > Given this is a release candidate I am working on the basis that it is > equivalent to an alpha. The main changes since RC1 are: > - Updated spec implemen

Re: svn commit: r1509847 - in /tomcat/trunk/java/javax/websocket: DefaultClientEndpointConfig.java server/DefaultServerEndpointConfig.java

2013-08-03 Thread Martin Grigorov
Hi Mark, Thanks for the fix! On Fri, Aug 2, 2013 at 10:28 PM, wrote: > Author: markt > Date: Fri Aug 2 20:28:12 2013 > New Revision: 1509847 > > URL: http://svn.apache.org/r1509847 > Log: > Use the same Map implementation for user properties to prevent > implementation conflicts > > Modified:

Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-02 Thread Martin Grigorov
I cannot login to Bugzilla with my account ... The problem is: this.userProperties.putAll(endpointConfig.getUserProperties()); a HashMap is copied into ConcurrentHashMap and null values cause the problem. On Fri, Aug 2, 2013 at 6:06 PM, Martin Grigorov wrote: > Hi, > > I'm pl

Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-02 Thread Martin Grigorov
Hi, I'm playing with the WebSocket impl and started seeing this NPE in my logs. I have no idea yet what started causing it. ==> logs/catalina.out <== Aug 02, 2013 6:03:21 PM org.apache.coyote.AbstractProtocol$AbstractConnectionHandler process SEVERE: Error reading request, ignored java.lang.NullP

Re: svn commit: r1509143 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/deploy/FileMessageFactory.java webapps/docs/changelog.xml

2013-08-01 Thread Martin Grigorov
Hi, On Thu, Aug 1, 2013 at 11:25 AM, wrote: > Author: kfujino > Date: Thu Aug 1 09:25:12 2013 > New Revision: 1509143 > > URL: http://svn.apache.org/r1509143 > Log: > Fix NPE in FileMessageFactory.main when specify empty file as arguments. > > Modified: > > tomcat/tc7.0.x/trunk/java/org/apache

Re: URIs, %nn decoding and error handling

2013-03-04 Thread Martin Grigorov
org/apache/catalina/connector/CoyoteAdapter.java?view=annotate>(line > ~1054) > > --**--**- > To unsubscribe, e-mail: > dev-unsubscribe@tomcat.apache.**org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com <http://jweekend.com/>

Re: [ANN] New Tomcat committer: Violeta Georgieva (violetagg)

2013-01-31 Thread Martin Grigorov
..@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com <http://jweekend.com/>

Re: latency - websockets vs. REST

2013-01-29 Thread Martin Grigorov
th connections are established, WebSocket should be faster (note that > > binary messages will be faster than text ones). > > > > If you have a test case that demonstrates this with established > > connections I'd certainly be interested. > > > > M

Re: Redirect to buffer strategy may not work properly on Tomcat 7.0.29

2012-07-27 Thread Martin Grigorov
nd this issue. Who knows if they > aren't only doing some good by preventing some session fixation attacks. They didn't workaround it yet. For now we discuss possible solutions for the next version. > > Pedro Santos > > Em 25/07/2012, às 16:42, Martin Grigorov escreveu

<    1   2   3   4   5