Re: [PR] Update RUNNING.txt [tomcat]

anujdevopslearn closed pull request #743: Update RUNNING.txt URL: https://github.com/apache/tomcat/pull/743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Update RUNNING.txt [tomcat]

anujdevopslearn opened a new pull request, #743: URL: https://github.com/apache/tomcat/pull/743 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

markt-asf commented on PR #742: URL: https://github.com/apache/tomcat/pull/742#issuecomment-2244574724 Thanks for the PR. All looks reasonable to me. There are a few bits of potential clean-up I noticed both in the patch and the surrounding code. I'll do that after I've merged this PR.

Re: [PR] Correctly Proxy Statement returned from ResultSet [tomcat]

markt-asf merged PR #742: URL: https://github.com/apache/tomcat/pull/742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix problem with concurrent access to different ConnectionPool instances [tomcat]

ChristopherSchultz closed pull request #737: Fix problem with concurrent access to different ConnectionPool instances URL: https://github.com/apache/tomcat/pull/737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Fix problem with concurrent access to different ConnectionPool instances [tomcat]

ChristopherSchultz commented on PR #737: URL: https://github.com/apache/tomcat/pull/737#issuecomment-2237137467 There isn't much here that isn't Virtual Thread friendly. VTs will indeed be pinned while running a synchronized block (at least in today's JVMs), but these blocks are

Re: [PR] Handle osgi headers correctly [tomcat-jakartaee-migration]

markt-asf commented on PR #54: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/54#issuecomment-2236760666 The size of the `org.eclipse.osgi` JAR is a concern. At 1.5MB it would more than double the size of the migration JAR and increase Tomcat's footprint by 10-15%. I think

Re: [PR] Fix problem with concurrent access to different ConnectionPool instances [tomcat]

pizzi80 commented on PR #737: URL: https://github.com/apache/tomcat/pull/737#issuecomment-2236111941 It would be nice to replace all these synchronized methods/blocks with a real Lock to be more VirtualThread friendly.

Re: [I] test [tomcat-jakartaee-migration]

aooohan closed issue #59: test URL: https://github.com/apache/tomcat-jakartaee-migration/issues/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix typos [tomcat]

ChristopherSchultz merged PR #741: URL: https://github.com/apache/tomcat/pull/741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix typos [tomcat]

ChristopherSchultz commented on PR #741: URL: https://github.com/apache/tomcat/pull/741#issuecomment-2223306831 Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] fix typos [tomcat]

rafaeldeoliveira opened a new pull request, #741: URL: https://github.com/apache/tomcat/pull/741 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add OpenSSL FFM code [tomcat]

rmaucher merged PR #740: URL: https://github.com/apache/tomcat/pull/740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add OpenSSL FFM code [tomcat]

rmaucher commented on PR #740: URL: https://github.com/apache/tomcat/pull/740#issuecomment-259840 The rationale behind this is long term support of Tomcat 9.0. - FFM support is likely desirable starting with the Java 25 LTS release - Java 25 cannot be used to compile Tomcat 9.0

[PR] Add OpenSSL FFM code [tomcat]

rmaucher opened a new pull request, #740: URL: https://github.com/apache/tomcat/pull/740 Also port the TLS testsuite improvements from 10.1. APR TLS testing uses only the OpenSSL parameter (and skips JSSE and OpenSSL FFM) to avoid looking weird while running only once. -- This is an

Re: [PR] Update, refactor and polish instructions of the documentation. [tomcat-native]

dsoumis merged PR #25: URL: https://github.com/apache/tomcat-native/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M18 to 11.0.0-M21 in /modules/openssl-foreign [tomcat]

dependabot[bot] commented on PR #738: URL: https://github.com/apache/tomcat/pull/738#issuecomment-2214028341 Looks like org.apache.tomcat:tomcat-coyote is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M18 to 11.0.0-M21 in /modules/openssl-foreign [tomcat]

dependabot[bot] closed pull request #738: Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M18 to 11.0.0-M21 in /modules/openssl-foreign URL: https://github.com/apache/tomcat/pull/738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

Hakky54 commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2212556516 After couple of review rounds it is not clear whether it would get approved/merged, so I decided to close this PR. Please ping me if you guys still consider and and I will create a new PR.

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

Hakky54 closed pull request #706: Simplify usage of custom ssl configuration URL: https://github.com/apache/tomcat/pull/706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Merged two loops into one to simplify the logic [tomcat]

markt-asf commented on PR #739: URL: https://github.com/apache/tomcat/pull/739#issuecomment-2211679939 This won't be merged for the reason Chuck explained. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Merged two loops into one to simplify the logic [tomcat]

markt-asf closed pull request #739: Merged two loops into one to simplify the logic URL: https://github.com/apache/tomcat/pull/739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Merged two loops into one to simplify the logic [tomcat]

n828cl commented on PR #739: URL: https://github.com/apache/tomcat/pull/739#issuecomment-2211492415 The proposed change would violate the servlet spec, which requires that filters matching URL patterns must precede those matching servlet names, even when using the same filter for both. See

[PR] Merged two loops into one to simplify the logic [tomcat]

lee-jeong-geun opened a new pull request, #739: URL: https://github.com/apache/tomcat/pull/739 Hello. Reduced the filter addition logic in createFilterChain to a single loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Bump org.apache.tomcat:tomcat-coyote from 11.0.0-M18 to 11.0.0-M21 in /modules/openssl-foreign [tomcat]

dependabot[bot] opened a new pull request, #738: URL: https://github.com/apache/tomcat/pull/738 Bumps org.apache.tomcat:tomcat-coyote from 11.0.0-M18 to 11.0.0-M21. [![Dependabot compatibility

Re: [PR] Changed simple synchronization to ReentrantReadWriteLock [tomcat]

n828cl commented on PR #712: URL: https://github.com/apache/tomcat/pull/712#issuecomment-2208075153 Tomcat 8.5 reached end-of-life in March, so there won't be any more updates. You should update to a supported level at your earliest convenience. -- This is an automated message from the

Re: [PR] Changed simple synchronization to ReentrantReadWriteLock [tomcat]

wapkch commented on PR #712: URL: https://github.com/apache/tomcat/pull/712#issuecomment-2207881666 @ChristopherSchultz Could this fix be ported to 8.5.x? Cause the latest 8.5.100 has the same problem. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] javax2jakarta has been included in Fedora [tomcat-jakartaee-migration]

markt-asf merged PR #58: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix problem with concurrent access to different ConnectionPool instances [tomcat]

markt-asf commented on PR #737: URL: https://github.com/apache/tomcat/pull/737#issuecomment-2205441036 That the threads have different context class loaders doesn't explain the behaviour you are seeing. As per section 8.4.3.6 of the JLS, there is a single monitor for both methods.

Re: [PR] Fix problem with concurrent access to different ConnectionPool instances [tomcat]

pb00067 commented on PR #737: URL: https://github.com/apache/tomcat/pull/737#issuecomment-2205400307 > please notice that both methods registerCleaner() and unregisterCleaner() having the synchronized keyword does not prevent that one thread executes registerCleaner() while another thread

Re: [PR] Increase test coverage of WsServerContainer [tomcat]

JanFojtik21 commented on PR #736: URL: https://github.com/apache/tomcat/pull/736#issuecomment-2186446656 okey, then all good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Increase test coverage of WsServerContainer [tomcat]

dsoumis commented on PR #736: URL: https://github.com/apache/tomcat/pull/736#issuecomment-2186443680 Thanks for pointing that out. I've applied the fixes required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Increase test coverage of WsServerContainer [tomcat]

rmaucher commented on PR #736: URL: https://github.com/apache/tomcat/pull/736#issuecomment-2186070382 Did you add "execute.validate=true" to your build.properties file ? Normally we don't use wildcard imports (please avoid that part). Other than that, more test coverage = good. --

[PR] Increase test coverage of WsServerContainer [tomcat]

dsoumis opened a new pull request, #736: URL: https://github.com/apache/tomcat/pull/736 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

Hakky54 commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2173747924 The wrapper class is package protected, so no one can access it. It can only be created using the sslutil which returns the interface. I am not sure whether sslutil is the right place and

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

ChristopherSchultz commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2173636514 > > The constructor captures its arguments and then ignores them forever after that. Why bother capturing them in the first place? > > Well actually it is using the

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

Hakky54 commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2168908756 > This wrapper class appears to specifically discard the key managers and trust managers. I used my own example from my own project to demonstrate the usage of it within the PR

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

ChristopherSchultz commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2168824675 This wrapper class appears to specifically discard the key managers and trust managers. The constructor captures its arguments and then ignores them forever after that. Why

Re: [PR] Simplify usage of custom ssl configuration [tomcat]

Hakky54 commented on PR #706: URL: https://github.com/apache/tomcat/pull/706#issuecomment-2168789527 Hi guys, any news regarding this topic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Rename method `getUseVirtualThreads` to `isUseVirtualThreads` [tomcat]

ChristopherSchultz commented on PR #734: URL: https://github.com/apache/tomcat/pull/734#issuecomment-2168032699 The Javabean specification says that boolean properties must have accessors (for readable properties) and mutators (for writable ones) called `boolean getFoo()` and/or `boolean

Re: [PR] Rename method `getUseVirtualThreads` to `isUseVirtualThreads` [tomcat]

markt-asf commented on PR #734: URL: https://github.com/apache/tomcat/pull/734#issuecomment-2167440923 No, it is a coding style choice. The Tomcat code uses both. Currently about 70% use `isXxx` and 30% use `getXxx`. Personally, I tend to use whichever one feels more natural at the time.

Re: [PR] Rename method `getUseVirtualThreads` to `isUseVirtualThreads` [tomcat]

quaff commented on PR #734: URL: https://github.com/apache/tomcat/pull/734#issuecomment-2167411725 > no explanation. I thought it's common sense that boolean property getter should be `is*`. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Rename method `getUseVirtualThreads` to `isUseVirtualThreads` [tomcat]

markt-asf commented on PR #734: URL: https://github.com/apache/tomcat/pull/734#issuecomment-2167400050 No prior discussion, no explanation. Therefore close without merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Rename method `getUseVirtualThreads` to `isUseVirtualThreads` [tomcat]

markt-asf closed pull request #734: Rename method `getUseVirtualThreads` to `isUseVirtualThreads` URL: https://github.com/apache/tomcat/pull/734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Rename method `getUseVirtualThreads` to `isUseVirtualThreads` [tomcat]

quaff opened a new pull request, #734: URL: https://github.com/apache/tomcat/pull/734 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Support jar resources in bloom filter [tomcat]

markt-asf commented on PR #730: URL: https://github.com/apache/tomcat/pull/730#issuecomment-2163058083 Thanks for the PR. Applied manually with a few tweaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Support jar resources in bloom filter [tomcat]

markt-asf closed pull request #730: Support jar resources in bloom filter URL: https://github.com/apache/tomcat/pull/730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Configurable HTML subtitle in Manager web application [tomcat]

markt-asf commented on PR #724: URL: https://github.com/apache/tomcat/pull/724#issuecomment-2162824078 Thanks for the PR. I have applied a variation of this that uses a servlet init parameter rather than a context init parameter since a) the configuration is specific to the servlet and b)

Re: [PR] Configurable HTML subtitle in Manager web application [tomcat]

markt-asf closed pull request #724: Configurable HTML subtitle in Manager web application URL: https://github.com/apache/tomcat/pull/724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Make ConnectionHandler accessible through API from AbstractProtocol to ultimately acess RequestGroupInfo [tomcat]

markt-asf merged PR #711: URL: https://github.com/apache/tomcat/pull/711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Make ConnectionHandler accessible through API from AbstractProtocol to ultimately acess RequestGroupInfo [tomcat]

rmannibucau commented on code in PR #711: URL: https://github.com/apache/tomcat/pull/711#discussion_r1636187299 ## java/org/apache/coyote/AbstractProtocol.java: ## @@ -769,7 +769,7 @@ private void logPortOffset() { // ---

Re: [PR] Make ConnectionHandler accessible through API from AbstractProtocol to ultimately acess RequestGroupInfo [tomcat]

markt-asf commented on code in PR #711: URL: https://github.com/apache/tomcat/pull/711#discussion_r1636159961 ## java/org/apache/coyote/AbstractProtocol.java: ## @@ -769,7 +769,7 @@ private void logPortOffset() { // --- Connection

Re: [PR] Fix ide-support for idea [tomcat]

isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2161659043 I merged the PR and tried to comment out the exclusion lines as agreed above, but that breaks with a different error and does not allow to build. I think that it's best to leave things

Re: [PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]

ChristopherSchultz merged PR #733: URL: https://github.com/apache/tomcat/pull/733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]

ChristopherSchultz commented on PR #733: URL: https://github.com/apache/tomcat/pull/733#issuecomment-2161606328 > When running `ant deploy` to reproduce the build, `pre-release` target will not have been executed If you are trying to reproduce the build, they you will have

Re: [PR] Fix ide-support for idea [tomcat]

ChristopherSchultz commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2161585676 My preference is for the ide-idea ant target to work for *most people*. _Most people_ are not Tomcat developers, but people who have downloaded our sources and are building them

Re: [PR] Fix ide-support for idea [tomcat]

isapir merged PR #731: URL: https://github.com/apache/tomcat/pull/731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: [PR] Fix ide-support for idea [tomcat]

dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160442520 The change we could make so that all opinions are generally satisfied are: 1. Move the exclusions from `res/ide-support/idea/compiler.xml` to `res/ide-support/idea/tomcat.iml`

Re: [PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]

dsoumis commented on PR #733: URL: https://github.com/apache/tomcat/pull/733#issuecomment-2160410399 > Is tstamp.iso.release defined at that spot @dsoumis ? Yes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Fix ide-support for idea [tomcat]

markt-asf commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160396222 > Since IDE support is [configured](https://github.com/apache/tomcat/blob/main/build.xml#L3830) with build.java.version, which currently is

Re: [PR] Fix typo in Czech translation [tomcat]

jajik closed pull request #732: Fix typo in Czech translation URL: https://github.com/apache/tomcat/pull/732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix typo in Czech translation [tomcat]

jajik commented on PR #732: URL: https://github.com/apache/tomcat/pull/732#issuecomment-2160391202 Closing after a discussion with @rmaucher , POEditor changes should be sufficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Fix ide-support for idea [tomcat]

dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2160286872 > IMO it is reasonable to expect a user that is developing on the latest version of Tomcat, i.e. the main branch, to be using the latest Java SDK, which will work with the Experimental

Re: [PR] Fix ide-support for idea [tomcat]

isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2159528473 Thank you for your input on this @markt-asf - it makes sense to me, and is consistent with my proposed solution. > - Eclipse is configured to use the same Java version as the build

Re: [PR] Added option to use custom SSLContext [tomcat]

alipsitz-sf commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-2158656022 Hey, I'm not really good navigating Bugzilla, so I don't know if it's been reported already but it looks like this PR broke the `AbstractHttp11Protocol.reloadSslHostConfigs()` API when

Re: [PR] Fix ide-support for idea [tomcat]

markt-asf commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2157847935 I'm not an Idea user so I have no strong view on this. I'd be happy with whatever consensus the Idea users reach. I am an Eclipse user and the approach I use there (which I think

Re: [PR] Fix ide-support for idea [tomcat]

rmannibucau commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151570300 Assuming using uses the highest java version sounds okish but shouldnt preview mode be enabled if the packages are not excluded, otherwise it leads to the same output: it does not work

Re: [PR] Fix ide-support for idea [tomcat]

isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151559998 @dsoumis Tomcat 11 takes advantage of new technology. The build script checks if the Java version is 22 and if so it compiles the Panama packages. This is for a development

Re: [PR] Fix ide-support for idea [tomcat]

dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2151524740 @isapir My expectation was that "ant ide-intellij" should work out of the box without requiring any adjustments. Currently, to use an SDK version lower than 22, you must exclude

Re: [PR] Fix ide-support for idea [tomcat]

isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2150273321 @dsoumis But now you are completely excluding `/java/org/apache/tomcat/util/net/openssl/panama` and `/java/org/apache/tomcat/util/openssl`? It might "work" on Java 17 but new technology

Re: [PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]

isapir commented on PR #733: URL: https://github.com/apache/tomcat/pull/733#issuecomment-2150229542 Is `tstamp.iso.release` defined at that spot @dsoumis ? If so, maybe we can set a default for `ant.tstamp.now.iso` to be `tstamp.iso.release`? -- This is an automated message from the

Re: [PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]

dsoumis commented on PR #733: URL: https://github.com/apache/tomcat/pull/733#issuecomment-2150200992 When running `ant deploy` to reproduce the build, `pre-release` target will not have been executed, ant.tstamp.now.iso has no value assigned and the following output is written: >

[PR] Fix property ant.tstamp.now.iso ignored when building Tomcat JDBC poo… [tomcat]

dsoumis opened a new pull request, #733: URL: https://github.com/apache/tomcat/pull/733 …l libraries -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix ide-support for idea [tomcat]

dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2149133573 On second thoughts, I believe ide-support should strictly follow build.xml rules. As build.xml [excludes](https://github.com/apache/tomcat/blob/main/build.xml#L1014) openssl and panama

[PR] Fix typo in Czech translation [tomcat]

jajik opened a new pull request, #732: URL: https://github.com/apache/tomcat/pull/732 At the same time, I've updated the translation in the POEditor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [I] Unable to install Tomcat 9 - **"Package 'tomcat9' has no installation candidate"** || Ubuntu 24.04 LTS [tomcat-jakartaee-migration]

markt-asf closed issue #56: Unable to install Tomcat 9 - **"Package 'tomcat9' has no installation candidate"** || Ubuntu 24.04 LTS URL: https://github.com/apache/tomcat-jakartaee-migration/issues/56 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Unable to install Tomcat 9 - **"Package 'tomcat9' has no installation candidate"** || Ubuntu 24.04 LTS [tomcat-jakartaee-migration]

slovdahl commented on issue #56: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/56#issuecomment-2146878806 In general, I don't think is the right place for Ubuntu-specific package issues. For Ubuntu-specific package questions/issues, you should use

[I] Unable to install Tomcat 9 - **"Package 'tomcat9' has no installation candidate"** || Ubuntu 24.04 LTS [tomcat-jakartaee-migration]

dipualnur opened a new issue, #56: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/56 I'm trying to install Tomcat 9 on my Ubuntu system using `* `sudo apt-get install tomcat9` but I keep running into the following error: >

Re: [PR] Fix ide-support for idea [tomcat]

isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2145709893 Strange, I don't have those settings  But OK, I will revert the latest change. Feel

Re: [PR] Support jar resources in bloom filter [tomcat]

jengebr commented on PR #730: URL: https://github.com/apache/tomcat/pull/730#issuecomment-2145551211 Looks good to me. Of course, I'm not a committer. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Support jar resources in bloom filter [tomcat]

bergander commented on PR #730: URL: https://github.com/apache/tomcat/pull/730#issuecomment-2145330590 Thanks for the very quick feedback! I'll update the code with your suggestion. I'm guessing that the combination of having resources inside jar files and turning on the bloom

Re: [PR] Support jar resources in bloom filter [tomcat]

jengebr commented on PR #730: URL: https://github.com/apache/tomcat/pull/730#issuecomment-2145263710 Thank you, this was very helpful! I investigated and found: 1. Your test clearly reproduced the error. Much appreciated. 2. internalPath is usually "" (a String of length 0) 3. I'm

Re: [PR] Fix ide-support for idea [tomcat]

dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144545354 @isapir It doesn't work for me. After pulling your patch I am getting errors such as: `java: java.lang.foreign.Arena is a preview API and is disabled by default. (use

Re: [PR] Support jar resources in bloom filter [tomcat]

bergander commented on PR #730: URL: https://github.com/apache/tomcat/pull/730#issuecomment-2144410872 I've created a test case which fetches a resource from a jar file. It uses a _JarResourceSet_ with the _internalPath_ set to _/META-INF/resources_ and the test fetches the file

Re: [PR] Fix ide-support for idea [tomcat]

isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144252838 @dsoumis I pushed a patch that sets the Language Level to Experimental: https://github.com/apache/tomcat/commit/f8eecc13b53fdca998565455d3c27e9b9a6cd8dc Can you pull it and check if

Re: [PR] Fix ide-support for idea [tomcat]

isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2144037801 @dsoumis I got it to work by setting the Project's `Language level` to "X - Experimental features"

Re: [PR] Fix ide-support for idea [tomcat]

markt-asf commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142686031 That isn't it then. I think we need someone else with Idea (or who can set it up) to test this. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Fix ide-support for idea [tomcat]

dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142631865 22.0.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix ide-support for idea [tomcat]

markt-asf commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142625138 Hmm. Exactly which version of Java 22 are you using? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix ide-support for idea [tomcat]

dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142611198 @markt-asf Compilation errors with Java22 (compile target is 22 as well as Java 22 being used): > >

Re: [PR] Fix ide-support for idea [tomcat]

markt-asf commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142584248 I'm not an Idea user but I'd expect that code to compile using Java 22. Not much help I know but those packages aren't showing any errors in Eclipse with Java 22. What is the error

Re: [PR] Fix ide-support for idea [tomcat]

isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142552727 @dsoumis I agree that it's weird, but my concern is that it would break other environments that work. Let's wait for Remy/Mark/others to chime in as they are more familiar with how

Re: [PR] Fix ide-support for idea [tomcat]

dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142542693 @isapir It seemed weird to me, but even with Java 22 defined in Intellij the compilation didn't succeed. Maybe something else is missing as well. +1 For adding a comment in the output

Re: [PR] Fix ide-support for idea [tomcat]

isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142532017 @dsoumis It won't compile if the Java version etc. are not compatible with that code. This is not making it useless. Perhaps a better change would be to add a comment about it in the output,

Re: [PR] Fix ide-support for idea [tomcat]

dsoumis commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142501404 Intellij won't compile the sources if those exclusions are not made, making the "ant ide-intellij" step useless. In case it's not the right thing to do, we should redefine the support

Re: [PR] Fix ide-support for idea [tomcat]

isapir commented on PR #731: URL: https://github.com/apache/tomcat/pull/731#issuecomment-2142442782 These lines were commented out on purpose, so that they are available if you need them but not enabled by default. I am not sure that uncommenting them is the right thing to do. The

[PR] Fix ide-support for idea [tomcat]

dsoumis opened a new pull request, #731: URL: https://github.com/apache/tomcat/pull/731 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Support jar resources in bloom filter [tomcat]

jengebr commented on PR #730: URL: https://github.com/apache/tomcat/pull/730#issuecomment-2142005988 Can you please add a unit test to demonstrate the problem? I don't fully understand the issue. Also, this implementation comes with a performance penalty when accessing any

Re: [PR] chore: fix some misaligned whitespace in web.xml [tomcat]

markt-asf merged PR #727: URL: https://github.com/apache/tomcat/pull/727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update recommended Tomcat native version to 1.3.0 [tomcat]

markt-asf merged PR #728: URL: https://github.com/apache/tomcat/pull/728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   4   5   6   7   8   9   10   >