Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437901624 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437900565 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437899157 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437898144 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437898048 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437897171 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1437896682 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -110,45 +285,70 @@ public void doFilter(ServletRequest request, ServletResponse response,

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1436107052 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1435945699 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1435945537 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -110,45 +285,70 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha

Re: [PR] Csrf filter improvements [tomcat]

isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1435943790 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1435943366 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434524088 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String parameterName) {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434521612 ## webapps/docs/config/filter.xml: ## @@ -319,6 +326,34 @@ of java.security.SecureRandom will be used. + +A list of URL

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434518590 ## webapps/docs/config/filter.xml: ## @@ -291,6 +291,13 @@ request. The default value is 403. + +A flag to enable or disable

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434514917 ## webapps/docs/config/filter.xml: ## @@ -291,6 +291,13 @@ request. The default value is 403. + +A flag to enable or disable

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434513367 ## webapps/docs/config/filter.xml: ## @@ -319,6 +326,34 @@ of java.security.SecureRandom will be used. + +A list of URL patterns that

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434512783 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest request) {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434511388 ## webapps/docs/config/filter.xml: ## @@ -319,6 +326,34 @@ of java.security.SecureRandom will be used. + +A list of URL

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1434510673 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest request) {

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1433225531 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -198,15 +416,27 @@ protected boolean skipNonceCheck(HttpServletRequest request) {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864951885 > Re 4: I think that if one is wise enough to write a RegExp, they could use "|" to combine several patterns, and do not really need splitting by comma. Or do you envision a use

Re: [PR] Csrf filter improvements [tomcat]

kkolinko commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864889547 Re 8: Whatever is easier. (Maybe it will be easier to extract some logic into an utility class and test that utility class. My concern is just that the logic is not trivial, is

Re: [PR] Csrf filter improvements [tomcat]

kkolinko commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864873921 Re 4: I think that if one is wise enough to write a RegExp, they could use "|" to combine several patterns, and do not really need splitting by comma. Or do you envision a use case, where

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864828084 > 1. There are case-insensitive file systems out there... I wonder whether those default extensions should be treated case-insensitively. (If one is serving a web site from an

Re: [PR] Csrf filter improvements [tomcat]

kkolinko commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864808958 1. There are case-insensitive file systems out there... I wonder whether those default extensions should be treated case-insensitively. (If one is serving a web site from an USB stick or a

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432909931 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432880460 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432856054 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432853641 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1432402971 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

markt-asf commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431736198 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431641166 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431639832 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431618064 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431615348 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431612056 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1431610887 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430461949 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430459964 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

markt-asf commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430459910 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

isapir commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430457497 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase { private

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430451465 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1430450663 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] [WIP] initial implementation of webresource based on path API [tomcat]

KoteswararaoGundapaneni commented on PR #630: URL: https://github.com/apache/tomcat/pull/630#issuecomment-1860268262 Any valid update regarding the work status of this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Csrf filter improvements [tomcat]

michael-o commented on code in PR #681: URL: https://github.com/apache/tomcat/pull/681#discussion_r1428761992 ## java/org/apache/catalina/filters/CsrfPreventionFilter.java: ## @@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends CsrfPreventionFilterBase {

Re: [PR] [WIP] initial implementation of webresource based on path API [tomcat]

KoteswararaoGundapaneni commented on PR #630: URL: https://github.com/apache/tomcat/pull/630#issuecomment-1858736665 Am ready to take part in this based on the work allocated as per the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1858319793 Commit [e2f78ec](https://github.com/apache/tomcat/pull/681/commits/e2f78eca0c7626303e5e50f1f033770b466f1755) adds nonce-check skipping to the URLs that won't get nonces added to

Re: [PR] Csrf filter improvements [tomcat]

ChristopherSchultz commented on PR #681: URL: https://github.com/apache/tomcat/pull/681#issuecomment-1858296301 My initial testing indicates that caching is working as expected with these changes. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Csrf filter improvements [tomcat]

ChristopherSchultz opened a new pull request, #681: URL: https://github.com/apache/tomcat/pull/681 Please see https://lists.apache.org/thread/47syblyghh3tromyf6bkvl8q14w70f3x for the initial conversation. I see some potential improvements for the CSRF prevention filter that will be

Re: [PR] Dir redirect use301 [tomcat]

markt-asf commented on PR #524: URL: https://github.com/apache/tomcat/pull/524#issuecomment-1857955904 A variation of this has been applied to 11.0.x as Servlet 6.1 has added additional methods to allow the status code to be specified in a sendRedirect() call. -- This is an automated

Re: [I] How can I know the migrated jar is actually "touched" or not after running MigrationCLI [tomcat-jakartaee-migration]

zoumuzou commented on issue #51: URL: https://github.com/apache/tomcat-jakartaee-migration/issues/51#issuecomment-1851193071 OK, thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Bump org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16 in /modules/owb [tomcat]

dependabot[bot] opened a new pull request, #680: URL: https://github.com/apache/tomcat/pull/680 Bumps org.apache.tomcat:tomcat-catalina from 10.1.15 to 10.1.16. [![Dependabot compatibility

Re: [PR] PDS-4683 upgrade tomcat for security reasons [tomcat-maven-plugin]

glendagonzales closed pull request #42: PDS-4683 upgrade tomcat for security reasons URL: https://github.com/apache/tomcat-maven-plugin/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Update README.md [tomcat]

aooohan closed pull request #679: Update README.md URL: https://github.com/apache/tomcat/pull/679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Update README.md [tomcat]

BTrees opened a new pull request, #679: URL: https://github.com/apache/tomcat/pull/679 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-test [tomcat-taglibs-standard]

dependabot[bot] commented on PR #3: URL: https://github.com/apache/tomcat-taglibs-standard/pull/3#issuecomment-1819973270 Superseded by #9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-test [tomcat-taglibs-standard]

dependabot[bot] closed pull request #3: Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-test URL: https://github.com/apache/tomcat-taglibs-standard/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Bump org.apache.derby:derby from 10.4.2.0 to 10.17.1.0 in /standard-test [tomcat-taglibs-standard]

dependabot[bot] opened a new pull request, #9: URL: https://github.com/apache/tomcat-taglibs-standard/pull/9 Bumps org.apache.derby:derby from 10.4.2.0 to 10.17.1.0. [![Dependabot compatibility

Re: [PR] Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-examples [tomcat-taglibs-standard]

dependabot[bot] closed pull request #2: Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-examples URL: https://github.com/apache/tomcat-taglibs-standard/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump derby from 10.4.2.0 to 10.14.2.0 in /standard-examples [tomcat-taglibs-standard]

dependabot[bot] commented on PR #2: URL: https://github.com/apache/tomcat-taglibs-standard/pull/2#issuecomment-1819973208 Superseded by #8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump org.apache.derby:derby from 10.4.2.0 to 10.17.1.0 in /standard-examples [tomcat-taglibs-standard]

dependabot[bot] opened a new pull request, #8: URL: https://github.com/apache/tomcat-taglibs-standard/pull/8 Bumps org.apache.derby:derby from 10.4.2.0 to 10.17.1.0. [![Dependabot compatibility

Re: [PR] Making sure that stop is not "blocked" by the check() in HostConfig [tomcat]

jfclere closed pull request #641: Making sure that stop is not "blocked" by the check() in HostConfig URL: https://github.com/apache/tomcat/pull/641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Making sure that stop is not "blocked" by the check() in HostConfig [tomcat]

jfclere commented on PR #641: URL: https://github.com/apache/tomcat/pull/641#issuecomment-1819080600 See https://github.com/apache/tomcat/commit/dce1fc833b5192ec0ccee7d4120a050cee5da8de the exceptions are gone but now the stop() is blocked by the check(String name) but the fix is easy

Re: [PR] Add support for RequestBoudaries in DBCP [tomcat]

aooohan closed pull request #678: Add support for RequestBoudaries in DBCP URL: https://github.com/apache/tomcat/pull/678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Add support for RequestBoudaries in DBCP [tomcat]

aooohan commented on PR #678: URL: https://github.com/apache/tomcat/pull/678#issuecomment-1818083370 This is an internal fork project which not belong to Tomcat. You should move this change to [Apache Commons DBCP](https://github.com/apache/commons-dbcp). -- This is an automated message

Re: [PR] Add support for RequestBoudaries in DBCP [tomcat]

KoteswararaoGundapaneni commented on PR #678: URL: https://github.com/apache/tomcat/pull/678#issuecomment-1817359611 still there is no presence of beginRequest in our code when i checked in dbcp -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Add support for RequestBoudaries in DBCP [tomcat]

KoteswararaoGundapaneni commented on PR #678: URL: https://github.com/apache/tomcat/pull/678#issuecomment-1817334170 Hi Meedbek Please allow to work on this for offline to assist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Add support for RequestBoudaries in DBCP [tomcat]

meedbek opened a new pull request, #678: URL: https://github.com/apache/tomcat/pull/678 JDBC 4.3 introduced `beginRequest` and `endRequest` methods for connection pools which are called to mark request boundaries. `beginRequest` should be called when borrowing a connection and

Re: [PR] Added option to use custom SSLContext [tomcat]

KoteswararaoGundapaneni commented on PR #673: URL: https://github.com/apache/tomcat/pull/673#issuecomment-1816164863 Requesting to panel the change request to be considering and request has been taken care by the process that's done above -- This is an automated message from the Apache

Re: [PR] #49 support ear file type as archive file [tomcat-jakartaee-migration]

markt-asf merged PR #50: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Before closing the database connection, roll back the transaction [tomcat]

markt-asf commented on PR #667: URL: https://github.com/apache/tomcat/pull/667#issuecomment-1801356054 Closing since behaviour is intentionally configurable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Before closing the database connection, roll back the transaction [tomcat]

markt-asf closed pull request #667: Before closing the database connection, roll back the transaction URL: https://github.com/apache/tomcat/pull/667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Added support for JDBC 4.3 beginRequest and endRequest methods. [tomcat]

fmeheust commented on code in PR #677: URL: https://github.com/apache/tomcat/pull/677#discussion_r1384572235 ## modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java: ## @@ -812,6 +829,28 @@ protected PooledConnection createConnection(long now,

Re: [PR] Added support for JDBC 4.3 beginRequest and endRequest methods. [tomcat]

fmeheust commented on code in PR #677: URL: https://github.com/apache/tomcat/pull/677#discussion_r1384567373 ## modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/ConnectionBoundariesTest.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Added support for JDBC 4.3 beginRequest and endRequest methods. [tomcat]

aooohan commented on code in PR #677: URL: https://github.com/apache/tomcat/pull/677#discussion_r1384334368 ## modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/ConnectionBoundariesTest.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[PR] Added support for JDBC 4.3 beginRequest and endRequest methods. [tomcat]

fmeheust opened a new pull request, #677: URL: https://github.com/apache/tomcat/pull/677 JDBC 4.3 added the methods beginRequest and endRequest to java.sql.Connection. These methods hint the driver of the beginning and completion of a request (independent unit of work). Connection pooling

Re: [PR] Fix explicit chunked encoding specification [tomcat]

markt-asf commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1790213186 No, this PR will not be applied. Applications should not be setting the Transfer-Encoding header. Or the Connection header for that matter. If you want to strongly suggest to the

Re: [PR] Fix explicit chunked encoding specification [tomcat]

w1ida commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1789983590 > The description for the PR confuses request and response. It appears from the code that this PR relates to the response. > > This PR will not be applied. Whether or not to chunk the

Re: [PR] Fix explicit chunked encoding specification [tomcat]

markt-asf commented on PR #676: URL: https://github.com/apache/tomcat/pull/676#issuecomment-1788896749 The description for the PR confuses request and response. It appears from the code that this PR relates to the response. This PR will not be applied. Whether or not to chunk the

Re: [PR] Fix explicit chunked encoding specification [tomcat]

markt-asf closed pull request #676: Fix explicit chunked encoding specification URL: https://github.com/apache/tomcat/pull/676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Fix explicit chunked encoding specification [tomcat]

w1ida opened a new pull request, #676: URL: https://github.com/apache/tomcat/pull/676 Summary: This commit fixes a bug in the code related to handling chunked transfer encoding. The original code only handled chunked transfer encoding when http11 was true, entityBody was true, and

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

michael-o closed pull request #675: BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs URL: https://github.com/apache/tomcat/pull/675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

michael-o commented on PR #675: URL: https://github.com/apache/tomcat/pull/675#issuecomment-1787001486 Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

rmaucher commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377379112 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -56,6 +56,8 @@ import org.apache.tomcat.util.codec.binary.Base64; import

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

aooohan commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377275894 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

michael-o commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377274168 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

aooohan commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377262792 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

michael-o commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377209435 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

michael-o commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1377209435 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

aooohan commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

aooohan commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

aooohan commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376990387 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -624,6 +626,16 @@ private byte[] fromHex(String hexString) { } return bytes;

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

michael-o commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376474963 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -56,6 +56,8 @@ import org.apache.tomcat.util.codec.binary.Base64; import

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

michael-o commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376474963 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -56,6 +56,8 @@ import org.apache.tomcat.util.codec.binary.Base64; import

Re: [PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

ChristopherSchultz commented on code in PR #675: URL: https://github.com/apache/tomcat/pull/675#discussion_r1376435849 ## java/org/apache/tomcat/util/net/jsse/PEMFile.java: ## @@ -56,6 +56,8 @@ import org.apache.tomcat.util.codec.binary.Base64; import

[PR] BZ 67926: PEMFile prints unidentifiable string representation of ASN.1 OIDs [tomcat]

michael-o opened a new pull request, #675: URL: https://github.com/apache/tomcat/pull/675 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] BZ 67818: SSL#setVerify()/SSLContext#setVerify() silently set undocum… [tomcat-native]

michael-o closed pull request #22: BZ 67818: SSL#setVerify()/SSLContext#setVerify() silently set undocum… URL: https://github.com/apache/tomcat-native/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] BZ 67818: SSL#setVerify()/SSLContext#setVerify() silently set undocum… [tomcat-native]

michael-o commented on PR #22: URL: https://github.com/apache/tomcat-native/pull/22#issuecomment-1784891589 Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Fix NioChannel's toString() throwing NullPointerException in some cases [tomcat]

chenggwang commented on PR #671: URL: https://github.com/apache/tomcat/pull/671#issuecomment-1780424297 > Thanks for the PR. Thanks for all the REVIEWS! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

<    1   2   3   4   5   6   7   8   9   10   >