markt-asf commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570534844
> @markt-asf that looks better that what was there ;-)
Thanks.
Can you recall if there was a use case for this Valve on a single node? Or
was it always intended for use
jfclere commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570527918
@markt-asf that looks better that what was there ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
markt-asf merged PR #622:
URL: https://github.com/apache/tomcat/pull/622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rmaucher commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570477734
Very clean overall, esp the javadoc update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
markt-asf commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1570461148
I haven't deprecated this yet. I'm waiting on input from the OP of BZ 66513
and/or @jfclere as the original author of the Valve in case there is a use case
I have missed.
--
This is an
markt-asf commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568591682
Map eviction is handled in the finally block.
That we can only make this work on a single node is why Rémy is proposing
that we remove/deprecate this Valve.
--
This is an
rmannibucau commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568571457
* Is there a plan for the map eviction? background thread?
* How does it work in a cluster since counter is local, should it be a
cluster event?
--
This is an automated message
rmaucher commented on PR #623:
URL: https://github.com/apache/tomcat/pull/623#issuecomment-1568565624
That seems like the better way to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markt-asf opened a new pull request, #623:
URL: https://github.com/apache/tomcat/pull/623
This is untested.
If accepted, this will need some documentation updates.
The purpose of this draft is to obtain early feedback on the approach.
--
This is an automated message from the
alexkachanov opened a new pull request, #622:
URL: https://github.com/apache/tomcat/pull/622
* implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
markt-asf closed pull request #621: Bug 66609 - invalid XML in directory
listing with file names containing "&" and "'"
URL: https://github.com/apache/tomcat/pull/621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
markt-asf commented on PR #621:
URL: https://github.com/apache/tomcat/pull/621#issuecomment-1561136901
Thanks for the PR. Applied manually with a few tweaks (e.g. CheckStyle
config).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alexkachanov commented on code in PR #621:
URL: https://github.com/apache/tomcat/pull/621#discussion_r1203991514
##
java/org/apache/catalina/servlets/DefaultServlet.java:
##
@@ -1650,7 +1650,7 @@ protected InputStream renderXml(HttpServletRequest
request, String contextPath,
alexkachanov commented on PR #621:
URL: https://github.com/apache/tomcat/pull/621#issuecomment-1560963105
I was using URLEncoder class because it was used in original rewriteUrl
method. So I wanted to keep it consistent and keep the changes it to minimum. I
see that Escape.xml(String
markt-asf commented on PR #621:
URL: https://github.com/apache/tomcat/pull/621#issuecomment-1560920115
(Ab)using the URLEncoder for this seems wrong. Tomcat has a class
specifically for escaping values in content -
`org.apache.tomcat.util.security.Escape`. The fix should use this.
alexkachanov commented on code in PR #621:
URL: https://github.com/apache/tomcat/pull/621#discussion_r1203195738
##
test/org/apache/catalina/servlets/TestDefaultServlet.java:
##
@@ -578,6 +578,44 @@ public void testBug57601() throws Exception {
tomcat.stop();
}
alexkachanov commented on code in PR #621:
URL: https://github.com/apache/tomcat/pull/621#discussion_r1203195493
##
java/org/apache/catalina/servlets/DefaultServlet.java:
##
@@ -1650,7 +1654,7 @@ protected InputStream renderXml(HttpServletRequest
request, String contextPath,
alexkachanov commented on code in PR #621:
URL: https://github.com/apache/tomcat/pull/621#discussion_r1203192773
##
java/org/apache/catalina/util/URLEncoder.java:
##
@@ -95,6 +96,8 @@ public final class URLEncoder implements Cloneable {
QUERY.addSafeCharacter('_');
alexkachanov commented on code in PR #621:
URL: https://github.com/apache/tomcat/pull/621#discussion_r1203192504
##
java/org/apache/catalina/util/URLEncoder.java:
##
@@ -40,6 +40,7 @@ public final class URLEncoder implements Cloneable {
public static final URLEncoder
alexkachanov opened a new pull request, #621:
URL: https://github.com/apache/tomcat/pull/621
* fix and junit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
aooohan closed pull request #617: #MessageBytes toString rollback
URL: https://github.com/apache/tomcat/pull/617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
aooohan commented on PR #617:
URL: https://github.com/apache/tomcat/pull/617#issuecomment-1556434703
> Thanks a lot~. And I still have one question: Is the toString method
changing object status a good behavior?
No, not a good behavior. This Class has been refactored before to solve
markt-asf closed pull request #620: Update ci.yml
URL: https://github.com/apache/tomcat/pull/620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on PR #620:
URL: https://github.com/apache/tomcat/pull/620#issuecomment-1556291534
Proposed change not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
DanielR-spec opened a new pull request, #620:
URL: https://github.com/apache/tomcat/pull/620
update description file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
neo-ytx commented on PR #617:
URL: https://github.com/apache/tomcat/pull/617#issuecomment-1554184173
Thanks a lot~. And I still have one question: Is the toString method
changing object status a good behavior?
--
This is an automated message from the Apache Git Service.
To respond to the
aooohan closed pull request #619: Fix Bug 66602: not sending WINDOW_UPDATE when
dataLength is ZERO on call SwallowedDataFramePayload
URL: https://github.com/apache/tomcat/pull/619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
aooohan commented on code in PR #619:
URL: https://github.com/apache/tomcat/pull/619#discussion_r1198570360
##
webapps/docs/changelog.xml:
##
@@ -125,6 +125,9 @@
defined in RFC 9218 rather than the one defined in RFC 7540.
(markt)
+
+
aooohan commented on code in PR #619:
URL: https://github.com/apache/tomcat/pull/619#discussion_r1198570360
##
webapps/docs/changelog.xml:
##
@@ -125,6 +125,9 @@
defined in RFC 9218 rather than the one defined in RFC 7540.
(markt)
+
+
ledefe opened a new pull request, #619:
URL: https://github.com/apache/tomcat/pull/619
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aooohan commented on PR #617:
URL: https://github.com/apache/tomcat/pull/617#issuecomment-1553952940
Hmm. A similar issue has been raised by other user before, look this
https://lists.apache.org/list?us...@tomcat.apache.org:2023-3:openTelemetry
Hope this helps.
--
This is an
aooohan closed pull request #615: Add a reset method to release reference
URL: https://github.com/apache/tomcat/pull/615
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
aooohan commented on PR #615:
URL: https://github.com/apache/tomcat/pull/615#issuecomment-1553948162
I've done this and also cleared up reference elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
aooohan commented on PR #615:
URL: https://github.com/apache/tomcat/pull/615#issuecomment-1553931455
I've look at this, I think this change is a bit complicated. Resetting the
channel while closing it is ok.
--
This is an automated message from the Apache Git Service.
To respond to the
Chaohua95 closed pull request #618: Update MERGE.txt
URL: https://github.com/apache/tomcat/pull/618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Chaohua95 opened a new pull request, #618:
URL: https://github.com/apache/tomcat/pull/618
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
neo-ytx opened a new pull request, #617:
URL: https://github.com/apache/tomcat/pull/617
1. I think toString method should not change the object's status. Because
this method is used for return a String. Most people think they can get
object's stringValue from this method, and will not
pbodnar commented on PR #22:
URL: https://github.com/apache/tomcat/pull/22#issuecomment-1546657736
For anyone searching for this feature, this was implemented by #354 in the
end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pbodnar commented on PR #354:
URL: https://github.com/apache/tomcat/pull/354#issuecomment-1546656729
> Will this be backported to version 9 ?
Actually, it seems like this was merged right into the version 9 branch -
see 101476c3536ac09a105d0b603b2c51dd0f3770e9. So it is available
markt-asf closed pull request #616: Fix backport
URL: https://github.com/apache/tomcat/pull/616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on PR #616:
URL: https://github.com/apache/tomcat/pull/616#issuecomment-1545491107
No explanation was provided for this PR. It is tempting to close it with a
similar lack of explanation. However...
The purpose of the PR is not obvious from the context (the
neillee95 opened a new pull request, #616:
URL: https://github.com/apache/tomcat/pull/616
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
kang-hl opened a new pull request, #615:
URL: https://github.com/apache/tomcat/pull/615
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
kang-hl commented on PR #614:
URL: https://github.com/apache/tomcat/pull/614#issuecomment-1543285158
> The method is necessary. It releases the reference to the SocketWrapper,
allowing it ti be GC'd.
NioSocketWrapper is referenced by NioChannel, and it may need to release the
kang-hl commented on PR #614:
URL: https://github.com/apache/tomcat/pull/614#issuecomment-1543272195
NioSocketWrapper is referenced by NioChannel, and it may need to release the
reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
markt-asf closed pull request #614: Remove unnecessary reset
URL: https://github.com/apache/tomcat/pull/614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
markt-asf commented on PR #614:
URL: https://github.com/apache/tomcat/pull/614#issuecomment-1542634643
The method is necessary. It releases the reference to the SocketWrapper,
allowing it ti be GC'd.
--
This is an automated message from the Apache Git Service.
To respond to the message,
kang-hl opened a new pull request, #614:
URL: https://github.com/apache/tomcat/pull/614
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
isapir merged PR #607:
URL: https://github.com/apache/tomcat/pull/607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
rmannibucau commented on code in PR #607:
URL: https://github.com/apache/tomcat/pull/607#discussion_r1184594119
##
java/org/apache/catalina/util/TimeBucketCounter.java:
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
isapir commented on code in PR #607:
URL: https://github.com/apache/tomcat/pull/607#discussion_r1184526447
##
java/org/apache/catalina/util/TimeBucketCounter.java:
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
isapir commented on code in PR #607:
URL: https://github.com/apache/tomcat/pull/607#discussion_r1184526447
##
java/org/apache/catalina/util/TimeBucketCounter.java:
##
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
markt-asf merged PR #612:
URL: https://github.com/apache/tomcat/pull/612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1531277972
The default `AsynchronousChannelGroup` has adopted a keep-alive of 60s at
some point but since the task never exits, it makes no difference in this case.
We could make the similar
markt-asf commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1531137327
The thread dump confirms the earlier analysis. The
`sun.nio.ch.KQueuePort$EventHandlerTask` never exits so the proposed change
will not have the impact desired.
It would be worth
ChristopherSchultz closed pull request #613: transferTo can transfer only part
of the file, so need to loop
URL: https://github.com/apache/tomcat/pull/613
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ChristopherSchultz commented on PR #613:
URL: https://github.com/apache/tomcat/pull/613#issuecomment-1528121310
@rmaucher applied this PR earlier today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ChristopherSchultz commented on PR #613:
URL: https://github.com/apache/tomcat/pull/613#issuecomment-1528119740
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jackshirazi opened a new pull request, #613:
URL: https://github.com/apache/tomcat/pull/613
We (Elastic APM) have a customer (using tomcat 9.0.72) that is hitting this
bug. The file copy is getting interrupted (likely from CPU time slicing
signals, which is happening because of additional
mjgp2 commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1527404654
I can find this documentation on the
`AsynchronousChannelGroup.withCachedThreadPool` call made within this websocket
code:
```
• An asynchronous channel group associated with a
rmaucher commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525937787
Hum, this is the websocket client and it is using NIO2, so that executor
would be used internally for all things that are run asynchronously for IO like
calling completion handlers and so
markt-asf commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525916279
A thread dump would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjgp2 commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525913263
I'll have a further look at this tomorrow. The situation I have is hundreds
of idle threads. Potentially a configurable solution using virtual threads
would mitigate the issue.
--
This is
markt-asf commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525904959
My reading of the code is that the AsynchronousChannelProvider submits tasks
that never end to the executor so this patch has no effect. The purpose of the
Executor is to replace any
rmaucher commented on PR #612:
URL: https://github.com/apache/tomcat/pull/612#issuecomment-1525822068
This seems like a good idea (although no idea about the best default idle
value). It was like this since the code was initially added.
--
This is an automated message from the Apache Git
thomasmey commented on PR #539:
URL: https://github.com/apache/tomcat/pull/539#issuecomment-1525602662
@rainerjung very nice, many thanks!
I just did test the version which landed in 9.0.74 ...
I will allocate some time next week and do some tests.
As you are also an
rainerjung commented on PR #539:
URL: https://github.com/apache/tomcat/pull/539#issuecomment-1525194171
@thomasmey I added support for all subkeyed patterns like request headers
(%i), response headers (%o) etc. You might want to have a look and test it. It
is now contained in the heads for
dsoumis commented on PR #18:
URL: https://github.com/apache/tomcat-native/pull/18#issuecomment-1523725451
Just a quick way to fetch the prerequisites for building in native, not that
useful, but nice to have. And yes, I think it would be wiser if it's placed in
the native directory.
--
markt-asf commented on PR #18:
URL: https://github.com/apache/tomcat-native/pull/18#issuecomment-1523676472
Tx.
I don't use this script myself. Is it useful? Should it be in the `native`
directory?
--
This is an automated message from the Apache Git Service.
To respond to the
markt-asf merged PR #18:
URL: https://github.com/apache/tomcat-native/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markt-asf commented on PR #17:
URL: https://github.com/apache/tomcat-native/pull/17#issuecomment-1523672553
Thanks for catching this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markt-asf merged PR #17:
URL: https://github.com/apache/tomcat-native/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsoumis opened a new pull request, #18:
URL: https://github.com/apache/tomcat-native/pull/18
It would be best if the downloaded versions are aligned with the recommended
ones (https://github.com/apache/tomcat-native/blob/main/native/srclib/VERSIONS).
--
This is an automated message from
dsoumis opened a new pull request, #17:
URL: https://github.com/apache/tomcat-native/pull/17
Replace steps from non-existent files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
fage88 closed pull request #28: PFCORE-7274 upgrade tomcat 7 version to 7.0.92
URL: https://github.com/apache/tomcat-maven-plugin/pull/28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
fage88 commented on PR #28:
URL:
https://github.com/apache/tomcat-maven-plugin/pull/28#issuecomment-1522064083
Closing this PR, we abandoned Tomcat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
aooohan commented on PR #611:
URL: https://github.com/apache/tomcat/pull/611#issuecomment-1521052913
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
aooohan merged PR #611:
URL: https://github.com/apache/tomcat/pull/611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reftel opened a new pull request, #611:
URL: https://github.com/apache/tomcat/pull/611
Fixes minor annoyance when analyzing log files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] opened a new pull request, #17:
URL: https://github.com/apache/tomcat-training/pull/17
Bumps [lodash](https://github.com/lodash/lodash) from 3.7.0 to 4.17.21.
Release notes
Sourced from https://github.com/lodash/lodash/releases;>lodash's releases.
4.0.0
dependabot[bot] opened a new pull request, #16:
URL: https://github.com/apache/tomcat-training/pull/16
Bumps [debug](https://github.com/debug-js/debug) from 2.2.0 to 2.6.9.
Release notes
Sourced from https://github.com/debug-js/debug/releases;>debug's releases.
2.6.9
dependabot[bot] opened a new pull request, #15:
URL: https://github.com/apache/tomcat-training/pull/15
Bumps [ms](https://github.com/vercel/ms) from 0.7.1 to 2.0.0.
Release notes
Sourced from https://github.com/vercel/ms/releases;>ms's
releases.
2.0.0
Major Changes
dependabot[bot] opened a new pull request, #14:
URL: https://github.com/apache/tomcat-training/pull/14
Bumps [json-schema](https://github.com/kriszyp/json-schema) from 0.2.3 to
0.4.0.
Commits
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1514256218
> @eirbjo Many thanks for your input, that was really helpful. Good luck
with your JDK PR
Thanks, I hope this Tomcat issue helps showcase that this really is a
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1514246160
@eirbjo Many thanks for your input, that was really helpful. Good luck with
your JDK PR
--
This is an automated message from the Apache Git Service.
To respond to
markt-asf closed issue #46: "java.util.zip.ZipException: invalid entry size
(expected 0 but got 913 bytes)" when opening migrated jar with
`java.util.zip.ZipInputStream`
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/46
--
This is an automated message from the Apache Git
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1514233727
I was also working on a fix. I've combined your fix and mine and committed
it. My local test and the unit tests pass.
--
This is an automated message from the
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513834050
Suggested fix, test case to follow
https://github.com/ebourg/tomcat-jakartaee-migration/commit/4d8457d3658bff94510e6b215707e172493f0b71
--
This is an automated
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513823210
Excellent. We can always check if the size > 4GB and log a warning in that
case.
--
This is an automated message from the Apache Git Service.
To respond to the
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513807408
Digging further... my initial intuition of removing the ZIP64 extra field
does really work, I just didn't implement it correctly (I added it only to the
STORED branch
ChristopherSchultz closed pull request #610: Enhance PEMFile to load from an
inputstream too
URL: https://github.com/apache/tomcat/pull/610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ChristopherSchultz commented on PR #610:
URL: https://github.com/apache/tomcat/pull/610#issuecomment-1513785961
I've merged this separately, including a changelog entry.
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message,
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513716893
> If Tomcat does not want to produce such files, you could always overide
the `zip64Mode` option to `never`, instead of the default `as-needed`.
Note that the
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513675091
> Could this be summarized to Java inability to read zip files using ZIP64
fields and streaming data headers?
That sounds right. `java.util.ZipInputStream`
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513668571
Could this be summarized to Java inhability to read zip files using ZIP64
fields and streaming data headers? If so, this means tomcat-jakartaee-migration
could simply
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513655682
> It is also post-processed by BND.
Commenting out the `add-graal` call makes the ZIP64 extra fields disappear.
I have debugged the `zip` call, and `zip` in
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513626451
It is also post-processed by BND.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ChristopherSchultz commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513599230
Sorry @eirbjo I wasn't sure if you meant the JAR file before or after
migration. Apache ant produces the original, and commons-compress produces the
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513597387
> From the OpenJDK side it would be interesting to learn which tool or API
produced the tomcat-embed-10.1.7.jar file.
It was produced by Ant, which has its own
ChristopherSchultz commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513596335
The code is on GH, here:
https://github.com/apache/tomcat-jakartaee-migration/blob/main/src/main/java/org/apache/tomcat/jakartaee/Migration.java
801 - 900 of 1164 matches
Mail list logo
