[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-12-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-12-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Brian Burch changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-12-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #7 from Brian Burch --- Created attachment 29669 --> https://issues.apache.org/bugzilla/attachment.cgi?id=29669&action=edit Faster detection of expired session in timeout test case Reduce run time of testBasicLoginSessionTime

Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-29 Thread Brian Burch
On 29/11/12 16:46, Rainer Jung wrote: On 29.11.2012 17:11, Brian Burch wrote: On 29/11/12 14:37, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 When I looked quickly at your change, the "-" and "+" lines appeared to be identical to me, so I was puzzled.

Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-29 Thread Mark Thomas
Brian Burch wrote: >On 29/11/12 14:37, bugzi...@apache.org wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 >> >> Mark Thomas changed: >> >> What|Removed |Added >> >---

Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-29 Thread Rainer Jung
On 29.11.2012 17:11, Brian Burch wrote: > On 29/11/12 14:37, bugzi...@apache.org wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 > When I looked quickly at your change, the "-" and "+" lines appeared to > be identical to me, so I was puzzled. > > Could you give me an example of

Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-29 Thread Brian Burch
On 29/11/12 14:37, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Mark Thomas changed: What|Removed |Added Status|NEW

[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Brian Burch changed: What|Removed |Added Attachment #29641|0 |1 is obsolete|

[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Brian Burch changed: What|Removed |Added Attachment #29621|0 |1 is obsolete|

Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-22 Thread Brian Burch
On 22/11/12 18:39, Mark Thomas wrote: On 22/11/2012 17:32, Brian Burch wrote: On 22/11/12 16:46, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #3 from Mark Thomas --- Your logic makes sense to me so my preference would be some more comments.

Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-22 Thread Mark Thomas
On 22/11/2012 17:32, Brian Burch wrote: > On 22/11/12 16:46, bugzi...@apache.org wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 >> >> --- Comment #3 from Mark Thomas --- >> Your logic makes sense to me so my preference would be some more >> comments. > > I will think about our

Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-22 Thread Brian Burch
On 22/11/12 16:46, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #3 from Mark Thomas --- Your logic makes sense to me so my preference would be some more comments. I will think about our discussion and try to improve the comments and so hopef

[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #3 from Mark Thomas --- Your logic makes sense to me so my preference would be some more comments. -- You are receiving this mail because: You are the assignee for the bug.

Re: [Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-22 Thread Brian Burch
On 22/11/12 15:17, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #2 from Mark Thomas --- testBasicLoginWithoutSession() seems to repeat the same pair of tests but the comments suggest that something different should happen the second time. What

[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 --- Comment #2 from Mark Thomas --- testBasicLoginWithoutSession() seems to repeat the same pair of tests but the comments suggest that something different should happen the second time. What am I missing? -- You are receiving this mail b

[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190 Brian Burch changed: What|Removed |Added Priority|P2 |P4 Severity|normal