https://bz.apache.org/bugzilla/show_bug.cgi?id=66609
--- Comment #6 from webmascon ---
thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail:
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609
Han Li changed:
What|Removed |Added
Resolution|DUPLICATE |FIXED
--- Comment #5 from Han Li ---
Fixed
markt-asf closed pull request #621: Bug 66609 - invalid XML in directory
listing with file names containing "&" and "'"
URL: https://github.com/apache/tomcat/pull/621
--
This is an automated message from the Apache Git Service.
To respond to the message, please
markt-asf commented on PR #621:
URL: https://github.com/apache/tomcat/pull/621#issuecomment-1561136901
Thanks for the PR. Applied manually with a few tweaks (e.g. CheckStyle
config).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
alexkachanov commented on code in PR #621:
URL: https://github.com/apache/tomcat/pull/621#discussion_r1203991514
##
java/org/apache/catalina/servlets/DefaultServlet.java:
##
@@ -1650,7 +1650,7 @@ protected InputStream renderXml(HttpServletRequest
request, String contextPath,
alexkachanov commented on PR #621:
URL: https://github.com/apache/tomcat/pull/621#issuecomment-1560963105
I was using URLEncoder class because it was used in original rewriteUrl
method. So I wanted to keep it consistent and keep the changes it to minimum. I
see that Escape.xml(String
markt-asf commented on PR #621:
URL: https://github.com/apache/tomcat/pull/621#issuecomment-1560920115
(Ab)using the URLEncoder for this seems wrong. Tomcat has a class
specifically for escaping values in content -
`org.apache.tomcat.util.security.Escape`. The fix should use this.
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609
--- Comment #4 from webmascon ---
created pull request: https://github.com/apache/tomcat/pull/621
--
You are receiving this mail because:
You are the assignee for the bug.
-
alexkachanov commented on code in PR #621:
URL: https://github.com/apache/tomcat/pull/621#discussion_r1203195738
##
test/org/apache/catalina/servlets/TestDefaultServlet.java:
##
@@ -578,6 +578,44 @@ public void testBug57601() throws Exception {
tomcat.stop();
}
alexkachanov commented on code in PR #621:
URL: https://github.com/apache/tomcat/pull/621#discussion_r1203195493
##
java/org/apache/catalina/servlets/DefaultServlet.java:
##
@@ -1650,7 +1654,7 @@ protected InputStream renderXml(HttpServletRequest
request, String contextPath,
alexkachanov commented on code in PR #621:
URL: https://github.com/apache/tomcat/pull/621#discussion_r1203192773
##
java/org/apache/catalina/util/URLEncoder.java:
##
@@ -95,6 +96,8 @@ public final class URLEncoder implements Cloneable {
QUERY.addSafeCharacter('_');
alexkachanov commented on code in PR #621:
URL: https://github.com/apache/tomcat/pull/621#discussion_r1203192504
##
java/org/apache/catalina/util/URLEncoder.java:
##
@@ -40,6 +40,7 @@ public final class URLEncoder implements Cloneable {
public static final URLEncoder
alexkachanov opened a new pull request, #621:
URL: https://github.com/apache/tomcat/pull/621
* fix and junit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609
--- Comment #3 from Han Li ---
(In reply to webmascon from comment #2)
> The bug may be similar to bug 33535, but bug 33535 says only about & in the
> names of the files. My bug report says that there are can be symbols that
> are not valid
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609
--- Comment #2 from webmascon ---
The bug may be similar to bug 33535, but bug 33535 says only about & in the
names of the files. My bug report says that there are can be symbols that are
not valid for XML, such as symbol "'". And I have a
https://bz.apache.org/bugzilla/show_bug.cgi?id=66609
Han Li changed:
What|Removed |Added
OS||All
Status|NEW
16 matches
Mail list logo
