markt-asf commented on PR #700:
URL: https://github.com/apache/tomcat/pull/700#issuecomment-1969192558
I'm closing this as I have come up with a better plan that makes slightly
better uses of the existing facades to trigger some NPEs when this happens.
--
This is an automated message
markt-asf closed pull request #700: Attempt to protect against asynchronous
thread safety violations
URL: https://github.com/apache/tomcat/pull/700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
rmaucher commented on PR #700:
URL: https://github.com/apache/tomcat/pull/700#issuecomment-1964203702
I feel ok with this sort of thread safety additions [there could be a lot !]
if they have a system property to enable them. Then it becomes useful as a way
to detect problems, although I
markt-asf commented on PR #700:
URL: https://github.com/apache/tomcat/pull/700#issuecomment-1964174647
Fair point.
The complicating factor is that there are so many entry points that a
non-container thread could use. A complete solution would need to, effectively,
wrap the
rmaucher commented on PR #700:
URL: https://github.com/apache/tomcat/pull/700#issuecomment-1964127701
Anywhere else can also be similarly synced, then. I don't think it is a good
idea to insert random thread safety safeguards in addition to what the
specification mandates. Time for a
markt-asf opened a new pull request, #700:
URL: https://github.com/apache/tomcat/pull/700
Providing this as a PR as it isn't strictly a Tomcat bug or Tomcat's problem
to solve. That said, we do see some asynchronous bug reports and this might
help highlight application issues early and
