markt-asf merged PR #674:
URL: https://github.com/apache/tomcat/pull/674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776796215
Yes, through shading only to make them private. Looking at the vast amount
of code you have written already I bet that ther are also others which would
like to use such a PEM to Java
markt-asf commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776785906
Added a test key using AES128 (test passed without additional code changes).
Fixed typo.
Removed debug code that wasn't intended to be part of the commit.
I might be persuaded to
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1776767268
Built from your branch and I can confirm that this works with a selfsigned
and one issued by our enterprise CA.
--
This is an automated message from the Apache Git Service.
To respond
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775942678
Thanks for the hard work. I will try this tomorrow/Wednesday!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
michael-o commented on code in PR #674:
URL: https://github.com/apache/tomcat/pull/674#discussion_r1369211534
##
test/org/apache/tomcat/util/net/jsse/TestPEMFile.java:
##
@@ -118,4 +127,17 @@ private String getPath(String file) throws IOException {
return
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775933882
The more ASN.1 I see in Tomcat the more I think is that we should import
Kerby ASN.1 at some point in time...
--
This is an automated message from the Apache Git Service.
To respond to
michael-o commented on code in PR #674:
URL: https://github.com/apache/tomcat/pull/674#discussion_r1369136617
##
java/org/apache/tomcat/util/net/jsse/PEMFile.java:
##
@@ -64,8 +66,40 @@ public class PEMFile {
private static final byte[] OID_EC_PUBLIC_KEY =
michael-o commented on PR #674:
URL: https://github.com/apache/tomcat/pull/674#issuecomment-1775825928
There is also AES128 with OpenSSL anf should be tried as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
